diff mbox

[dpdk-dev] table: fix table_array for incomplete bitmask

Message ID 3EB4FA525960D640B5BDFFD6A3D89126322DA654@IRSMSX108.ger.corp.intel.com (mailing list archive)
State Not Applicable, archived
Headers

Commit Message

Cristian Dumitrescu Dec. 4, 2014, 3:23 p.m. UTC 
  Acked by: <Cristian.Dumitrescu at intel.com>

-----Original Message-----
From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
Sent: Thursday, December 4, 2014 2:24 PM
To: dev@dpdk.org
Subject: [dpdk-dev] [PATCH] table: fix table_array for incomplete bitmask

When a lookup was done on a table_array structure with an incomplete
bitmask, the results was always zero hits. This was because the
pkts_mask value was cleared as we process each entry, and the result
was assigned at the end of the loop, when pkts_mask was zero.
Changing the assignment to occur at the start, before the pkts_mask
gets cleared, fixes this issue.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_table/rte_table_array.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Thomas Monjalon Dec. 5, 2014, 4:18 p.m. UTC | #1 
> When a lookup was done on a table_array structure with an incomplete
> bitmask, the results was always zero hits. This was because the
> pkts_mask value was cleared as we process each entry, and the result
> was assigned at the end of the loop, when pkts_mask was zero.
> Changing the assignment to occur at the start, before the pkts_mask
> gets cleared, fixes this issue.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>

> Acked by: <Cristian.Dumitrescu at intel.com>

Applied

Thanks
diff mbox

Patch

diff --git a/lib/librte_table/rte_table_array.c b/lib/librte_table/rte_table_array.c
index 0b1d42a..4d3c05e 100644
--- a/lib/librte_table/rte_table_array.c
+++ b/lib/librte_table/rte_table_array.c
@@ -164,6 +164,8 @@  rte_table_array_lookup(
 {
 	struct rte_table_array *t = (struct rte_table_array *) table;
 
+	*lookup_hit_mask = pkts_mask;
+
 	if ((pkts_mask & (pkts_mask + 1)) == 0) {
 		uint64_t n_pkts = __builtin_popcountll(pkts_mask);
 		uint32_t i;
@@ -190,8 +192,6 @@  rte_table_array_lookup(
 		}
 	}
 
-	*lookup_hit_mask = pkts_mask;
-
 	return 0;
 }