[dpdk-dev,4/4] doc: Various document fixes in testpmd UG

Message ID 1416078796-689-5-git-send-email-pablo.de.lara.guarch@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

De Lara Guarch, Pablo Nov. 15, 2014, 7:13 p.m. UTC
  Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)
  

Comments

Thomas Monjalon Dec. 3, 2014, 1:17 p.m. UTC | #1
2014-11-15 19:13, Pablo de Lara:
> --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
[...]
> -Quit to prompt in Linux or reboot on Baremetal:
> +Quit to prompt in Linux/FreeBSD or reboot on Baremetal:

Bare-metal traces have been removed.
  
De Lara Guarch, Pablo Dec. 3, 2014, 1:26 p.m. UTC | #2
Hi Thomas,

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> Sent: Wednesday, December 03, 2014 1:18 PM
> To: De Lara Guarch, Pablo
> Cc: dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 4/4] doc: Various document fixes in testpmd
> UG
> 
> 2014-11-15 19:13, Pablo de Lara:
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> [...]
> > -Quit to prompt in Linux or reboot on Baremetal:
> > +Quit to prompt in Linux/FreeBSD or reboot on Baremetal:
> 
> Bare-metal traces have been removed.
You are looking at the v1, I sent a v5 last Monday without that part.

> 
> --
> Thomas
  
Thomas Monjalon Dec. 3, 2014, 1:38 p.m. UTC | #3
2014-12-03 13:26, De Lara Guarch, Pablo:
> Hi Thomas,
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Thomas Monjalon
> > Sent: Wednesday, December 03, 2014 1:18 PM
> > To: De Lara Guarch, Pablo
> > Cc: dev@dpdk.org
> > Subject: Re: [dpdk-dev] [PATCH 4/4] doc: Various document fixes in testpmd
> > UG
> > 
> > 2014-11-15 19:13, Pablo de Lara:
> > > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > [...]
> > > -Quit to prompt in Linux or reboot on Baremetal:
> > > +Quit to prompt in Linux/FreeBSD or reboot on Baremetal:
> > 
> > Bare-metal traces have been removed.
> You are looking at the v1, I sent a v5 last Monday without that part.

Exact, sorry.
So I guess Bernard should update his branch (I was looking at dpdk-doc):
	http://dpdk.org/browse/next/dpdk-doc/commit/?id=fc888aeff9fe
  
Iremonger, Bernard Dec. 4, 2014, 11:27 a.m. UTC | #4
Hi Thomas,

> Subject: Re: [dpdk-dev] [PATCH 4/4] doc: Various document fixes in testpmd UG
> 
> 2014-11-15 19:13, Pablo de Lara:
> > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
> [...]
> > -Quit to prompt in Linux or reboot on Baremetal:
> > +Quit to prompt in Linux/FreeBSD or reboot on Baremetal:
> 
> Bare-metal traces have been removed.
My attempt to resolve a conflict with this line has caused confusion.
I had not noticed that the Bare-metal patch had also updated the doc's, and referred to the original MSWord document.
> 
> --
> Thomas

Bernard.
  

Patch

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 2e64a3a..7dd9c3a 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -103,7 +103,7 @@  stop
 quit
 ~~~~
 
-Quit to prompt in Linux or reboot on Baremetal:
+Quit to prompt in Linux/FreeBSD or reboot on Baremetal:
 
 quit
 
@@ -153,10 +153,12 @@  For example:
 show port rss-hash
 ~~~~~~~~~~~~~~~~~~
 
-Display the RSS hash functions and RSS hash key of port (port_id).
+Display the RSS hash functions and RSS hash key of a port:
 
-show port (port_id) rss-hash [key] clear port
-~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+show port (port_id) rss-hash [key]
+
+clear port
+~~~~~~~~~~
 
 Clear the port statistics for a given port or for all ports: