Message ID | 20160928100519.14885-1-ferruh.yigit@intel.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 136B05598; Wed, 28 Sep 2016 12:05:24 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A7BC05597 for <dev@dpdk.org>; Wed, 28 Sep 2016 12:05:22 +0200 (CEST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga105.fm.intel.com with ESMTP; 28 Sep 2016 03:05:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,409,1470726000"; d="scan'208";a="14045391" Received: from sivswdev02.ir.intel.com ([10.237.217.46]) by fmsmga006.fm.intel.com with ESMTP; 28 Sep 2016 03:05:20 -0700 From: Ferruh Yigit <ferruh.yigit@intel.com> To: dev@dpdk.org Cc: Neil Horman <nhorman@tuxdriver.com> Date: Wed, 28 Sep 2016 11:05:19 +0100 Message-Id: <20160928100519.14885-1-ferruh.yigit@intel.com> X-Mailer: git-send-email 2.8.4 Subject: [dpdk-dev] [PATCH] pmdinfogen: fix clang build error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Ferruh Yigit
Sept. 28, 2016, 10:05 a.m. UTC
Compile error:
CC mlx5.o.pmd.o
mlx5.o.pmd.c:1:227:
error: no newline at end of file [-Werror,-Wnewline-eof]
...__attribute__((used)) = "PMD_INFO_STRING= {...}";
^
Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG
config options enabled.
Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility")
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
buildtools/pmdinfogen/pmdinfogen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote: > Compile error: > CC mlx5.o.pmd.o > mlx5.o.pmd.c:1:227: > error: no newline at end of file [-Werror,-Wnewline-eof] > ...__attribute__((used)) = "PMD_INFO_STRING= {...}"; > ^ > > Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG > config options enabled. > > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> > --- > buildtools/pmdinfogen/pmdinfogen.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c > index e1bf2e4..59ab956 100644 > --- a/buildtools/pmdinfogen/pmdinfogen.c > +++ b/buildtools/pmdinfogen/pmdinfogen.c > @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile) > else > fprintf(ofd, " "); > } > - fprintf(ofd, "]}\";"); > + fprintf(ofd, "]}\";\n"); > drv = drv->next; > } > > -- > 2.7.4 > > What was the error this produced? It seems like a false positive to me to require a newline at the end of a string, and it certainly doesn't provide any benefit when pmdinfo reads it back later. Neil
On 9/28/2016 12:35 PM, Neil Horman wrote: > On Wed, Sep 28, 2016 at 11:05:19AM +0100, Ferruh Yigit wrote: >> Compile error: >> CC mlx5.o.pmd.o >> mlx5.o.pmd.c:1:227: >> error: no newline at end of file [-Werror,-Wnewline-eof] >> ...__attribute__((used)) = "PMD_INFO_STRING= {...}"; >> ^ >> >> Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG >> config options enabled. >> >> Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") >> >> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> >> --- >> buildtools/pmdinfogen/pmdinfogen.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c >> index e1bf2e4..59ab956 100644 >> --- a/buildtools/pmdinfogen/pmdinfogen.c >> +++ b/buildtools/pmdinfogen/pmdinfogen.c >> @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile) >> else >> fprintf(ofd, " "); >> } >> - fprintf(ofd, "]}\";"); >> + fprintf(ofd, "]}\";\n"); >> drv = drv->next; >> } >> >> -- >> 2.7.4 >> >> > > What was the error this produced? It seems like a false positive to me to > require a newline at the end of a string, and it certainly doesn't provide any > benefit when pmdinfo reads it back later. clang is complaining about missing newline while compiling autogenerated file, build error is on commit log.
2016-09-28 11:05, Ferruh Yigit: > Compile error: > CC mlx5.o.pmd.o > mlx5.o.pmd.c:1:227: > error: no newline at end of file [-Werror,-Wnewline-eof] > ...__attribute__((used)) = "PMD_INFO_STRING= {...}"; > ^ > > Produced with clang 3.8.0 and MLX5_PMD and MLX5_DEBUG > config options enabled. > > Fixes: 98b0fdb0ffc6 ("pmdinfogen: add buildtools and pmdinfogen utility") > > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied, thanks
diff --git a/buildtools/pmdinfogen/pmdinfogen.c b/buildtools/pmdinfogen/pmdinfogen.c index e1bf2e4..59ab956 100644 --- a/buildtools/pmdinfogen/pmdinfogen.c +++ b/buildtools/pmdinfogen/pmdinfogen.c @@ -386,7 +386,7 @@ static void output_pmd_info_string(struct elf_info *info, char *outfile) else fprintf(ofd, " "); } - fprintf(ofd, "]}\";"); + fprintf(ofd, "]}\";\n"); drv = drv->next; }