Message ID | 1472704915-13112-2-git-send-email-shreyansh.jain@nxp.com (mailing list archive) |
---|---|
State | Superseded, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 653D638EB; Thu, 1 Sep 2016 06:42:21 +0200 (CEST) Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0088.outbound.protection.outlook.com [104.47.37.88]) by dpdk.org (Postfix) with ESMTP id EC87237B4 for <dev@dpdk.org>; Thu, 1 Sep 2016 06:42:19 +0200 (CEST) Received: from BN3PR0301CA0074.namprd03.prod.outlook.com (10.160.152.170) by SN1PR0301MB2016.namprd03.prod.outlook.com (10.163.226.26) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.13; Thu, 1 Sep 2016 04:42:18 +0000 Received: from BY2FFO11FD055.protection.gbl (2a01:111:f400:7c0c::198) by BN3PR0301CA0074.outlook.office365.com (2a01:111:e400:401e::42) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.609.9 via Frontend Transport; Thu, 1 Sep 2016 04:42:18 +0000 Authentication-Results: spf=fail (sender IP is 192.88.158.2) smtp.mailfrom=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; nxp.com; dmarc=fail action=none header.from=nxp.com; nxp.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.158.2 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.158.2; helo=az84smr01.freescale.net; Received: from az84smr01.freescale.net (192.88.158.2) by BY2FFO11FD055.mail.protection.outlook.com (10.1.15.192) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Thu, 1 Sep 2016 04:42:17 +0000 Received: from Tophie.ap.freescale.net ([10.232.14.87]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id u814g8Qx029498; Wed, 31 Aug 2016 21:42:14 -0700 From: Shreyansh Jain <shreyansh.jain@nxp.com> To: <viktorin@rehivetech.com>, <dev@dpdk.org> CC: <thomas.monjalon@6wind.com>, Shreyansh Jain <shreyansh.jain@nxp.com> Date: Thu, 1 Sep 2016 10:11:51 +0530 Message-ID: <1472704915-13112-2-git-send-email-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> References: <1472704915-13112-1-git-send-email-shreyansh.jain@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131171785376535253; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.158.2; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(199003)(189002)(92566002)(626004)(8666005)(356003)(305945005)(7846002)(76176999)(11100500001)(50986999)(8676002)(8936002)(50226002)(81156014)(81166006)(2906002)(4326007)(68736007)(5660300001)(189998001)(586003)(47776003)(69596002)(5001770100001)(229853001)(97736004)(33646002)(36756003)(104016004)(5003940100001)(19580405001)(19580395003)(48376002)(86362001)(77096005)(105606002)(87936001)(2950100001)(85426001)(106466001)(50466002)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0301MB2016; H:az84smr01.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11FD055; 1:xQaMh25ikn+hTy96i5QU/E0fAXO5HZsjC5ngp9JI88cZCCwbLuhh/WHn8SaMTj79PlTsxd92rCyZFwWWde/JGBAu2tO7nocsknryA+e4woDXeq15z77SNj8J+/Hn80m0+j/wPQWwK3601tQEsAQyAhEi24O1HdOhtEEka7TCRp/0C3/qkw0QEanRNV3OpupDNuCyivSGpFgOBoP0Ko15k4dlfU8R5tWwFcI3TQ+0sxICyS8nrbmJYhPQP6Mf9RBDhdt4KBgxgfPJisFu/1VE7x0qU5gYRZ3Tm2lmAj1YrPbgTuYFWKkU6ZFKkB4CpbuaqWSdp15oSVIPANTe35LHx4c6U7LrDJr7Ru6RxODnvafRe8DPqInTv4As8pUYMtvMzVyJhf2Dix/JWbHcTXZbta3esTng4ayI2FMprqncrQFE4UxQjsFq0vvjxSduoLlellzOsJ77xgtdW2K3jNF4A6QuRu5R0zvE3yxtr0tqlHNG1UBCDIOw1roxl4/E2fvjf5ZMKJf9GCUVMT+p3XMv5xCV1pJmqC2u24CUOory8SWLmVM0wNmiiu9emMLuxnG/vhlqZEw9BfrQGqAsPsK18esED4qpCwmuv4VZEBHoenecxDZoOIAbDd9AUqVa5dTFm3uIlCjU4KyzN9lsL+41CYxR4mpOVPwdIREdaOPG0OPxXv2aYtPj+KSWb94k7MvSZSLzdLENN71SagYtNzqNEvSWhTdEtIDKD0Himlpy4vA= MIME-Version: 1.0 Content-Type: text/plain X-MS-Office365-Filtering-Correlation-Id: c4fee1f7-236b-4bda-a67e-08d3d2225a4d X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2016; 2:vHEGucBy+13WOr6xSyXJa0Seq+a9Msr9xRS+v1bATJ1Y3YfJvyN7/tw0CqtnLf54tJkADluVUVaydOMAJYb36ndWW422nkYSePZuyWj/HHXALp0lgZZd5wvnGW/ORKudw0MNC6HuUG7dKK48/h+POi5yKQiyIvJQIlj9/72QxpzsjChfhyU3DDvMmPJAFcgp; 3:H5ggPU1E7poWrjR805cp6G+tyuJ5zuyst72hyHiPX8UzXUrCz1QBWZk23g3p5TcnHESugJk5f5Col7XbOIRggqDJmmlu3MK9CzAoLcQcWmmYxgsJErcfYaZ5H9P/kZlw1r/iXAe7iXisT3iJF0ZPNyC5VeHdCmpjQZGScArMobEyTT/sTQllEzb2awSHM/wk71ocUEQjmtW4oJXYIMi93Xyp2KkyAVBt2zzP9s+V2UU=; 25:MBi2JQCHNv5E/DkoyQg6a/Hxb2kD4xIvet6YFEHUbePEGEB4kwuvgPsyhn7E+i60v4RlylQaI0FIFgaFqH3kcX2QfY8Tc2njAK6m8QkSfRFIJBKpn0mhHtzOJnEaXG4yhmpW8Utg3Vs7mkxMpvH+pEImyW1b64+h6kSJKilMgcQIflNhV5gE0yqjSn91IrS/gv2X+I373uAYALRo4TI6CRWu9T6JclDZJ/9iZF7Qnuib8EIqFXoCWYt3WjQfsp0IcbYRj3TIZKr0BRP4uQNXdeu1CEM60S/NMdWCB5du8FMxISXrTO2CD9ullEhCd9RzOp/NZ+UlpyZ9tLY/5thZl9kO74S8+JIsGh0hkIjIHZoiLMyZwWrGCAy7lCakjcCTiLYLvqb/jjAJodomeJ6vfVA09HuenL9ky5nHhh9mvMI= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:SN1PR0301MB2016; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2016; 31:5CNeHM4SnK5vjIKouJYwU0mslTw3P40K2NY4jskgZ2g7yNSltFjcl3cncnuvp4hWuBX6jDRzGhj2jfYucjLZgbqsXQIJcju805zF/mi4fgQnpxm2tKQw8Cm9UmMOn/rJkgCxFySQgM0GSwBLB+dHHW/ruVIlbpbTgpbFWlgW9R3Q4AQKdlyXKinCX3BWyOkQZMpX/1Sm9uZkSZEomDsLhLLBCZ7Pbxt1ES9EkEBZlds=; 4:Qoxxl8JMOmxIot9PI34BtjfV6wmBh4/H5qYfjzvBRDMgmcv6+lXaxnAd7oYZe5FIcpLePw07Ettq7dXMGghtkmyLbMu+FfetdiA4gCt3nqq9Xg+O/NP6TUAmj6WWfdDzmskJDNnQDkA5orN3OVZK84yl/jKki7RnY8WBuB3zrymT0ifppfAkfUn1dMdfkeDv/q8RQWYJPwcal+XHBT4KfXweVVQC/sXpoILsYJjdX1x6Bez3cTeQe1owXQ1jwTt3bTEnmQSx/BnU7fj2J2K+wnE1VDOl1n1ndROaS2AdqNP4XUV+9fHlOBlzfESnXiFcby+/v6tZZMuYM3hlt8iAT/Xvnd+5ZUlLPv8NBgo3f/bD1djDPymQmGefKxYxZtUIPZ6k9XxuoN/cK4cHOPVdfoFgNz+DHGRjzrljZ8jWNsFMFur5jQwEYD3iSADwurSrYuXRlRFLeRKwjYoR6bLgp2F1G/ZacuglNltA8g+PqsbwzS1UggCtkx497hZDKANawkFOU3ssIBI0eEBTBXF9q9zOx0ig4U+iPogu7fWCP8U= X-Microsoft-Antispam-PRVS: <SN1PR0301MB2016A8B564B7A238562EDD4990E20@SN1PR0301MB2016.namprd03.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(13015025)(13017025)(13024025)(13023025)(13018025)(10201501046)(3002001)(6055026); SRVR:SN1PR0301MB2016; BCL:0; PCL:0; RULEID:(400006); SRVR:SN1PR0301MB2016; X-Forefront-PRVS: 0052308DC6 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; SN1PR0301MB2016; 23:ON3W5bGFw0FmD4NKbpulqKH1zqwD65rMKsCM1Bb?= =?us-ascii?Q?eKZD1LpGwnAO1mHtsTxkycg8JAlfj4DM3E1qgpx6uX5EdUfm2wov+P6n7W1l?= =?us-ascii?Q?HhSMZjhtcaI3GQr7Jfq4QO/HKgKp9Dncdhri+SoWR4O+mM5pIU5H28yFWaSh?= =?us-ascii?Q?ldhbmHV5y9HuJ/DqzuRBErR+6pzYwljnnrKWvW/WcFa1MlZHJSD2Si/y1G+4?= =?us-ascii?Q?tX/E92y62MeAzDn2MVZEJDU3L0vMqr1cWBEkeOB1A44LzbtKi7XvsUBw8xW7?= =?us-ascii?Q?US5soS1f6VGCRJjBTzHLZnaeio7I4NpDYJXDG+N0owT/Xp0NnT5Ka0BVCEXw?= =?us-ascii?Q?MRa5ktDz+Nn8VNrETyTKncZKSx23cpsVEG5uKXJw5c5lAcASl70QqubmupKU?= =?us-ascii?Q?9ExvK4hJ4qLUogv3JyEsZ8jtOUsuUpNmfqK6Fo7NY4lfVcsn6eYZ4f9S0INX?= =?us-ascii?Q?atS7bro4pPTYWotKHQJGiEjo7vtIsKhEORDg6DI4eMFNHODoikeTycYdViMZ?= =?us-ascii?Q?TvHisTyeCMAfwAC8os0bdCFZN4UjpsZHWZhKIG5/jqbf9++n+2TQBUhLShPV?= =?us-ascii?Q?iMh3r2sSgn2SZ9WKfsEmD7DElu70TsYZFvjEjAfUaGa8gd4vB4C51DudknM/?= =?us-ascii?Q?yNQ+wfQPY+UlEmyK3lZk4cMKsW8G+6Yw/7gJc28GIhs2g2cN6wbL1XjqzxN4?= =?us-ascii?Q?mDqHoQEbgXmgf2+dGuXJnyzLCKv+OOrbEBl6DOt9100wfGeajfZCIHNzuwBt?= =?us-ascii?Q?o+PF1iF7kFAZJxo7498lUHltnO00y8MzyVu812j7VQsZio9TE4uTJOnTLbVg?= =?us-ascii?Q?Ys37qXXnn+exo05XJUWZ5eSeLK8gpV7HwwzP9Ipa8pJfYT8Qg9hbMVPhG+kX?= =?us-ascii?Q?6eOdMYYLIRoH+ccpB7Mf1Acke3VR1wYgTyJF0ShGYKiRvJXzrLAIi/3+5cYk?= =?us-ascii?Q?22MVUaDH+OsahP2gxhbHeWTyGDAM2Q9MVtCyZgByYXgSO84D0tUqd5vglX8g?= =?us-ascii?Q?mEktHdmlcWBcIsg570z698os26Pgava7EFnZ9+qj/Cr2qruEivT9AqwJ45hG?= =?us-ascii?Q?0c16X8qGGCdipxjr58gXJzGYTegqAljP83aEl7KfTjWXuyfBJlfWAuAlG4U1?= =?us-ascii?Q?PVhfNW5Ys32nvS3EKuYDVsKd5u7e+gml2ajYVPLATWR+ywSqsa4ppVT26Ys6?= =?us-ascii?Q?0EyIpvZ0N2qI8mec=3D?= X-Microsoft-Exchange-Diagnostics: 1; SN1PR0301MB2016; 6:+tgAHZCrfT0bYQ8k8DAY9i20ZTfuHg7BI/TrUyJPUOXXrcgLQAeAykEU09VZSAGiUwxRDJIzgdYYnIqPh9hw8OvVS3iF4aeuikGiqRU0UskYV4jKcm0Va23AD51fHqrHDxNMub8XqvmUltN6BowNRhmOy3WumqLiKjVbepSMn6avx5A2PkGxs0bHo+/uFX0MZjpsoke+LOirHfXj8JmrUUx/tz5ywXTIxYYNYgymWqSlOa92blGakgg0MgtqLyY6zLSwGlZYBolfE94ZcRhinckWyV3IynlZpoiRPJL6IeY=; 5:EFDt4aMMxT3ktUZCZoSj2PL7VZjIajMeRhvgaNO+9XucbUnpHz4kabcDdifKHMtOuuXubjiG6YLtDYslkl2uLj8UO28DlH27NEx4L1OyTEujhnk2Je3ebdQCAajhFWgfQMFJvy/gnGQVZxpPRVukFSY0pyd5D5VmlKiASaQEefg=; 24:oJcJ+xapa01mZavOpJP2q7sOhb5N8jeSzMoMEiWUCRcBcLXQHXVOBPdGh6akiadW4PRxLmsNAa+cxowEqTh2FpPagIIaHIqaCWiqh+PUvhk=; 7:+hP3RwiJMCijYmZpKz6A5c59dZM7kfQekQbf39xxtPfBr+vXaIGizeUlnH5cCThEbwfUATnDs4zsrUVsFMkgz+8LXy5I3O5UzzNYb43PJ6t1wYbeV5ALzzGs4fat1l6ItYCoGmIdro0JpJZJ8scm/B+F446D9huUyZcDv3DGy9CKGpYcyXknpkOtGWkxdrAv/ZlbSvzgQT53889q+5nF6x3p3Wgepevq0FmXesoNI5aNX4z2rNoC9dnXXrrvGlwN SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2016 04:42:17.1699 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.158.2]; Helo=[az84smr01.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0301MB2016 Subject: [dpdk-dev] [PATCH 1/5] eal: make enum rte_kernel_driver non-PCI specific X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Shreyansh Jain
Sept. 1, 2016, 4:41 a.m. UTC
From: Jan Viktorin <viktorin@rehivetech.com> From: Jan Viktorin <viktorin@rehivetech.com> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com> --- lib/librte_eal/common/include/rte_dev.h | 12 ++++++++++++ lib/librte_eal/common/include/rte_pci.h | 9 --------- 2 files changed, 12 insertions(+), 9 deletions(-)
Comments
On Thu, Sep 01, 2016 at 10:11:51AM +0530, Shreyansh Jain wrote: > From: Jan Viktorin <viktorin@rehivetech.com> > > From: Jan Viktorin <viktorin@rehivetech.com> > > Signed-off-by: Jan Viktorin <viktorin@rehivetech.com> > Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com> Hi, FYI, my testrobot caught some errors when this patch is applied. --yliu --- i686-native-linuxapp-gcc: config-all-yes ======================================== In file included from lib/librte_eal/linuxapp/eal/eal_pci.c:38:0: i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ ^ In file included from lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c:52:0: i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ ^ In file included from lib/librte_eal/common/eal_private.h:38:0, from lib/librte_eal/linuxapp/eal/eal_thread.c:55: i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ ^ make[7]: *** [eal_thread.o] Error 1 make[7]: *** Waiting for unfinished jobs.... In file included from lib/librte_eal/linuxapp/eal/eal.c:72:0: i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ ^ In file included from lib/librte_eal/common/eal_private.h:38:0, from lib/librte_eal/linuxapp/eal/eal_memory.c:97: i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ ^ In file included from lib/librte_eal/common/eal_private.h:38:0, from lib/librte_eal/linuxapp/eal/eal_log.c:50: i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ ^ make[7]: *** [eal_log.o] Error 1 make[7]: *** [eal_vfio_mp_sync.o] Error 1 In file included from lib/librte_eal/common/eal_private.h:38:0, from lib/librte_eal/linuxapp/eal/eal_vfio.c:45: i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ ^ make[7]: *** [eal.o] Error 1 make[7]: *** [eal_memory.o] Error 1 make[7]: *** [eal_vfio.o] Error 1 lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_map_device': lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) case RTE_KDRV_VFIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: note: each undeclared identifier is reported only once for each function it appears in lib/librte_eal/linuxapp/eal/eal_pci.c:139:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) case RTE_KDRV_IGB_UIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:140:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) case RTE_KDRV_UIO_GENERIC: ^ lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_unmap_device': lib/librte_eal/linuxapp/eal/eal_pci.c:160:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) case RTE_KDRV_VFIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:163:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) case RTE_KDRV_IGB_UIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:164:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) case RTE_KDRV_UIO_GENERIC: ^ lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'pci_scan_one': lib/librte_eal/linuxapp/eal/eal_pci.c:381:16: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) dev->kdrv = RTE_KDRV_VFIO; ^ lib/librte_eal/linuxapp/eal/eal_pci.c:383:16: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) dev->kdrv = RTE_KDRV_IGB_UIO; ^ lib/librte_eal/linuxapp/eal/eal_pci.c:385:16: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) dev->kdrv = RTE_KDRV_UIO_GENERIC; ^ lib/librte_eal/linuxapp/eal/eal_pci.c:387:16: error: 'RTE_KDRV_UNKNOWN' undeclared (first use in this function) dev->kdrv = RTE_KDRV_UNKNOWN; ^ lib/librte_eal/linuxapp/eal/eal_pci.c:389:15: error: 'RTE_KDRV_NONE' undeclared (first use in this function) dev->kdrv = RTE_KDRV_NONE; ^ lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_map': lib/librte_eal/linuxapp/eal/eal_pci.c:626:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) case RTE_KDRV_VFIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:631:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) case RTE_KDRV_IGB_UIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:634:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) case RTE_KDRV_UIO_GENERIC: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:641:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) case RTE_KDRV_NONE: ^ lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_read': lib/librte_eal/linuxapp/eal/eal_pci.c:662:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) case RTE_KDRV_VFIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:666:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) case RTE_KDRV_IGB_UIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:669:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) case RTE_KDRV_UIO_GENERIC: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:672:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) case RTE_KDRV_NONE: ^ lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_write': lib/librte_eal/linuxapp/eal/eal_pci.c:688:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) case RTE_KDRV_VFIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:692:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) case RTE_KDRV_IGB_UIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:695:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) case RTE_KDRV_UIO_GENERIC: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:698:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) case RTE_KDRV_NONE: ^ lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_unmap': lib/librte_eal/linuxapp/eal/eal_pci.c:715:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) case RTE_KDRV_VFIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:720:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) case RTE_KDRV_IGB_UIO: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:723:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) case RTE_KDRV_UIO_GENERIC: ^ lib/librte_eal/linuxapp/eal/eal_pci.c:730:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) case RTE_KDRV_NONE: ^ make[7]: *** [eal_pci.o] Error 1 make[6]: *** [eal] Error 2 make[5]: *** [linuxapp] Error 2 make[4]: *** [librte_eal] Error 2 make[3]: *** [lib] Error 2 make[2]: *** [all] Error 2 make[1]: *** [pre_install] Error 2 make: *** [install] Error 2 error: build failed
Hi, On Sunday 11 September 2016 05:45 PM, Yuanhan Liu wrote: > On Thu, Sep 01, 2016 at 10:11:51AM +0530, Shreyansh Jain wrote: >> From: Jan Viktorin <viktorin@rehivetech.com> >> >> From: Jan Viktorin <viktorin@rehivetech.com> >> >> Signed-off-by: Jan Viktorin <viktorin@rehivetech.com> >> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com> > > Hi, > > FYI, my testrobot caught some errors when this patch is applied. > > --yliu > > --- > i686-native-linuxapp-gcc: config-all-yes > ======================================== > In file included from lib/librte_eal/linuxapp/eal/eal_pci.c:38:0: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c:52:0: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_thread.c:55: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > make[7]: *** [eal_thread.o] Error 1 > make[7]: *** Waiting for unfinished jobs.... > In file included from lib/librte_eal/linuxapp/eal/eal.c:72:0: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_memory.c:97: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_log.c:50: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > make[7]: *** [eal_log.o] Error 1 > make[7]: *** [eal_vfio_mp_sync.o] Error 1 > In file included from lib/librte_eal/common/eal_private.h:38:0, > from lib/librte_eal/linuxapp/eal/eal_vfio.c:45: > i686-native-linuxapp-gcc/include/rte_pci.h:157:25: error: field 'kdrv' has incomplete type > enum rte_kernel_driver kdrv; /**< Kernel driver passthrough */ > ^ > make[7]: *** [eal.o] Error 1 > make[7]: *** [eal_memory.o] Error 1 > make[7]: *** [eal_vfio.o] Error 1 > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_map_device': > lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:133:7: note: each undeclared identifier is reported only once for each function it appears in > lib/librte_eal/linuxapp/eal/eal_pci.c:139:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:140:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_unmap_device': > lib/librte_eal/linuxapp/eal/eal_pci.c:160:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:163:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:164:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'pci_scan_one': > lib/librte_eal/linuxapp/eal/eal_pci.c:381:16: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_VFIO; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:383:16: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_IGB_UIO; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:385:16: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_UIO_GENERIC; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:387:16: error: 'RTE_KDRV_UNKNOWN' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_UNKNOWN; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:389:15: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > dev->kdrv = RTE_KDRV_NONE; > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_map': > lib/librte_eal/linuxapp/eal/eal_pci.c:626:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:631:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:634:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:641:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_read': > lib/librte_eal/linuxapp/eal/eal_pci.c:662:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:666:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:669:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:672:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_write': > lib/librte_eal/linuxapp/eal/eal_pci.c:688:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:692:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:695:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:698:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c: In function 'rte_eal_pci_ioport_unmap': > lib/librte_eal/linuxapp/eal/eal_pci.c:715:7: error: 'RTE_KDRV_VFIO' undeclared (first use in this function) > case RTE_KDRV_VFIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:720:7: error: 'RTE_KDRV_IGB_UIO' undeclared (first use in this function) > case RTE_KDRV_IGB_UIO: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:723:7: error: 'RTE_KDRV_UIO_GENERIC' undeclared (first use in this function) > case RTE_KDRV_UIO_GENERIC: > ^ > lib/librte_eal/linuxapp/eal/eal_pci.c:730:7: error: 'RTE_KDRV_NONE' undeclared (first use in this function) > case RTE_KDRV_NONE: > ^ > make[7]: *** [eal_pci.o] Error 1 > make[6]: *** [eal] Error 2 > make[5]: *** [linuxapp] Error 2 > make[4]: *** [librte_eal] Error 2 > make[3]: *** [lib] Error 2 > make[2]: *** [all] Error 2 > make[1]: *** [pre_install] Error 2 > make: *** [install] Error 2 > error: build failed > Thanks for highlighting. That is my mistake. While sending the patch my intention was to highlight that these are more as a RFC than direct patches. I forgot to add that and didn't notice it after posting either. Problem is that this patch moves 'enum rte_kernel_driver' to rte_dev.h from rte_pci.h. All the above errors are reported by files which still include rte_dev.h. I was hoping that if these patches look fine to all, I will update all the headers and send again. -- Shreyansh
diff --git a/lib/librte_eal/common/include/rte_dev.h b/lib/librte_eal/common/include/rte_dev.h index 95789f9..60bc91d 100644 --- a/lib/librte_eal/common/include/rte_dev.h +++ b/lib/librte_eal/common/include/rte_dev.h @@ -101,6 +101,18 @@ rte_pmd_debug_trace(const char *func_name, const char *fmt, ...) } while (0) +/** + * Kernel driver passthrough type + */ +enum rte_kernel_driver { + RTE_KDRV_UNKNOWN = 0, + RTE_KDRV_IGB_UIO, + RTE_KDRV_VFIO, + RTE_KDRV_UIO_GENERIC, + RTE_KDRV_NIC_UIO, + RTE_KDRV_NONE, +}; + /** Double linked list of device drivers. */ TAILQ_HEAD(rte_driver_list, rte_driver); diff --git a/lib/librte_eal/common/include/rte_pci.h b/lib/librte_eal/common/include/rte_pci.h index fa74962..a4c8156 100644 --- a/lib/librte_eal/common/include/rte_pci.h +++ b/lib/librte_eal/common/include/rte_pci.h @@ -141,15 +141,6 @@ struct rte_pci_addr { struct rte_devargs; -enum rte_kernel_driver { - RTE_KDRV_UNKNOWN = 0, - RTE_KDRV_IGB_UIO, - RTE_KDRV_VFIO, - RTE_KDRV_UIO_GENERIC, - RTE_KDRV_NIC_UIO, - RTE_KDRV_NONE, -}; - /** * A structure describing a PCI device. */