[dpdk-dev] fm10k: add debug info for actual Rx/Tx func
Commit Message
From: "Chen Jing D(Mark)" <jing.d.chen@intel.com>
After introducing vPMD feature, fm10k driver will select best
Rx/Tx in running time. Original implementation selects Rx/Tx
silently without notifications.
This patch adds debug info to notify user what actual Rx/Tx
func are used.
Signed-off-by: Chen Jing D(Mark) <jing.d.chen@intel.com>
---
drivers/net/fm10k/fm10k_ethdev.c | 10 +++++++++-
1 files changed, 9 insertions(+), 1 deletions(-)
Comments
2015-11-24 14:00, Chen Jing D:
> This patch adds debug info to notify user what actual Rx/Tx
> func are used.
[...]
> + if (rx_using_sse)
> + PMD_INIT_LOG(ERR, "Use vector Rx func");
> + else
> + PMD_INIT_LOG(ERR, "Use regular Rx func");
debug info != LOG(ERR
On Tue, 24 Nov 2015 11:32:46 +0100
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 2015-11-24 14:00, Chen Jing D:
> > This patch adds debug info to notify user what actual Rx/Tx
> > func are used.
> [...]
> > + if (rx_using_sse)
> > + PMD_INIT_LOG(ERR, "Use vector Rx func");
> > + else
> > + PMD_INIT_LOG(ERR, "Use regular Rx func");
>
> debug info != LOG(ERR
Really should be DEBUG.
Developers need to remember you don't wan to see those log messages
in a production system.
> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Wednesday, November 25, 2015 12:42 AM
> To: Thomas Monjalon
> Cc: Chen, Jing D; dev@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] fm10k: add debug info for actual Rx/Tx func
>
> On Tue, 24 Nov 2015 11:32:46 +0100
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
>
> > 2015-11-24 14:00, Chen Jing D:
> > > This patch adds debug info to notify user what actual Rx/Tx
> > > func are used.
> > [...]
> > > + if (rx_using_sse)
> > > + PMD_INIT_LOG(ERR, "Use vector Rx func");
> > > + else
> > > + PMD_INIT_LOG(ERR, "Use regular Rx func");
> >
> > debug info != LOG(ERR
>
> Really should be DEBUG.
> Developers need to remember you don't wan to see those log messages
> in a production system.
Thanks for the comments. I'll change accordingly.
@@ -2402,13 +2402,16 @@ fm10k_set_tx_function(struct rte_eth_dev *dev)
}
if (use_sse) {
+ PMD_INIT_LOG(ERR, "Use vector Tx func");
for (i = 0; i < dev->data->nb_tx_queues; i++) {
txq = dev->data->tx_queues[i];
fm10k_txq_vec_setup(txq);
}
dev->tx_pkt_burst = fm10k_xmit_pkts_vec;
- } else
+ } else {
dev->tx_pkt_burst = fm10k_xmit_pkts;
+ PMD_INIT_LOG(ERR, "Use regular Tx func");
+ }
}
static void __attribute__((cold))
@@ -2432,6 +2435,11 @@ fm10k_set_rx_function(struct rte_eth_dev *dev)
(dev->rx_pkt_burst == fm10k_recv_scattered_pkts_vec ||
dev->rx_pkt_burst == fm10k_recv_pkts_vec);
+ if (rx_using_sse)
+ PMD_INIT_LOG(ERR, "Use vector Rx func");
+ else
+ PMD_INIT_LOG(ERR, "Use regular Rx func");
+
for (i = 0; i < dev->data->nb_rx_queues; i++) {
struct fm10k_rx_queue *rxq = dev->data->rx_queues[i];