Message ID | 20240203041230.285599-17-stephen@networkplumber.org (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | David Marchand |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6FAC743A57; Sat, 3 Feb 2024 05:14:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D243042ED9; Sat, 3 Feb 2024 05:13:45 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id DBB5F42EB5 for <dev@dpdk.org>; Sat, 3 Feb 2024 05:13:37 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-1d934c8f8f7so25260275ad.2 for <dev@dpdk.org>; Fri, 02 Feb 2024 20:13:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1706933617; x=1707538417; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=D073T9oCR/FMcEo39lDhoqF3fnLbyykZdVZY/4anjVU=; b=gQRQ9or2sRYV2a0X+M4Xk4xoeLViJJo2jlWA9TS7xJXNxjAwzLdW6HKDAyyNZnNoeJ 7erg6oV6BeKj1YSkmAXlWd/P9pSTqbYUs8Oq8svPbZY1ScLMX4Ojk0m9ErfnuUWnQ53M rWln+CRk0vZZq04+VmWPyedwYftsrO4aOCmHt1k6qaoREMom8Ya7zRYIJMQKdeRZfXoR EZXSJabQZZTcub38ZmHPYT3/nognyI5wdxRcIcSZZt4THBIVbA6o08JsCbeonXw90gyL g211g3CMVb2UNPs40d7+B6I7JiIrbOpvQO+P4GPJa9Iwbcchj+Ueic3qjs2pKFFG1twW nLcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706933617; x=1707538417; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=D073T9oCR/FMcEo39lDhoqF3fnLbyykZdVZY/4anjVU=; b=ljIh62T8wYXyc8haBRQqIqcecCBiPy+E7tKaYn0cck3lQ0dsMgLEBMvqS02w510N2A nYWFZhTRx8Y4v9iiqL43CM1r/QkZ9Q/cz2snyyuVYMTLPBxkbkAWd8EC06XcCpbIygN8 MzNHLNxdFExSv92Z2qkiIzUGKZeYuluL6G63kUEeuqVt3HDoSuWaotQNuymG32yfCSOj Q4iWOk7fnppq74357mLg1iSBW0OT/N9QSzpWcpaEfxkLK++StN8g157ilKzAqOBCsbWt +Wqbfrqwh6XyrXzpdcSztqw7kJniCf98TiOeGo7xZ5mmx/JY1o+kGYZotBagzVM/1xSX 1pzg== X-Gm-Message-State: AOJu0YwVgBNXaQnsUjX4FhK5vgG/I19occuUBCR+E6vmC94h9AbD3Kzw g1DsMEEnhM3tpjprAFXpfGE2IvRkVrTAyYVfeX5fM0TclIn5JW37tPOiN43bEg9zjVuZV6WAqaj e/NM= X-Google-Smtp-Source: AGHT+IFVn4185uHc+ib0FcWBC1bFs5mGh4RUy9zqf0wunMY+iUcPkIVw74z0cVu6KlYISxIfHz+opg== X-Received: by 2002:a17:902:684f:b0:1d9:72a5:53e9 with SMTP id f15-20020a170902684f00b001d972a553e9mr2967006pln.64.1706933617063; Fri, 02 Feb 2024 20:13:37 -0800 (PST) X-Forwarded-Encrypted: i=0; AJvYcCW9vunjht/KCLy51u+hv89yFgzasUCdgC5LPuCBmJGZcShYYCtWk2pS3GZbFm6oPugQQpGEJW4iDfAqUdBp+3nCgckf4QAaj2vPMEL5Vjzfpchk6MvPrzSPfdA/nPVcK5LhrgIPyXS8BIh28APeY+pSHFeTK2oHXWvxkG46 Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id mf11-20020a170902fc8b00b001d94a3f398esm2361800plb.141.2024.02.02.20.13.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Feb 2024 20:13:36 -0800 (PST) From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Abdullah Sevincer <abdullah.sevincer@intel.com>, Gage Eads <gage.eads@intel.com>, Timothy McDaniel <timothy.mcdaniel@intel.com> Subject: [PATCH v7 16/19] event/dlb2: use dedicated logtype Date: Fri, 2 Feb 2024 20:11:49 -0800 Message-ID: <20240203041230.285599-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240203041230.285599-1-stephen@networkplumber.org> References: <20231213014408.612051-1-stephen@networkplumber.org> <20240203041230.285599-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
Replace uses of RTE_LOGTYPE_PMD
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
Commit Message
Stephen Hemminger
Feb. 3, 2024, 4:11 a.m. UTC
Driver was using RTE_LOGTYPE_PMD when it had its own logtype.
Fixes: 5433956d5185 ("event/dlb2: add eventdev probe")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/event/dlb2/dlb2.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
Comments
>+ DLB2_LOG_INFO("Ignoring unsupported parameters when creating device '%s'",
name);
Hi Stephen can you modify above like this:
DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'\n",
name);
It looks better this way the output will be like this after this modification:
dlb2_parse_params: Ignoring unsupported parameters when creating device 'ea:00.0'
On Mon, 5 Feb 2024 19:16:15 +0000 "Sevincer, Abdullah" <abdullah.sevincer@intel.com> wrote: > >+ DLB2_LOG_INFO("Ignoring unsupported parameters when creating device '%s'", > name); > > Hi Stephen can you modify above like this: > > DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'\n", > name); > > It looks better this way the output will be like this after this modification: > > dlb2_parse_params: Ignoring unsupported parameters when creating device 'ea:00.0' I don't understand why you would say that. The message already will get a single newline and your change would add a second one. Log messages are not supposed to be double spaced, it confuses syslog. If you want to change the overall format of log messages and how it displays the function name, that is a different change. And would be done in the macro, DLB2_LOG_IMPL. The focus of this patch set is using existing format, if you want to change that please address it in another patch later.
>+I don't understand why you would say that. >+The message already will get a single newline and your change would add a second one. >+Log messages are not supposed to be double spaced, it confuses syslog. >+If you want to change the overall format of log messages and how it displays the function name, that is a different change. And would be done in the macro, DLB2_LOG_IMPL. >+The focus of this patch set is using existing format, if you want to change that please address it in another patch later. No need for new line, I copied wrong debug message, apologies it would be like this DLB2_LOG_INFO(": Ignoring unsupported parameters when creating device '%s'", name); Note: Gage and Timothy is not with Intel now. So, not including them in the CC.
diff --git a/drivers/event/dlb2/dlb2.c b/drivers/event/dlb2/dlb2.c index 050ace0904b4..c26f2219d40c 100644 --- a/drivers/event/dlb2/dlb2.c +++ b/drivers/event/dlb2/dlb2.c @@ -4741,9 +4741,8 @@ dlb2_parse_params(const char *params, struct rte_kvargs *kvlist = rte_kvargs_parse(params, args); if (kvlist == NULL) { - RTE_LOG(INFO, PMD, - "Ignoring unsupported parameters when creating device '%s'\n", - name); + DLB2_LOG_INFO("Ignoring unsupported parameters when creating device '%s'", + name); } else { int ret = rte_kvargs_process(kvlist, NUMA_NODE_ARG, set_numa_node,