[v2] net/ice: fix tso tunnel setting to not take effect
Checks
Commit Message
The Tx offload capabilities of ICE ethdev doesn't include
tso tunnel, which will result in tso tunnel setting to
not take effect.
The patch adds tunnel tso offload to ICE_TX_NO_VECTOR_FLAGS.
This commit will add tso tunnel capabilities in ice_dev_info_get().
Bugzilla ID: 1327
Fixes: d852fec1be63 ("net/ice: fix Tx offload path choice")
Fixes: 295968d17407 ("ethdev: add namespace")
Cc: stable@dpdk.org
Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
---
drivers/net/ice/ice_ethdev.c | 6 +++++-
drivers/net/ice/ice_rxtx_vec_common.h | 4 ++++
2 files changed, 9 insertions(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Deng, KaiwenX <kaiwenx.deng@intel.com>
> Sent: Thursday, December 7, 2023 10:31 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Zhou, YidingX
> <yidingx.zhou@intel.com>; Deng, KaiwenX <kaiwenx.deng@intel.com>; Zhang,
> Qi Z <qi.z.zhang@intel.com>; Ting Xu <ting.xu@intel.com>; Kevin Liu
> <kevinx.liu@intel.com>; Ajit Khaparde <ajit.khaparde@broadcom.com>;
> Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>; Jerin Jacob
> <jerinj@marvell.com>; Hemant Agrawal <hemant.agrawal@nxp.com>;
> Somnath Kotur <somnath.kotur@broadcom.com>
> Subject: [PATCH v2] net/ice: fix tso tunnel setting to not take effect
>
> The Tx offload capabilities of ICE ethdev doesn't include tso tunnel, which will
> result in tso tunnel setting to not take effect.
>
> The patch adds tunnel tso offload to ICE_TX_NO_VECTOR_FLAGS.
>
> This commit will add tso tunnel capabilities in ice_dev_info_get().
>
> Bugzilla ID: 1327
> Fixes: d852fec1be63 ("net/ice: fix Tx offload path choice")
> Fixes: 295968d17407 ("ethdev: add namespace")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
Acked-by: Qi Zhang <qi.z.zhang@intel.com>
Applied to dpdk-next-net-intel.
Thanks
Qi
> > The Tx offload capabilities of ICE ethdev doesn't include tso tunnel, which will
> > result in tso tunnel setting to not take effect.
> >
> > The patch adds tunnel tso offload to ICE_TX_NO_VECTOR_FLAGS.
> >
> > This commit will add tso tunnel capabilities in ice_dev_info_get().
> >
> > Bugzilla ID: 1327
> > Fixes: d852fec1be63 ("net/ice: fix Tx offload path choice")
> > Fixes: 295968d17407 ("ethdev: add namespace")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
As said by David in v1, 295968d17407 ("ethdev: add namespace") is not a cause.
Removing while pulling.
@@ -3876,7 +3876,11 @@ ice_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
RTE_ETH_TX_OFFLOAD_TCP_CKSUM |
RTE_ETH_TX_OFFLOAD_SCTP_CKSUM |
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM |
- RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM;
+ RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO;
dev_info->flow_type_rss_offloads |= ICE_RSS_OFFLOAD_ALL;
}
@@ -251,6 +251,10 @@ ice_rxq_vec_setup_default(struct ice_rx_queue *rxq)
RTE_ETH_TX_OFFLOAD_MULTI_SEGS | \
RTE_ETH_TX_OFFLOAD_OUTER_IPV4_CKSUM | \
RTE_ETH_TX_OFFLOAD_TCP_TSO | \
+ RTE_ETH_TX_OFFLOAD_VXLAN_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GRE_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO | \
+ RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO | \
RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM)
#define ICE_TX_VECTOR_OFFLOAD ( \