[dpdk-dev,v3,3/3] doc: update release notes and testpmd guide

Message ID 1446099519-7903-4-git-send-email-helin.zhang@intel.com (mailing list archive)
State Superseded, archived
Headers

Commit Message

Zhang, Helin Oct. 29, 2015, 6:18 a.m. UTC
  Update release notes with the newly added feature of selecting
different GRE key length for input set, and testpmd guide with
newly added commands for that.

Signed-off-by: Helin Zhang <helin.zhang@intel.com>
---
 doc/guides/rel_notes/release_2_2.rst        |  2 ++
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 11 +++++++++++
 2 files changed, 13 insertions(+)
  

Comments

Thomas Monjalon Oct. 29, 2015, 7:48 a.m. UTC | #1
Hi Helin,

Please avoid making a commit for doc only.
These changes are related to some code changes and must be atomic.
For next time, please update the release notes in the patch adding the
feature (i40e here) and the testpmd doc in the testpmd patch.

Thanks for explaining the logic to others

2015-10-29 14:18, Helin Zhang:
> Update release notes with the newly added feature of selecting
> different GRE key length for input set, and testpmd guide with
> newly added commands for that.
> 
> Signed-off-by: Helin Zhang <helin.zhang@intel.com>
  
Zhang, Helin Oct. 29, 2015, 8:43 a.m. UTC | #2
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]
> Sent: Thursday, October 29, 2015 3:48 PM
> To: Zhang, Helin
> Cc: dev@dpdk.org; Pei, Yulong
> Subject: Re: [dpdk-dev] [PATCH v3 3/3] doc: update release notes and testpmd
> guide
> 
> Hi Helin,
> 
> Please avoid making a commit for doc only.
> These changes are related to some code changes and must be atomic.
> For next time, please update the release notes in the patch adding the feature
> (i40e here) and the testpmd doc in the testpmd patch.
Good to learn that! Thank you for the guidance!

Helin

> 
> Thanks for explaining the logic to others
> 
> 2015-10-29 14:18, Helin Zhang:
> > Update release notes with the newly added feature of selecting
> > different GRE key length for input set, and testpmd guide with newly
> > added commands for that.
> >
> > Signed-off-by: Helin Zhang <helin.zhang@intel.com>
  

Patch

diff --git a/doc/guides/rel_notes/release_2_2.rst b/doc/guides/rel_notes/release_2_2.rst
index 8fc8917..7b4b97e 100644
--- a/doc/guides/rel_notes/release_2_2.rst
+++ b/doc/guides/rel_notes/release_2_2.rst
@@ -25,6 +25,8 @@  New Features
 
 * **Added RSS/FD input set granularity on Intel X710/XL710.**
 
+* **Added selecting different GRE key length for input set on Intel X710/XL710.**
+
 
 Resolved Issues
 ---------------
diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index f5951c0..5ed7c66 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -1810,3 +1810,14 @@  Set the input set for Fdir::
 For example to add source IP to FD input set for flow type of ipv4 on port 0::
 
    testpmd> set_fdir_input_set 0 ipv4 src-ipv4 add
+
+global_config
+~~~~~~~~~~~~~
+
+Set different GRE key length for input set::
+
+   global_config (port_id) gre-key-len (number in bytes)
+
+For example to set GRE key length for input set to 4 bytes on port 0::
+
+   testpmd> global_config 0 gre-key-len 4