Message ID | 20230530090510.56812-1-haijie1@huawei.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1247E42BE1; Tue, 30 May 2023 11:07:31 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9481840F18; Tue, 30 May 2023 11:07:30 +0200 (CEST) Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by mails.dpdk.org (Postfix) with ESMTP id 5B691406BC for <dev@dpdk.org>; Tue, 30 May 2023 11:07:29 +0200 (CEST) Received: from kwepemi500020.china.huawei.com (unknown [172.30.72.57]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVmkG6f8GzSqTr for <dev@dpdk.org>; Tue, 30 May 2023 17:07:18 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Tue, 30 May 2023 17:07:27 +0800 From: Jie Hai <haijie1@huawei.com> To: CC: <dev@dpdk.org>, <liudongdong3@huawei.com> Subject: [PATCH 00/10] support telemetry query ethdev info Date: Tue, 30 May 2023 17:05:00 +0800 Message-ID: <20230530090510.56812-1-haijie1@huawei.com> X-Mailer: git-send-email 2.33.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemi500020.china.huawei.com (7.221.188.8) X-CFilter-Loop: Reflected X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
support telemetry query ethdev info
|
|
Message
Jie Hai
May 30, 2023, 9:05 a.m. UTC
This patchset supports querying information about ethdev. The information includes MAC addresses, RxTx offload, flow ctrl, Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. Dengdui Huang (1): ethdev: support telemetry query MAC addresses Jie Hai (9): ethdev: support RxTx offload display ethdev: support telemetry query flow ctrl info ethdev: support telemetry query Rx queue info ethdev: support telemetry query Tx queue info ethdev: add firmware version in telemetry info command ethdev: support telemetry query DCB info ethdev: support telemetry query RSS info ethdev: support telemetry query FEC info ethdev: support telemetry query VLAN info lib/ethdev/rte_ethdev.c | 775 +++++++++++++++++++++++++++++++++++++++- 1 file changed, 765 insertions(+), 10 deletions(-)
Comments
On 5/30/2023 10:05 AM, Jie Hai wrote: > Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. > > > This patchset supports querying information about ethdev. > The information includes MAC addresses, RxTx offload, flow ctrl, > Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. > > > Dengdui Huang (1): > ethdev: support telemetry query MAC addresses > > Jie Hai (9): > ethdev: support RxTx offload display > ethdev: support telemetry query flow ctrl info > ethdev: support telemetry query Rx queue info > ethdev: support telemetry query Tx queue info > ethdev: add firmware version in telemetry info command > ethdev: support telemetry query DCB info > ethdev: support telemetry query RSS info > ethdev: support telemetry query FEC info > ethdev: support telemetry query VLAN info > Hi Jie, There are build errors, reported by CI, and %l usage related checkpatch warnings, can you please fix them in next version?
On 2023/6/1 20:05, Ferruh Yigit wrote: > On 5/30/2023 10:05 AM, Jie Hai wrote: >> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. >> >> >> This patchset supports querying information about ethdev. >> The information includes MAC addresses, RxTx offload, flow ctrl, >> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. >> >> >> Dengdui Huang (1): >> ethdev: support telemetry query MAC addresses >> >> Jie Hai (9): >> ethdev: support RxTx offload display >> ethdev: support telemetry query flow ctrl info >> ethdev: support telemetry query Rx queue info >> ethdev: support telemetry query Tx queue info >> ethdev: add firmware version in telemetry info command >> ethdev: support telemetry query DCB info >> ethdev: support telemetry query RSS info >> ethdev: support telemetry query FEC info >> ethdev: support telemetry query VLAN info >> > Hi Jie, > > There are build errors, reported by CI, and %l usage related checkpatch > warnings, can you please fix them in next version? > > Hi Ferruh, Thanks for your reply, I will fix them in V2. Jie Hai.
On 5/30/2023 10:05 AM, Jie Hai wrote: > This patchset supports querying information about ethdev. > The information includes MAC addresses, RxTx offload, flow ctrl, > Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. > > > Dengdui Huang (1): > ethdev: support telemetry query MAC addresses > > Jie Hai (9): > ethdev: support RxTx offload display > ethdev: support telemetry query flow ctrl info > ethdev: support telemetry query Rx queue info > ethdev: support telemetry query Tx queue info > ethdev: add firmware version in telemetry info command > ethdev: support telemetry query DCB info > ethdev: support telemetry query RSS info > ethdev: support telemetry query FEC info > ethdev: support telemetry query VLAN info > Hi Jie, Overall it is good to add more telemetry support, but it is making 'rte_ethdev.c' bigger, specially naming of the static functions that telemetry handlers use making file confusing. Can you please create a specific file for telemetry functions? First you can move the existing ones and later add your patches. Also there is a common part that reads and verifies port_id, I think that part can be extracted to a common function, I will comment on it in one of the patches. Thanks, ferruh
On 2023/6/1 22:36, Ferruh Yigit wrote: > On 5/30/2023 10:05 AM, Jie Hai wrote: >> This patchset supports querying information about ethdev. >> The information includes MAC addresses, RxTx offload, flow ctrl, >> Rx|Tx queue, firmware version, DCB, RSS, FEC, VLAN, etc. >> >> >> Dengdui Huang (1): >> ethdev: support telemetry query MAC addresses >> >> Jie Hai (9): >> ethdev: support RxTx offload display >> ethdev: support telemetry query flow ctrl info >> ethdev: support telemetry query Rx queue info >> ethdev: support telemetry query Tx queue info >> ethdev: add firmware version in telemetry info command >> ethdev: support telemetry query DCB info >> ethdev: support telemetry query RSS info >> ethdev: support telemetry query FEC info >> ethdev: support telemetry query VLAN info >> > > Hi Jie, > > Overall it is good to add more telemetry support, but it is making > 'rte_ethdev.c' bigger, specially naming of the static functions that > telemetry handlers use making file confusing. > Can you please create a specific file for telemetry functions? > > First you can move the existing ones and later add your patches. > > Also there is a common part that reads and verifies port_id, I think > that part can be extracted to a common function, I will comment on it in > one of the patches. > > Thanks, > ferruh > . Hi ferruh, Thanks for your review, I will fix them in the next version. Thanks, Jie Hai