test/crypto: fix errors for test stats testcase
Checks
Commit Message
The test stats testcase was printing the same error message for
multiple errors in the test stats testcase. This is now replaced
with descriptive error messages, which match the cause of the failure.
Fixes: 202d375 ("app/test: add cryptodev unit and performance tests")
Cc: stable@dpdk.org
Cc: declan.doherty@intel.com
Signed-off-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
---
.mailmap | 1 +
app/test/test_cryptodev.c | 12 ++++++------
2 files changed, 7 insertions(+), 6 deletions(-)
Comments
Hi Saoirse,
> -----Original Message-----
> From: Saoirse O'Donovan <saoirse.odonovan@intel.com>
> Sent: Monday 20 March 2023 09:30
> To: Thomas Monjalon <thomas@monjalon.net>; Akhil Goyal
> <gakhil@marvell.com>; Fan Zhang <fanzhang.oss@gmail.com>
> Cc: dev@dpdk.org; O'Donovan, Saoirse <saoirse.odonovan@intel.com>;
> stable@dpdk.org; Doherty, Declan <declan.doherty@intel.com>
> Subject: [PATCH] test/crypto: fix errors for test stats testcase
>
> The test stats testcase was printing the same error message for multiple errors
> in the test stats testcase. This is now replaced with descriptive error messages,
> which match the cause of the failure.
>
> Fixes: 202d375 ("app/test: add cryptodev unit and performance tests")
> Cc: stable@dpdk.org
> Cc: declan.doherty@intel.com
>
> Signed-off-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
> ---
> .mailmap | 1 +
> app/test/test_cryptodev.c | 12 ++++++------
> 2 files changed, 7 insertions(+), 6 deletions(-)
Acked-by: Ciara Power <ciara.power@intel.com>
> Hi Saoirse,
>
> > Subject: [PATCH] test/crypto: fix errors for test stats testcase
> >
> > The test stats testcase was printing the same error message for multiple errors
> > in the test stats testcase. This is now replaced with descriptive error messages,
> > which match the cause of the failure.
> >
> > Fixes: 202d375 ("app/test: add cryptodev unit and performance tests")
> > Cc: stable@dpdk.org
> > Cc: declan.doherty@intel.com
> >
> > Signed-off-by: Saoirse O'Donovan <saoirse.odonovan@intel.com>
> > ---
> > .mailmap | 1 +
> > app/test/test_cryptodev.c | 12 ++++++------
> > 2 files changed, 7 insertions(+), 6 deletions(-)
>
> Acked-by: Ciara Power <ciara.power@intel.com>
Applied to dpdk-next-crypto
Changed title to "test/crypto: fix stats case error messages"
@@ -1175,6 +1175,7 @@ Sangjin Han <sangjin@eecs.berkeley.edu>
Sankar Chokkalingam <sankarx.chokkalingam@intel.com>
Santoshkumar Karanappa Rastapur <santosh.rastapur@broadcom.com>
Santosh Shukla <santosh.shukla@caviumnetworks.com> <sshukla@mvista.com>
+Saoirse O'Donovan <saoirse.odonovan@intel.com>
Saori Usami <susami@igel.co.jp>
Sarath Somasekharan <sarathx.somasekharan@intel.com>
Sarosh Arif <sarosh.arif@emumba.com>
@@ -12335,11 +12335,11 @@ test_stats(void)
TEST_ASSERT((stats.enqueued_count == 1),
"rte_cryptodev_stats_get returned unexpected enqueued stat");
TEST_ASSERT((stats.dequeued_count == 1),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected dequeued stat");
TEST_ASSERT((stats.enqueue_err_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected enqueued error count stat");
TEST_ASSERT((stats.dequeue_err_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected dequeued error count stat");
/* invalid device but should ignore and not reset device stats*/
rte_cryptodev_stats_reset(ts_params->valid_devs[0] + 300);
@@ -12347,7 +12347,7 @@ test_stats(void)
&stats),
"rte_cryptodev_stats_get failed");
TEST_ASSERT((stats.enqueued_count == 1),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected enqueued stat after invalid reset");
/* check that a valid reset clears stats */
rte_cryptodev_stats_reset(ts_params->valid_devs[0]);
@@ -12355,9 +12355,9 @@ test_stats(void)
&stats),
"rte_cryptodev_stats_get failed");
TEST_ASSERT((stats.enqueued_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected enqueued stat after valid reset");
TEST_ASSERT((stats.dequeued_count == 0),
- "rte_cryptodev_stats_get returned unexpected enqueued stat");
+ "rte_cryptodev_stats_get returned unexpected dequeued stat after valid reset");
return TEST_SUCCESS;
}