[v5,02/39] ml/cnxk: add skeleton for ML cnxk driver
Checks
Commit Message
Added initial source files and build files for ML cnxk driver.
Signed-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>
---
MAINTAINERS | 1 +
doc/guides/rel_notes/release_23_03.rst | 7 +++++++
drivers/meson.build | 1 +
drivers/ml/cnxk/cn10k_ml_dev.c | 8 ++++++++
drivers/ml/cnxk/cn10k_ml_dev.h | 8 ++++++++
drivers/ml/cnxk/meson.build | 26 ++++++++++++++++++++++++++
drivers/ml/meson.build | 8 ++++++++
7 files changed, 59 insertions(+)
create mode 100644 drivers/ml/cnxk/cn10k_ml_dev.c
create mode 100644 drivers/ml/cnxk/cn10k_ml_dev.h
create mode 100644 drivers/ml/cnxk/meson.build
create mode 100644 drivers/ml/meson.build
Comments
07/02/2023 17:06, Srikanth Yalavarthi:
> --- a/doc/guides/rel_notes/release_23_03.rst
> +++ b/doc/guides/rel_notes/release_23_03.rst
> +* **Implementation of Marvell CNXK machine learning driver for .**
It seems a word is missing.
It looks like you did a lot of work on the mldev series,
so some details are missing.
> +
> + * Added ml/cnxk driver which provides support for machine learning inference
> + operations on Marvell's CN10K series of SoC's.
> + * Added ML ROC code for ml/cnxk driver to common/cnxk.
> + * Added implementation with support for all rte_ml APIs.
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: 10 March 2023 03:36
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Anup Prabhu <aprabhu@marvell.com>; Prince Takkar
> <ptakkar@marvell.com>; Parijat Shukla <pshukla@marvell.com>; Srikanth
> Yalavarthi <syalavarthi@marvell.com>
> Subject: [EXT] Re: [PATCH v5 02/39] ml/cnxk: add skeleton for ML cnxk driver
>
> External Email
>
> ----------------------------------------------------------------------
> 07/02/2023 17:06, Srikanth Yalavarthi:
> > --- a/doc/guides/rel_notes/release_23_03.rst
> > +++ b/doc/guides/rel_notes/release_23_03.rst
> > +* **Implementation of Marvell CNXK machine learning driver for .**
>
> It seems a word is missing.
> It looks like you did a lot of work on the mldev series, so some details are
> missing.
>
Done. Updated the release notes correctly in version 6 patch series.
> > +
> > + * Added ml/cnxk driver which provides support for machine learning
> inference
> > + operations on Marvell's CN10K series of SoC's.
> > + * Added ML ROC code for ml/cnxk driver to common/cnxk.
> > + * Added implementation with support for all rte_ml APIs.
>
>
>
10/03/2023 09:25, Srikanth Yalavarthi:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 07/02/2023 17:06, Srikanth Yalavarthi:
> > > --- a/doc/guides/rel_notes/release_23_03.rst
> > > +++ b/doc/guides/rel_notes/release_23_03.rst
> > > +* **Implementation of Marvell CNXK machine learning driver for .**
> >
> > It seems a word is missing.
> > It looks like you did a lot of work on the mldev series, so some details are
> > missing.
>
> Done. Updated the release notes correctly in version 6 patch series.
I am close to merge v5 already.
I don't want to restart all the testing process.
Did you do other changes in v6?
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: 10 March 2023 14:59
> To: Srikanth Yalavarthi <syalavarthi@marvell.com>
> Cc: dev@dpdk.org; Shivah Shankar Shankar Narayan Rao
> <sshankarnara@marvell.com>; Jerin Jacob Kollanukkaran
> <jerinj@marvell.com>; Anup Prabhu <aprabhu@marvell.com>; Prince Takkar
> <ptakkar@marvell.com>; Parijat Shukla <pshukla@marvell.com>
> Subject: Re: [EXT] Re: [PATCH v5 02/39] ml/cnxk: add skeleton for ML cnxk
> driver
>
> 10/03/2023 09:25, Srikanth Yalavarthi:
> > From: Thomas Monjalon <thomas@monjalon.net>
> > > 07/02/2023 17:06, Srikanth Yalavarthi:
> > > > --- a/doc/guides/rel_notes/release_23_03.rst
> > > > +++ b/doc/guides/rel_notes/release_23_03.rst
> > > > +* **Implementation of Marvell CNXK machine learning driver for
> > > > +.**
> > >
> > > It seems a word is missing.
> > > It looks like you did a lot of work on the mldev series, so some
> > > details are missing.
> >
> > Done. Updated the release notes correctly in version 6 patch series.
>
> I am close to merge v5 already.
> I don't want to restart all the testing process.
> Did you do other changes in v6?
No additional changes other than release notes fix
>
@@ -1441,6 +1441,7 @@ Marvell ML CNXK
M: Srikanth Yalavarthi <syalavarthi@marvell.com>
F: drivers/common/cnxk/hw/ml.h
F: drivers/common/cnxk/roc_ml*
+F: drivers/ml/cnxk/
Packet processing
@@ -100,6 +100,13 @@ New Features
* Added functions to translate IO type and format to string.
* Added functions to quantize and dequantize inference IO data.
+* **Implementation of Marvell CNXK machine learning driver for .**
+
+ * Added ml/cnxk driver which provides support for machine learning inference
+ operations on Marvell's CN10K series of SoC's.
+ * Added ML ROC code for ml/cnxk driver to common/cnxk.
+ * Added implementation with support for all rte_ml APIs.
+
Removed Items
-------------
@@ -14,6 +14,7 @@ subdirs = [
'mempool', # depends on common and bus.
'dma', # depends on common and bus.
'net', # depends on common, bus, mempool
+ 'ml', # depends on common, bus, mempool
'raw', # depends on common, bus, dma and net.
'crypto', # depends on common, bus and mempool (net in future).
'compress', # depends on common, bus, mempool.
new file mode 100644
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022 Marvell.
+ */
+
+#include <rte_mldev.h>
+#include <rte_mldev_pmd.h>
+
+#include "cn10k_ml_dev.h"
new file mode 100644
@@ -0,0 +1,8 @@
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright (c) 2022 Marvell.
+ */
+
+#ifndef _CN10K_ML_DEV_H_
+#define _CN10K_ML_DEV_H_
+
+#endif /* _CN10K_ML_DEV_H_ */
new file mode 100644
@@ -0,0 +1,26 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2022 Marvell.
+
+if not is_linux or not dpdk_conf.get('RTE_ARCH_64')
+ build = false
+ reason = 'only supported on 64-bit Linux'
+ subdir_done()
+endif
+
+driver_sdk_headers = files(
+ 'cn10k_ml_dev.h',
+)
+
+sources = files(
+ 'cn10k_ml_dev.c',
+)
+
+deps += ['mldev', 'common_cnxk']
+
+if get_option('buildtype').contains('debug')
+ cflags += [ '-DCNXK_ML_DEV_DEBUG' ]
+else
+ cflags += [ '-UCNXK_ML_DEV_DEBUG' ]
+endif
+
+pmd_supports_disable_iova_as_pa = true
new file mode 100644
@@ -0,0 +1,8 @@
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright (c) 2022 Marvell.
+
+drivers = [
+ 'cnxk',
+]
+
+std_deps = ['mldev']