ethdev: remove telemetry Rx mbuf alloc failed field
Checks
Commit Message
'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
which is exposed via ehtdev stat APIs.
But telemetry exposes this field to user via "/ethdev/info",
instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
Cc: stable@dpdk.org
Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
Cc: gmuthukrishn@marvell.com
Cc: Bruce Richardson <bruce.richardson@intel.com>
Cc: Qi Zhang <qi.z.zhang@intel.com>
---
lib/ethdev/rte_ethdev.c | 2 --
1 file changed, 2 deletions(-)
Comments
28/02/2023 19:02, Ferruh Yigit:
> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
> which is exposed via ehtdev stat APIs.
>
> But telemetry exposes this field to user via "/ethdev/info",
> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>
> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>
> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
> ---
> - rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
> - eth_dev->data->rx_mbuf_alloc_failed);
Good catch, thanks.
Acked-by: Thomas Monjalon <thomas@monjalon.net>
On 3/1/23 14:37, Thomas Monjalon wrote:
> 28/02/2023 19:02, Ferruh Yigit:
>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
>> which is exposed via ehtdev stat APIs.
>>
>> But telemetry exposes this field to user via "/ethdev/info",
>> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>>
>> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>>
>> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>> ---
>> - rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
>> - eth_dev->data->rx_mbuf_alloc_failed);
>
> Good catch, thanks.
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
On 3/1/2023 2:08 PM, Andrew Rybchenko wrote:
> On 3/1/23 14:37, Thomas Monjalon wrote:
>> 28/02/2023 19:02, Ferruh Yigit:
>>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to
>>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf'
>>> which is exposed via ehtdev stat APIs.
>>>
>>> But telemetry exposes this field to user via "/ethdev/info",
>>> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats".
>>>
>>> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs
>>>
>>> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info")
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
>>> ---
>>> - rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
>>> - eth_dev->data->rx_mbuf_alloc_failed);
>>
>> Good catch, thanks.
>>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
>
Applied to dpdk-next-net/main, thanks.
@@ -6636,8 +6636,6 @@ eth_dev_handle_port_info(const char *cmd __rte_unused,
rte_tel_data_add_dict_int(d, "mtu", eth_dev->data->mtu);
rte_tel_data_add_dict_uint(d, "rx_mbuf_size_min",
eth_dev->data->min_rx_buf_size);
- rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail",
- eth_dev->data->rx_mbuf_alloc_failed);
rte_ether_format_addr(mac_addr, sizeof(mac_addr),
eth_dev->data->mac_addrs);
rte_tel_data_add_dict_string(d, "mac_addr", mac_addr);