[v2] crypto/openssl: fix warning on copy length
Checks
Commit Message
When building with gcc 11.2.0, the compiler warns as follows:
In function 'memcpy',
inlined from 'openssl_set_session_auth_parameters' at ../drivers/crypto/openssl/rte_openssl_pmd.c:699:3,
inlined from 'openssl_set_session_parameters' at ../drivers/crypto/openssl/rte_openssl_pmd.c:826:9:
/usr/include/aarch64-linux-gnu/bits/string_fortified.h:29:10: warning: '__builtin_memcpy' forming offset [4, 8] is out of the bounds [0, 4] [-Warray-bounds]
Fixed the warning by copying up to string / buffer size.
Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API")
Cc: stable@dpdk.org
Cc: kai.ji@intel.com
Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
---
drivers/crypto/openssl/rte_openssl_pmd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> When building with gcc 11.2.0, the compiler warns as follows:
> In function 'memcpy',
> inlined from 'openssl_set_session_auth_parameters' at
> ../drivers/crypto/openssl/rte_openssl_pmd.c:699:3,
> inlined from 'openssl_set_session_parameters' at
> ../drivers/crypto/openssl/rte_openssl_pmd.c:826:9:
> /usr/include/aarch64-linux-gnu/bits/string_fortified.h:29:10: warning:
> '__builtin_memcpy' forming offset [4, 8] is out of the bounds [0, 4] [-Warray-
> bounds]
>
> Fixed the warning by copying up to string / buffer size.
>
> Fixes: 75adf1eae44f ("crypto/openssl: update HMAC routine with 3.0 EVP API")
> Cc: stable@dpdk.org
> Cc: kai.ji@intel.com
>
> Signed-off-by: Ruifeng Wang <ruifeng.wang@arm.com>
> Reviewed-by: Feifei Wang <feifei.wang2@arm.com>
Applied to dpdk-next-crypto
Thanks.
@@ -696,7 +696,7 @@ openssl_set_session_auth_parameters(struct openssl_session *sess,
algo = digest_name_get(xform->auth.algo);
if (!algo)
return -EINVAL;
- rte_memcpy(algo_name, algo, (sizeof(algo)+1));
+ strlcpy(algo_name, algo, sizeof(algo_name));
mac = EVP_MAC_fetch(NULL, "HMAC", NULL);
sess->auth.hmac.ctx = EVP_MAC_CTX_new(mac);