[v3] mempool/cnxk: fix mempool destroy for empty pools
Checks
Commit Message
In scenarios where rte_mempool_free() is called immediately
after rte_mempool_create_empty(), the NPA pool will not be
created. In such cases the free path should not call
roc_npa_pool_destroy().
Fixes: bbf19e89b87c ("mempool/cnxk: add generic operations")
Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
---
drivers/mempool/cnxk/cnxk_mempool_ops.c | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
08/11/2022 07:55, Ashwin Sekhar T K:
> In scenarios where rte_mempool_free() is called immediately
> after rte_mempool_create_empty(), the NPA pool will not be
> created. In such cases the free path should not call
> roc_npa_pool_destroy().
>
> Fixes: bbf19e89b87c ("mempool/cnxk: add generic operations")
>
> Signed-off-by: Ashwin Sekhar T K <asekhar@marvell.com>
+ Cc: stable@dpdk.org
Applied with the title "fix destroying empty pool".
@@ -126,6 +126,14 @@ cnxk_mempool_free(struct rte_mempool *mp)
int rc = 0;
plt_npa_dbg("aura_handle=0x%" PRIx64, mp->pool_id);
+
+ /* It can happen that rte_mempool_free() is called immediately after
+ * rte_mempool_create_empty(). In such cases the NPA pool will not be
+ * allocated.
+ */
+ if (roc_npa_aura_handle_to_base(mp->pool_id) == 0)
+ return;
+
rc = roc_npa_pool_destroy(mp->pool_id);
if (rc)
plt_err("Failed to free pool or aura rc=%d", rc);