Message ID | 20221103152204.2706555-1-ferruh.yigit@amd.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Jerin Jacob |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 63DBEA00C2; Thu, 3 Nov 2022 16:22:23 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4780D42D03; Thu, 3 Nov 2022 16:22:23 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2040.outbound.protection.outlook.com [40.107.236.40]) by mails.dpdk.org (Postfix) with ESMTP id 9A07042D02; Thu, 3 Nov 2022 16:22:21 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ls6SUhz7WnZ9xZkqSbkzpjjWyC5qJr7PzKZ0fvsL3apwipOaE69b0RI6wamrKuEsQiPz/qYMYIEFJov1w8v2GTZTaKxrE4xJErq9L2YTL9WSEFW06lmQV2wpz+TbSg7rTUvMYbwS0S20ay2Cp9cyXf3N5uzjNzB5p8dzr6/xRUfK3rDBs45cLpwpObES9+oT36R+UAQ4HomX3zNUXS6oWKwTEFA3zGaTiiPBlh4Mlvt9TPLfpVjOb8mRoRCrl99VJ9iY7QhYOEH4J2SrUzDtz90oLDnACk3WKjqipN5pLXbmvgiIMF7b9HU28taM/IJgtgDqeAhzzgtMkq5KZhva2w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=hsaNlgidqFHLTC2g9BqaHf51iUyZf8TRuPVb/szfqLc=; b=R25y1znZfVznJXj+YhKk5z6a34HvVR8oEK++BJGk/WufMvKhaLs953l3XHEdoLR4jsqPLd63lhDVLkoHC/e2Mdn4nVJE9AQqa8xnqzhpbpdyrKEhIsM4hZH7JtDZ9xoy38hTkVn/BRbBERmPTG2CzLFpqOIcdIaY/W15goB5iQ+jadOM/Q5/yqJ7dF41nzL87vbFosi7ksz3j/0qsPsLNQzpRHAvP6Ms504xVlqHkAweu7JULfIBnVzHSsNuzwrI65OgXDvL884XqabJ8x5hj09alC8UzqhcX+Umlt3NCDpc5IjXa48O69EXaHvqc+3hloHB/3pHkgin1FdQmOtOZQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=hsaNlgidqFHLTC2g9BqaHf51iUyZf8TRuPVb/szfqLc=; b=KMGXBamF2EPSlbN4F8ksuRUow/UbA6Lu5FqhOGLedlpS3I+IjaUhw6MiNe35rPV3SmRjJ0FjhhXzNWKeEiXbUlkID3snL0kBC68yHfhzB60smn0HttCUqqqsrLGrXIfzG9Hl5o810omWMFgCcz3mYus9cMhlV5yQFtIEOu7VHgk= Received: from BN9PR03CA0365.namprd03.prod.outlook.com (2603:10b6:408:f7::10) by DM6PR12MB4563.namprd12.prod.outlook.com (2603:10b6:5:28e::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.22; Thu, 3 Nov 2022 15:22:19 +0000 Received: from BN8NAM11FT054.eop-nam11.prod.protection.outlook.com (2603:10b6:408:f7:cafe::d1) by BN9PR03CA0365.outlook.office365.com (2603:10b6:408:f7::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.21 via Frontend Transport; Thu, 3 Nov 2022 15:22:19 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BN8NAM11FT054.mail.protection.outlook.com (10.13.177.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5791.20 via Frontend Transport; Thu, 3 Nov 2022 15:22:19 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Thu, 3 Nov 2022 10:22:18 -0500 From: Ferruh Yigit <ferruh.yigit@amd.com> To: Timothy McDaniel <timothy.mcdaniel@intel.com>, Kent Wires <kent.wires@intel.com> CC: <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, David Marchand <david.marchand@redhat.com>, <stable@dpdk.org>, Luca Boccassi <bluca@debian.org> Subject: [PATCH] event/dlb2: fix meson build Date: Thu, 3 Nov 2022 15:22:03 +0000 Message-ID: <20221103152204.2706555-1-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN8NAM11FT054:EE_|DM6PR12MB4563:EE_ X-MS-Office365-Filtering-Correlation-Id: ae0ba978-1af3-4e5c-ada6-08dabdaf329d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IDKURFBz9H/g6upHUeeNsUj7DmI7ky2CtYtA90QExferZIb942chUymGAM7w9wUPGFTe9ww/e1NFBBOLW7m7YKrgH4FXoZKXtqlCP91OtR4xiVyiJQw+fHCBF2TznOeFs1bF3RY8UjscrwbYz01FPGZ4IVy2Dx7QJN3o6Jbza/ysfp1UJQr15bBvahNgZjyPCHmqQgU/EOCfdXiItgaYuy0qJueDArZnjrZw4k5qQ+/iUdiW4X9WjW7Z/lRXLe1j3y8QIlZrDEtOrg6xNcHrjJ7AVIkVAouXEZsHe5JXURpz+E69L6QTYTqhgsbHAO6O6kycJa1nX4fvARddzaAZLXYqkRCodQEsTgU8c8q/tG+qdsTFInqfswmaCjIE6rduHbtEwnJQpvmYB258Wc9Hae2eVL96sffYoaB5Cbrmei8hPVCH/yolzjYn6oP5repCuYXa+OPazC3/a7SiqDA1PJDscMW4GqtWuK3JSjxL+7Wuh3tY2svhQIHWP4tYXhTnL61jd5i4L2kDpSkBHDMAkAlXOYc/1xFZXetFBmMsW5VGuWpuJDKWyP1Pi2QLCE4J7dpDAgtl/d/c6+A0mpfB2Nct2UGTWu8HXUhao5SjIVHKdcP08MvpbPzIGzYvc7RjPTUoxwY6wEVHRTyV6/GUqjYn+9wB+UvYbeJkyKOZXAFXtc6xC/LtUsPrz7RBX9B9X4g2/19Rp9j2bBNGk5ncTPdiNArUiDuR49/ckwJZqGp8hJ0yCbY7VG1n/DSmJC2HKfMM2IlQM7RPoQXSu2kMtIBnrFGD2Z7NLehAsqsBaFeMiHPTNQ2yq5tG7XefEs98 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230022)(4636009)(346002)(376002)(39860400002)(396003)(136003)(451199015)(46966006)(36840700001)(40470700004)(426003)(47076005)(83380400001)(81166007)(356005)(86362001)(36860700001)(6666004)(82740400003)(2906002)(44832011)(5660300002)(4326008)(8936002)(8676002)(70206006)(41300700001)(70586007)(82310400005)(7696005)(16526019)(2616005)(336012)(478600001)(186003)(1076003)(40460700003)(26005)(316002)(54906003)(110136005)(40480700001)(36756003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Nov 2022 15:22:19.1998 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ae0ba978-1af3-4e5c-ada6-08dabdaf329d X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT054.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4563 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
event/dlb2: fix meson build
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
ci/intel-Testing | success | Testing PASS |
ci/github-robot: build | success | github build: passed |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/iol-aarch64-compile-testing | success | Testing PASS |
ci/iol-x86_64-unit-testing | success | Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/iol-x86_64-compile-testing | success | Testing PASS |
ci/iol-intel-Functional | success | Functional Testing PASS |
ci/iol-aarch64-unit-testing | success | Testing PASS |
Commit Message
Ferruh Yigit
Nov. 3, 2022, 3:22 p.m. UTC
"meson setup" fails when '-Werror' compiler flag is enabled [1].
This is not a build error in the driver but a build error in meson
during "meson setup" stage.
This issue exists for a while but meson takes it as a warning and
ignores it unless '-Werror' compiler flag is provided.
Although it doesn't cause build error without '-Werror', relevant code
should be broken functionally, this patch fixes that too.
Build file using a variable to detect if macro defined, but that
variable is not set, looks like copy/paste error.
Replacing variable with hardcoded macro name.
[1]
Reproduced via `meson -Dc_args='-Werror' build`
in file 'build/meson-logs/meson-log.txt'
``
Running compile:
Working directory: /tmp/tmpfrnw2x8z
Command line: ccache cc /tmp/tmpfrnw2x8z/testfile.c -pipe -E -P
-Werror -D_FILE_OFFSET_BITS=64 -P -O0 -march=native
Code:
#ifndef dev/qat_crypto_pmd_gen4.c
# define dev/qat_crypto_pmd_gen4.c
#endif
"MESON_GET_DEFINE_DELIMITER"
dev/qat_crypto_pmd_gen4.c
Compiler stdout:
"MESON_GET_DEFINE_DELIMITER"
/qat_crypto_pmd_gen4.c/qat_crypto_pmd_gen4.c
Compiler stderr:
/tmp/tmpfrnw2x8z/testfile.c:3:20:
error: extra tokens at end of #ifndef directive [-Werror]
3 | #ifndef dev/qat_crypto_pmd_gen4.c
| ^
/tmp/tmpfrnw2x8z/testfile.c:4:18:
error: ISO C99 requires whitespace after the macro name [-Werror]
4 | # define dev/qat_crypto_pmd_gen4.c
| ^~~
cc1: all warnings being treated as errors
drivers/event/dlb2/meson.build:41:10:
ERROR: Could not get define 'dev/qat_crypto_pmd_gen4.c'
``
Fixes: d0ce87e41cdc ("event/dlb2: support single 512B write of 4 QEs")
Cc: stable@dpdk.org
Reported-by: Luca Boccassi <bluca@debian.org>
Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com>
---
drivers/event/dlb2/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
03/11/2022 16:22, Ferruh Yigit: > "meson setup" fails when '-Werror' compiler flag is enabled [1]. > This is not a build error in the driver but a build error in meson > during "meson setup" stage. > > This issue exists for a while but meson takes it as a warning and > ignores it unless '-Werror' compiler flag is provided. [...] > Reproduced via `meson -Dc_args='-Werror' build` Is it different of 'meson --werror" as in devtools/test-meson-builds.sh or 'meson -Dwerror=true' as in .ci/linux-build.sh?
On 11/3/2022 3:35 PM, Thomas Monjalon wrote: > 03/11/2022 16:22, Ferruh Yigit: >> "meson setup" fails when '-Werror' compiler flag is enabled [1]. >> This is not a build error in the driver but a build error in meson >> during "meson setup" stage. >> >> This issue exists for a while but meson takes it as a warning and >> ignores it unless '-Werror' compiler flag is provided. > [...] >> Reproduced via `meson -Dc_args='-Werror' build` > > Is it different of 'meson --werror" as in devtools/test-meson-builds.sh > or 'meson -Dwerror=true' as in .ci/linux-build.sh? > As I checked now, it seems there is a difference. Via "meson --werror" & "meson -Dwerror=true", '-Werror' flag is used to compile dpdk source code, but meson doesn't use the flag for its internal logic, so this seems more proper usage. Via "meson -Dc_args='-Werror'" & "CFLAGS='-Werror' meson" usage, '-Werror' flag is used both to compile dpdk code and meson internal logic, so that is why this usage cause build error. And independent from the above usage difference, event/dlb2 meson file is wrong and this fix is required. I assume 'dlb2_avx512.c' compiled because of the '-mavx512vl' fallback and that is why mentioned error is not detected.
On Thu, Nov 3, 2022 at 9:52 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > > On 11/3/2022 3:35 PM, Thomas Monjalon wrote: > > 03/11/2022 16:22, Ferruh Yigit: > >> "meson setup" fails when '-Werror' compiler flag is enabled [1]. > >> This is not a build error in the driver but a build error in meson > >> during "meson setup" stage. > >> > >> This issue exists for a while but meson takes it as a warning and > >> ignores it unless '-Werror' compiler flag is provided. > > [...] > >> Reproduced via `meson -Dc_args='-Werror' build` > > > > Is it different of 'meson --werror" as in devtools/test-meson-builds.sh > > or 'meson -Dwerror=true' as in .ci/linux-build.sh? > > > > As I checked now, it seems there is a difference. > > Via "meson --werror" & "meson -Dwerror=true", > '-Werror' flag is used to compile dpdk source code, but meson doesn't > use the flag for its internal logic, so this seems more proper usage. > > Via "meson -Dc_args='-Werror'" & "CFLAGS='-Werror' meson" usage, > '-Werror' flag is used both to compile dpdk code and meson internal > logic, so that is why this usage cause build error. > > > And independent from the above usage difference, event/dlb2 meson file > is wrong and this fix is required. > I assume 'dlb2_avx512.c' compiled because of the '-mavx512vl' fallback > and that is why mentioned error is not detected. + @abdullah.sevincer@intel.com Waiting from Ack from Abdullah to merge
On Fri, Nov 4, 2022 at 4:30 PM Jerin Jacob <jerinjacobk@gmail.com> wrote: > > On Thu, Nov 3, 2022 at 9:52 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > > > > On 11/3/2022 3:35 PM, Thomas Monjalon wrote: > > > 03/11/2022 16:22, Ferruh Yigit: > > >> "meson setup" fails when '-Werror' compiler flag is enabled [1]. > > >> This is not a build error in the driver but a build error in meson > > >> during "meson setup" stage. > > >> > > >> This issue exists for a while but meson takes it as a warning and > > >> ignores it unless '-Werror' compiler flag is provided. > > > [...] > > >> Reproduced via `meson -Dc_args='-Werror' build` > > > > > > Is it different of 'meson --werror" as in devtools/test-meson-builds.sh > > > or 'meson -Dwerror=true' as in .ci/linux-build.sh? > > > > > > > As I checked now, it seems there is a difference. > > > > Via "meson --werror" & "meson -Dwerror=true", > > '-Werror' flag is used to compile dpdk source code, but meson doesn't > > use the flag for its internal logic, so this seems more proper usage. > > > > Via "meson -Dc_args='-Werror'" & "CFLAGS='-Werror' meson" usage, > > '-Werror' flag is used both to compile dpdk code and meson internal > > logic, so that is why this usage cause build error. > > > > > > And independent from the above usage difference, event/dlb2 meson file > > is wrong and this fix is required. > > I assume 'dlb2_avx512.c' compiled because of the '-mavx512vl' fallback > > and that is why mentioned error is not detected. > > + @abdullah.sevincer@intel.com > > Waiting from Ack from Abdullah to merge No reply. Patch looks reasonable to me. Applied to dpdk-next-net-eventdev/for-main. Thanks
diff --git a/drivers/event/dlb2/meson.build b/drivers/event/dlb2/meson.build index 20ef159ab327..a2e60273c516 100644 --- a/drivers/event/dlb2/meson.build +++ b/drivers/event/dlb2/meson.build @@ -38,7 +38,7 @@ if binutils_ok # check if all required flags already enabled (variant a). dlb2_avx512_on = false - if cc.get_define(f, args: machine_args) == '__AVX512VL__' + if cc.get_define('__AVX512VL__', args: machine_args) != '' dlb2_avx512_on = true endif