Message ID | 20220929065006.832858-1-alialnu@nvidia.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8F6D8A00C4; Thu, 29 Sep 2022 08:50:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3D7F740FAE; Thu, 29 Sep 2022 08:50:44 +0200 (CEST) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2040.outbound.protection.outlook.com [40.107.244.40]) by mails.dpdk.org (Postfix) with ESMTP id 028DA40E5A for <dev@dpdk.org>; Thu, 29 Sep 2022 08:50:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=APfYqQ6YFA/f2FCsRtGidkWjrcs/PB5vblC1k9kf4e/OphGAioQk8PdWKOsSXhFqrd6Gws05EstZCMSzqTO2tlKyAmJC4YnX4tAVYQ+OCiv7Fqe0e6l4KEYmvCg9GZ87tmgFokfTXwoOt0z94ARoyL05P5K+g+wS6G2D0R01BYWVc/3QA6Om0IlpuPZxp5pjW4eqflw1c8rdgTjtzm7f8PlPrzMSyJBTLwUu+4MSpAthTKYgRRSWy0a3xt1ub+u7cQBOr1ssowpaD7+KixRNrgbesQJerGimsWslFwsWvwKxnOTJ8f9OO1yIR8bgL3xBE/SQPr3HYbm7zxaFz1i4Kw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=OKD9Z4BF8LG7/IBqKCa8y8Ug4pKvWQZfhV6ZXR0TRFQ=; b=NlXfacSzKCLoxkjUtO++wZJk3QOH2HIQNqz4hffp778iUhEXgnLTsvKN7T4SIWtbJUg3qlfxxd8bQrWlSPDzuAaMWkjGmB3+MsX4seJCRy/Me2Ib9eOAxwLRNwXIKvmWLP0RCcHP7l1zh8cQ7dmoexv5TShGgWKBzyXLLmRFDkpnw1DalPMrdaZaY7iRBnXjfka3hjXgEXqc8mtuCm+qmWo3fqfFfmEcv2HRD0cVlzlLjIQ3uDCUsox7TIcIlX98gj8gykvVYFN8H9YL+8L2ncovWK4Xk4LchbzC1BijtUPO1B7lC/ge0XYxs7P5bZY7ieZWjOD+R0lxg3N/f/5d2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=OKD9Z4BF8LG7/IBqKCa8y8Ug4pKvWQZfhV6ZXR0TRFQ=; b=AJnFOr2wit8H7GQ/NYwL3bWvge46F3aOe+leGwx+v1Pl9+9PBlx+nTC1ZAlu6U5jg9qc3YTnMqZjbh2sr5Yca/txiGO33Vb9T6bc7ZAmfN5YNQQhKDbYPtPe/ta5VqYd0XSbSZiMudrr42boNi4vIvr3L18NFP/smJUsoiwZPBKAllEDmXFMmMnSvPhhCoDF9YrdLGtTgHIvXFP5LZZmv28lulRtdO/H54/fvmnbXUI64I8rsEoFvp9l+Ztpe1N3YANVIFoglOKXR7tPrXPS5X8vYnqBB8E7oHeYksToV+z09Fbk1tZItyh1BmSZqB9fr0Uz23j1u+G3I2GWeW89Ig== Received: from MW3PR05CA0027.namprd05.prod.outlook.com (2603:10b6:303:2b::32) by PH7PR12MB6393.namprd12.prod.outlook.com (2603:10b6:510:1ff::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.15; Thu, 29 Sep 2022 06:50:41 +0000 Received: from CO1NAM11FT102.eop-nam11.prod.protection.outlook.com (2603:10b6:303:2b:cafe::dc) by MW3PR05CA0027.outlook.office365.com (2603:10b6:303:2b::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.9 via Frontend Transport; Thu, 29 Sep 2022 06:50:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT102.mail.protection.outlook.com (10.13.175.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5676.17 via Frontend Transport; Thu, 29 Sep 2022 06:50:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Wed, 28 Sep 2022 23:50:28 -0700 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Wed, 28 Sep 2022 23:50:27 -0700 From: Ali Alnubani <alialnu@nvidia.com> To: <dev@dpdk.org> CC: <gakhil@marvell.com> Subject: [PATCH] net: fix build with -Wpedantic Date: Thu, 29 Sep 2022 09:50:06 +0300 Message-ID: <20220929065006.832858-1-alialnu@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT102:EE_|PH7PR12MB6393:EE_ X-MS-Office365-Filtering-Correlation-Id: 5f32b8bd-ab66-4112-1f4e-08daa1e6ec51 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BpLe2gvyAI5oihA5qj8AYUsQorDKFtsIaX27TnAWHUxvGkTwhxgrG7iy56bzuaz3PR2i+lpqfML+qCkOQLwsbjz/OTCIdyqbDg6voCC/J8nI7WXiRdY60+r32ag7N6A3/G1SXYAvLcigDAL14vFTz6/mdLQzpnDwBYL+AlbQUfjz3eq85da0U1IA8q3H/rUIJo4z3ulYHTnDIlCxgOGgQ9v7j4lgg3IKEvlwHZBVOuWdDQXr445YrqnmdAzyHLr9X65SzMNtcpOu+9OaoTRcxNEIcWghOodgpsp+KMzkG4letTu+L2FKKwEdrln3PBAZNc8O7B0boQf1ncyROjBfBT5CtZJIATibYVWjCNZvWDJoLpGDirIjWMR1eVx+LPV1oFxQfSkH+zW2b0qPQR8PzzrYsp4J8V2Q0eoNghU2Q0ejYZxH9RwQqPZrcjJfQJB5atloEk4WnS+V3kLKmcHDS7SFf+4zzLC3GKbVPRu5f+f7Q4r1otXlDtD37TiWbYkeVqqBxZdrvQRaXrL1f+MDMiIOAwx0kbQIYoWUESMDSil3/GKXzscPL9Mg+WSONUpzLH21D7iM3TYF37qXK8QVl4jWHuLuW9ELMittJF/jWSl0aY9s+6qkS6KOpxpDWD+W4xv7DEbsbpRfyS1NhTgLkSGw0/HmUTqI2Xik5C+HkCz9NXrngaSW2D+FPiI5r/qN153ZNCNU/DrOKH/9IL5NoPa9BFXr0Ke5OhEUtII5kZfjD4bb7lt63xciCklUqQOXUQC+FQfQwMj9TA3TGedUdg== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(376002)(396003)(39860400002)(136003)(346002)(451199015)(36840700001)(40470700004)(46966006)(36860700001)(55016003)(16526019)(83380400001)(336012)(1076003)(186003)(47076005)(40480700001)(426003)(316002)(8936002)(86362001)(8676002)(4326008)(6286002)(478600001)(2616005)(26005)(36756003)(41300700001)(2906002)(4744005)(7636003)(70206006)(6916009)(40460700003)(7696005)(6666004)(70586007)(82310400005)(356005)(5660300002)(82740400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Sep 2022 06:50:40.4698 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f32b8bd-ab66-4112-1f4e-08daa1e6ec51 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT102.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB6393 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
Series |
net: fix build with -Wpedantic
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/iol-aarch64-unit-testing | success | Testing PASS |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/iol-intel-Functional | success | Functional Testing PASS |
ci/iol-x86_64-compile-testing | success | Testing PASS |
ci/iol-x86_64-unit-testing | success | Testing PASS |
ci/iol-aarch64-compile-testing | success | Testing PASS |
Commit Message
Ali Alnubani
Sept. 29, 2022, 6:50 a.m. UTC
Adds the __extension__ attribute to resolve the following warning
with gcc 4.8.5 on CentOS 7:
lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is
a GCC extension [-Werror=pedantic]
Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item")
Cc: gakhil@marvell.com
Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
---
lib/net/rte_macsec.h | 1 +
1 file changed, 1 insertion(+)
Comments
> Adds the __extension__ attribute to resolve the following warning > with gcc 4.8.5 on CentOS 7: > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is > a GCC extension [-Werror=pedantic] > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item") > Cc: gakhil@marvell.com > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com> > --- > lib/net/rte_macsec.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h > index 9228ebd083..d0cd2f69ab 100644 > --- a/lib/net/rte_macsec.h > +++ b/lib/net/rte_macsec.h > @@ -28,6 +28,7 @@ extern "C" { > /** > * MACsec Header (SecTAG) > */ > +__extension__ RTE_STD_C11 ?? > struct rte_macsec_hdr { > /** > * Tag control information and Association number of secure channel. > -- > 2.25.1
> -----Original Message----- > From: Akhil Goyal <gakhil@marvell.com> > Sent: Thursday, September 29, 2022 10:02 AM > To: Ali Alnubani <alialnu@nvidia.com>; dev@dpdk.org > Subject: RE: [EXT] [PATCH] net: fix build with -Wpedantic > > > Adds the __extension__ attribute to resolve the following warning > > with gcc 4.8.5 on CentOS 7: > > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is > > a GCC extension [-Werror=pedantic] > > > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item") > > Cc: gakhil@marvell.com > > > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com> > > --- > > lib/net/rte_macsec.h | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h > > index 9228ebd083..d0cd2f69ab 100644 > > --- a/lib/net/rte_macsec.h > > +++ b/lib/net/rte_macsec.h > > @@ -28,6 +28,7 @@ extern "C" { > > /** > > * MACsec Header (SecTAG) > > */ > > +__extension__ > > RTE_STD_C11 ?? Replacing the __extension__ attribute with RTE_STD_C11 doesn't resolve the build failure for me.
> > > Adds the __extension__ attribute to resolve the following warning > > > with gcc 4.8.5 on CentOS 7: > > > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is > > > a GCC extension [-Werror=pedantic] > > > > > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item") > > > Cc: gakhil@marvell.com > > > > > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com> > > > --- > > > lib/net/rte_macsec.h | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h > > > index 9228ebd083..d0cd2f69ab 100644 > > > --- a/lib/net/rte_macsec.h > > > +++ b/lib/net/rte_macsec.h > > > @@ -28,6 +28,7 @@ extern "C" { > > > /** > > > * MACsec Header (SecTAG) > > > */ > > > +__extension__ > > > > RTE_STD_C11 ?? > > Replacing the __extension__ attribute with RTE_STD_C11 doesn't resolve the > build failure for me. Ok, Thanks for the fix. Acked-by: Akhil Goyal <gakhil@marvell.com>
29/09/2022 09:01, Akhil Goyal: > > Adds the __extension__ attribute to resolve the following warning > > with gcc 4.8.5 on CentOS 7: > > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is > > a GCC extension [-Werror=pedantic] > > > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item") > > Cc: gakhil@marvell.com > > > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com> > > --- > > --- a/lib/net/rte_macsec.h > > +++ b/lib/net/rte_macsec.h > > @@ -28,6 +28,7 @@ extern "C" { > > /** > > * MACsec Header (SecTAG) > > */ > > +__extension__ > > RTE_STD_C11 ?? We use RTE_STD_C11 only for anonymous struct and union. I don't know why we don't use it for bitfield in struct. It seems to be part of C11 standard, right? In doubt, I would continue with __extension__ and we can replace all similar occurences in a separate patch, if confirmed it is well defined in C11.
29/09/2022 09:09, Akhil Goyal: > > > > Adds the __extension__ attribute to resolve the following warning > > > > with gcc 4.8.5 on CentOS 7: > > > > lib/net/rte_macsec.h:38:2: error: type of bit-field 'short_length' is > > > > a GCC extension [-Werror=pedantic] > > > > > > > > Fixes: 0aaf097585a6 ("ethdev: add MACsec flow item") > > > > Cc: gakhil@marvell.com > > > > > > > > Signed-off-by: Ali Alnubani <alialnu@nvidia.com> > > > > --- > > > > lib/net/rte_macsec.h | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h > > > > index 9228ebd083..d0cd2f69ab 100644 > > > > --- a/lib/net/rte_macsec.h > > > > +++ b/lib/net/rte_macsec.h > > > > @@ -28,6 +28,7 @@ extern "C" { > > > > /** > > > > * MACsec Header (SecTAG) > > > > */ > > > > +__extension__ > > > > > > RTE_STD_C11 ?? > > > > Replacing the __extension__ attribute with RTE_STD_C11 doesn't resolve the > > build failure for me. > > Ok, Thanks for the fix. > > Acked-by: Akhil Goyal <gakhil@marvell.com> Applied, thanks.
diff --git a/lib/net/rte_macsec.h b/lib/net/rte_macsec.h index 9228ebd083..d0cd2f69ab 100644 --- a/lib/net/rte_macsec.h +++ b/lib/net/rte_macsec.h @@ -28,6 +28,7 @@ extern "C" { /** * MACsec Header (SecTAG) */ +__extension__ struct rte_macsec_hdr { /** * Tag control information and Association number of secure channel.