Checks
Commit Message
A recent commit removed errno.h from rte_common.h.
It has to be added in various places where it is used,
and wad implicitly included via rte_common.h,
but was forgotten in gpu/cuda.
As a result, the compilation is broken:
drivers/gpu/cuda/gdrcopy.c:116:17: error: ‘ENOTSUP’ undeclared
Note that rte_errno.h does not include errno.h.
The include of errno.h is added.
Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/gpu/cuda/common.h | 1 +
1 file changed, 1 insertion(+)
Comments
On Fri, Sep 23, 2022 at 10:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> A recent commit removed errno.h from rte_common.h.
> It has to be added in various places where it is used,
> and wad implicitly included via rte_common.h,
was*
> but was forgotten in gpu/cuda.
>
> As a result, the compilation is broken:
> drivers/gpu/cuda/gdrcopy.c:116:17: error: ‘ENOTSUP’ undeclared
>
> Note that rte_errno.h does not include errno.h.
> The include of errno.h is added.
>
> Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header")
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
I installed the cuda library headers and can confirm the build issue is fixed.
Tested-by: David Marchand <david.marchand@redhat.com>
On Fri, Sep 23, 2022 at 10:29 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Sep 23, 2022 at 10:26 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> >
> > A recent commit removed errno.h from rte_common.h.
> > It has to be added in various places where it is used,
> > and wad implicitly included via rte_common.h,
>
> was*
>
> > but was forgotten in gpu/cuda.
> >
> > As a result, the compilation is broken:
> > drivers/gpu/cuda/gdrcopy.c:116:17: error: ‘ENOTSUP’ undeclared
> >
> > Note that rte_errno.h does not include errno.h.
> > The include of errno.h is added.
> >
> > Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header")
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Tested-by: David Marchand <david.marchand@redhat.com>
Applied, thanks.
@@ -6,6 +6,7 @@
#define CUDA_COMMON_H
#include <dlfcn.h>
+#include <errno.h>
#include <rte_common.h>
#include <rte_log.h>