| Message ID | 20220820023157.189047-36-hernan.vargas@intel.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | akhil goyal |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D950CA034C; Fri, 19 Aug 2022 20:40:02 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 78BA942C10; Fri, 19 Aug 2022 20:36:46 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mails.dpdk.org (Postfix) with ESMTP id B27F542B9F for <dev@dpdk.org>; Fri, 19 Aug 2022 20:36:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1660934187; x=1692470187; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=mvUaP03aKi8oJDQjj/i/u7p6q53TD+5n0vQt2UEjjI8=; b=NQOCdl+Fyqes18uxoikPFT9v42MtvuqvQs2D59riTT2/LPKAqNcb1Xy/ wO5oJaASZOunfZSAO6s3ntaTitilKe0/+HVehF9UCvVXCycfrpZF/igGZ bSZuKIro6XD8f+5FBRi/CNLb/9qUx/TBfI76hgoLXMYnviCKwRTNpcDOM nQyktkgf5nJVtVjTKEAK0aK2hK02ZQxCw3f6drOuBRx9bxxf9oGtGZX5a /HEktEGPbHF/Ty9m/tPU3ezaEmVejhXKMFVZQy0u54U/FAj3uil91vi47 IOlRtkNPEqLQD4tVOP3vnAGLDl7uiDlA8toIOWHPPtg+HaTJQoBIUY1Mg w==; X-IronPort-AV: E=McAfee;i="6500,9779,10444"; a="319107336" X-IronPort-AV: E=Sophos;i="5.93,248,1654585200"; d="scan'208";a="319107336" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 19 Aug 2022 11:36:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,248,1654585200"; d="scan'208";a="608296366" Received: from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103]) by orsmga002.jf.intel.com with ESMTP; 19 Aug 2022 11:36:26 -0700 From: Hernan Vargas <hernan.vargas@intel.com> To: dev@dpdk.org, gakhil@marvell.com, trix@redhat.com Cc: nicolas.chautru@intel.com, qi.z.zhang@intel.com, Hernan Vargas <hernan.vargas@intel.com> Subject: [PATCH v2 35/37] baseband/acc100: add protection for NULL HARQ input Date: Fri, 19 Aug 2022 19:31:55 -0700 Message-Id: <20220820023157.189047-36-hernan.vargas@intel.com> X-Mailer: git-send-email 2.37.1 In-Reply-To: <20220820023157.189047-1-hernan.vargas@intel.com> References: <20220820023157.189047-1-hernan.vargas@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org |
| Series |
baseband/acc100: changes for 22.11
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
Commit Message
Vargas, Hernan
Aug. 20, 2022, 2:31 a.m. UTC
It is possible to cause an invalid HW operation in case the user
provides the BBDEV API and HARQ operation with input enabled and zero
input. Adding protection for that case.
Signed-off-by: Hernan Vargas <hernan.vargas@intel.com>
---
drivers/baseband/acc100/rte_acc100_pmd.c | 8 ++++++++
1 file changed, 8 insertions(+)
Comments
On 8/20/22 04:31, Hernan Vargas wrote: > It is possible to cause an invalid HW operation in case the user > provides the BBDEV API and HARQ operation with input enabled and zero Not sure, but s/and/a/? This is again a fix, and should be tagged appropriately. > input. Adding protection for that case. > > Signed-off-by: Hernan Vargas <hernan.vargas@intel.com> > --- > drivers/baseband/acc100/rte_acc100_pmd.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c > index 461ebe67cd..be4c1d07ed 100644 > --- a/drivers/baseband/acc100/rte_acc100_pmd.c > +++ b/drivers/baseband/acc100/rte_acc100_pmd.c > @@ -1457,6 +1457,14 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw, > op->ldpc_dec.tb_params.ea : > op->ldpc_dec.tb_params.eb; > > + if (unlikely(check_bit(op->ldpc_dec.op_flags, > + RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE) && > + (op->ldpc_dec.harq_combined_input.length == 0))) { > + rte_bbdev_log(WARNING, "Null HARQ input size provided"); > + /* Disable HARQ input in that case to carry forward */ > + op->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE; > + } > + > fcw->hcin_en = check_bit(op->ldpc_dec.op_flags, > RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE); > fcw->hcout_en = check_bit(op->ldpc_dec.op_flags,
diff --git a/drivers/baseband/acc100/rte_acc100_pmd.c b/drivers/baseband/acc100/rte_acc100_pmd.c index 461ebe67cd..be4c1d07ed 100644 --- a/drivers/baseband/acc100/rte_acc100_pmd.c +++ b/drivers/baseband/acc100/rte_acc100_pmd.c @@ -1457,6 +1457,14 @@ acc100_fcw_ld_fill(struct rte_bbdev_dec_op *op, struct acc100_fcw_ld *fcw, op->ldpc_dec.tb_params.ea : op->ldpc_dec.tb_params.eb; + if (unlikely(check_bit(op->ldpc_dec.op_flags, + RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE) && + (op->ldpc_dec.harq_combined_input.length == 0))) { + rte_bbdev_log(WARNING, "Null HARQ input size provided"); + /* Disable HARQ input in that case to carry forward */ + op->ldpc_dec.op_flags ^= RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE; + } + fcw->hcin_en = check_bit(op->ldpc_dec.op_flags, RTE_BBDEV_LDPC_HQ_COMBINE_IN_ENABLE); fcw->hcout_en = check_bit(op->ldpc_dec.op_flags,