test/crypto: fix authentication IV for zuc SGL
Checks
Commit Message
The wireless operation for ZUC SGL tests was being passed NULL instead
of a pointer to the test data authentication IV, and IV length 0.
This is now corrected to use the IV from the test data.
Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP")
Cc: stable@dpdk.org
Signed-off-by: Ciara Power <ciara.power@intel.com>
---
app/test/test_cryptodev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Ciara,
> -----Original Message-----
> From: Power, Ciara <ciara.power@intel.com>
> Sent: Thursday, June 23, 2022 4:32 PM
> To: Akhil Goyal <gakhil@marvell.com>; Zhang, Roy Fan
> <roy.fan.zhang@intel.com>
> Cc: dev@dpdk.org; Ji, Kai <kai.ji@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Power, Ciara <ciara.power@intel.com>;
> stable@dpdk.org
> Subject: [PATCH] test/crypto: fix authentication IV for zuc SGL
>
> The wireless operation for ZUC SGL tests was being passed NULL instead of a
> pointer to the test data authentication IV, and IV length 0.
> This is now corrected to use the IV from the test data.
>
> Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ciara Power <ciara.power@intel.com>
Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> >
> > The wireless operation for ZUC SGL tests was being passed NULL instead of a
> > pointer to the test data authentication IV, and IV length 0.
> > This is now corrected to use the IV from the test data.
> >
> > Fixes: 11c5485bb276 ("test/crypto: add scatter-gather tests for IP and OOP")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Ciara Power <ciara.power@intel.com>
>
> Acked-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Applied to dpdk-next-crypto
Thanks.
@@ -6563,7 +6563,7 @@ test_zuc_auth_cipher_sgl(const struct wireless_test_data *tdata,
retval = create_wireless_algo_auth_cipher_operation(
tdata->digest.data, tdata->digest.len,
tdata->cipher_iv.data, tdata->cipher_iv.len,
- NULL, 0,
+ tdata->auth_iv.data, tdata->auth_iv.len,
(tdata->digest.offset_bytes == 0 ?
(verify ? ciphertext_pad_len : plaintext_pad_len)
: tdata->digest.offset_bytes),