[dpdk-dev,15/20] bnx2x: copy pci device info to eth_dev data
Commit Message
Signed-off-by: Bernard Iremonger <bernard.iremonger@intel.com>
---
drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++
1 file changed, 4 insertions(+)
Comments
On Mon, 28 Sep 2015 14:03:33 +0100
Bernard Iremonger <bernard.iremonger@intel.com> wrote:
> /*
> * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
> + * Copyright(c) 2015 Intel Corporation.
> *
> * All rights reserved.
> */
I agree with others, you can't claim copyright until you have
made substantive changes. At one point a lawyer told me that
had to be 10% of the code.
Hi Stephen,
<snip>
> On Mon, 28 Sep 2015 14:03:33 +0100
> Bernard Iremonger <bernard.iremonger@intel.com> wrote:
>
> > /*
> > * Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
> > + * Copyright(c) 2015 Intel Corporation.
> > *
> > * All rights reserved.
> > */
>
> I agree with others, you can't claim copyright until you have made
> substantive changes. At one point a lawyer told me that had to be 10% of the
> code.
I thought it was necessary to add the copyright line because I had modified the code.
I will remove it in the next revision of the patch set.
Regards,
Bernard.
@@ -1,5 +1,6 @@
/*
* Copyright (c) 2013-2015 Brocade Communications Systems, Inc.
+ * Copyright(c) 2015 Intel Corporation.
*
* All rights reserved.
*/
@@ -419,6 +420,9 @@ bnx2x_common_dev_init(struct rte_eth_dev *eth_dev, int is_vf)
eth_dev->dev_ops = is_vf ? &bnx2xvf_eth_dev_ops : &bnx2x_eth_dev_ops;
pci_dev = eth_dev->pci_dev;
+
+ rte_eth_copy_dev_info(eth_dev, pci_dev);
+
sc = eth_dev->data->dev_private;
sc->pcie_bus = pci_dev->addr.bus;
sc->pcie_device = pci_dev->addr.devid;