[1/4] crypto: add dsa random number k
Checks
Commit Message
This commit adds random number 'k' to dsa
op param struct.
Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
lib/cryptodev/rte_crypto_asym.h | 4 ++++
1 file changed, 4 insertions(+)
Comments
> -----Original Message-----
> From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Sent: Wednesday, February 2, 2022 6:50 AM
> To: dev@dpdk.org
> Cc: gakhil@marvell.com; Zhang, Roy Fan <roy.fan.zhang@intel.com>;
> rbalu@marvell.com; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [PATCH 1/4] crypto: add dsa random number k
>
> This commit adds random number 'k' to dsa
> op param struct.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
> lib/cryptodev/rte_crypto_asym.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/lib/cryptodev/rte_crypto_asym.h
> b/lib/cryptodev/rte_crypto_asym.h
> index 9c866f553f..e0def3d9ab 100644
> --- a/lib/cryptodev/rte_crypto_asym.h
> +++ b/lib/cryptodev/rte_crypto_asym.h
> @@ -547,6 +547,10 @@ struct rte_crypto_dsa_op_param {
> /**< Signature Generation or Verification */
> rte_crypto_param message;
> /**< input message to be signed or verified */
> + rte_crypto_param k;
> + /**< Per-message secret number, which is an integer
> + * in the interval (1, q-1)
> + */
> rte_crypto_param r;
> /**< dsa sign component 'r' value
> *
> --
> 2.13.6
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
Hi Arek,
> This commit adds random number 'k' to dsa
> op param struct.
>
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> ---
Could you please update the description of the patches,
To describe the need of the patch and what has been done in the patch.
Most of the commits in this set does not describe the need of the patch.
@@ -547,6 +547,10 @@ struct rte_crypto_dsa_op_param {
/**< Signature Generation or Verification */
rte_crypto_param message;
/**< input message to be signed or verified */
+ rte_crypto_param k;
+ /**< Per-message secret number, which is an integer
+ * in the interval (1, q-1)
+ */
rte_crypto_param r;
/**< dsa sign component 'r' value
*