Message ID | 55F7CCE9.8060807@linux.vnet.ibm.com (mailing list archive) |
---|---|
State | Not Applicable, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 31961919D; Tue, 15 Sep 2015 09:47:47 +0200 (CEST) Received: from e23smtp07.au.ibm.com (e23smtp07.au.ibm.com [202.81.31.140]) by dpdk.org (Postfix) with ESMTP id 180E7919B for <dev@dpdk.org>; Tue, 15 Sep 2015 09:47:43 +0200 (CEST) Received: from /spool/local by e23smtp07.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for <dev@dpdk.org> from <chaozhu@linux.vnet.ibm.com>; Tue, 15 Sep 2015 17:47:42 +1000 Received: from d23dlp01.au.ibm.com (202.81.31.203) by e23smtp07.au.ibm.com (202.81.31.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Tue, 15 Sep 2015 17:47:40 +1000 X-Helo: d23dlp01.au.ibm.com X-MailFrom: chaozhu@linux.vnet.ibm.com X-RcptTo: dev@dpdk.org Received: from d23relay08.au.ibm.com (d23relay08.au.ibm.com [9.185.71.33]) by d23dlp01.au.ibm.com (Postfix) with ESMTP id 944762CE8056 for <dev@dpdk.org>; Tue, 15 Sep 2015 17:47:38 +1000 (EST) Received: from d23av02.au.ibm.com (d23av02.au.ibm.com [9.190.235.138]) by d23relay08.au.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id t8F7lLvV62324936 for <dev@dpdk.org>; Tue, 15 Sep 2015 17:47:29 +1000 Received: from d23av02.au.ibm.com (localhost [127.0.0.1]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id t8F7l6Q2015715 for <dev@dpdk.org>; Tue, 15 Sep 2015 17:47:06 +1000 Received: from [9.186.50.135] ([9.186.50.135]) by d23av02.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id t8F7l4Ew015251; Tue, 15 Sep 2015 17:47:05 +1000 Message-ID: <55F7CCE9.8060807@linux.vnet.ibm.com> Date: Tue, 15 Sep 2015 15:46:49 +0800 From: Chao Zhu <chaozhu@linux.vnet.ibm.com> User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: dev@dpdk.org, thomas.monjalon@6wind.com References: <1439554788-31037-1-git-send-email-chaozhu@linux.vnet.ibm.com> In-Reply-To: <1439554788-31037-1-git-send-email-chaozhu@linux.vnet.ibm.com> X-Forwarded-Message-Id: <1439554788-31037-1-git-send-email-chaozhu@linux.vnet.ibm.com> X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15091507-0025-0000-0000-00000225905E Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Fwd: [PATCH] PPC: Fix NUMA node numbering on IBM POWER8 LE machine X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Chao Zhu
Sept. 15, 2015, 7:46 a.m. UTC
Any response of this patch? -------- Forwarded Message -------- Subject: [dpdk-dev] [PATCH] PPC: Fix NUMA node numbering on IBM POWER8 LE machine Date: Fri, 14 Aug 2015 20:19:48 +0800 From: Chao Zhu <chaozhu@linux.vnet.ibm.com> To: dev@dpdk.org When Linux is running on bare metal, it gets the raw hardware information. On POWER8 little endian bare metal machine, the node number is not continuous. It will jump from 0 to other values, for example, it can be 0, 1, 16, 17. This patch modified the CONFIG_RTE_MAX_NUMA_NODES value to make dpdk work on POWER8 bare metal little endian machine. Signed-off-by: Chao Zhu <chaozhu@linux.vnet.ibm.com> --- config/common_linuxapp | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Comments
On Tue, Sep 15, 2015 at 03:46:49PM +0800, Chao Zhu wrote: > > Any response of this patch? Looks ok to me - pretty trivial change. /Bruce > > -------- Forwarded Message -------- > Subject: [dpdk-dev] [PATCH] PPC: Fix NUMA node numbering on IBM POWER8 LE > machine > Date: Fri, 14 Aug 2015 20:19:48 +0800 > From: Chao Zhu <chaozhu@linux.vnet.ibm.com> > To: dev@dpdk.org > > > > When Linux is running on bare metal, it gets the raw hardware > information. On POWER8 little endian bare metal machine, the node number > is not continuous. It will jump from 0 to other values, for example, it > can be 0, 1, 16, 17. This patch modified the CONFIG_RTE_MAX_NUMA_NODES > value to make dpdk work on POWER8 bare metal little endian machine. > > Signed-off-by: Chao Zhu <chaozhu@linux.vnet.ibm.com> > --- > config/common_linuxapp | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/config/common_linuxapp b/config/common_linuxapp > index 0de43d5..82a027e 100644 > --- a/config/common_linuxapp > +++ b/config/common_linuxapp > @@ -98,7 +98,7 @@ CONFIG_RTE_NEXT_ABI=y > # > CONFIG_RTE_LIBRTE_EAL=y > CONFIG_RTE_MAX_LCORE=128 > -CONFIG_RTE_MAX_NUMA_NODES=8 > +CONFIG_RTE_MAX_NUMA_NODES=32 > CONFIG_RTE_MAX_MEMSEG=256 > CONFIG_RTE_MAX_MEMZONE=2560 > CONFIG_RTE_MAX_TAILQ=32 > -- > 1.7.1 > > >
Actually, without this change, DPDK can't work properly on PPC64 little endian platform. It'll report "EAL: Not enough memory available! Requested: xxxMB, available: xxxMB" such kind of error. But for users, they don't know that changing the value of CONFIG_RTE_MAX_NUMA_NODES can fix this. That why I invoke this patch. On 2015/9/15 17:01, Bruce Richardson wrote: > On Tue, Sep 15, 2015 at 03:46:49PM +0800, Chao Zhu wrote: >> Any response of this patch? > Looks ok to me - pretty trivial change. > > /Bruce >> -------- Forwarded Message -------- >> Subject: [dpdk-dev] [PATCH] PPC: Fix NUMA node numbering on IBM POWER8 LE >> machine >> Date: Fri, 14 Aug 2015 20:19:48 +0800 >> From: Chao Zhu <chaozhu@linux.vnet.ibm.com> >> To: dev@dpdk.org >> >> >> >> When Linux is running on bare metal, it gets the raw hardware >> information. On POWER8 little endian bare metal machine, the node number >> is not continuous. It will jump from 0 to other values, for example, it >> can be 0, 1, 16, 17. This patch modified the CONFIG_RTE_MAX_NUMA_NODES >> value to make dpdk work on POWER8 bare metal little endian machine. >> >> Signed-off-by: Chao Zhu <chaozhu@linux.vnet.ibm.com> >> --- >> config/common_linuxapp | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/config/common_linuxapp b/config/common_linuxapp >> index 0de43d5..82a027e 100644 >> --- a/config/common_linuxapp >> +++ b/config/common_linuxapp >> @@ -98,7 +98,7 @@ CONFIG_RTE_NEXT_ABI=y >> # >> CONFIG_RTE_LIBRTE_EAL=y >> CONFIG_RTE_MAX_LCORE=128 >> -CONFIG_RTE_MAX_NUMA_NODES=8 >> +CONFIG_RTE_MAX_NUMA_NODES=32 >> CONFIG_RTE_MAX_MEMSEG=256 >> CONFIG_RTE_MAX_MEMZONE=2560 >> CONFIG_RTE_MAX_TAILQ=32 >> -- >> 1.7.1 >> >> >>
Hello Chao, On Wed, Sep 16, 2015 at 4:02 AM, Chao Zhu <chaozhu@linux.vnet.ibm.com> wrote: > Actually, without this change, DPDK can't work properly on PPC64 little > endian platform. It'll report "EAL: Not enough memory available! Requested: > xxxMB, available: xxxMB" such kind of error. But for users, they don't know > that changing the value of CONFIG_RTE_MAX_NUMA_NODES can fix this. That > why I invoke this patch. Sorry, I forgot to reply in this thread. Well, to me, this is a workaround. Yes it will work, but what happens if tomorrow we have some hardware that tells us that it has some numa node which 60000 index ? I think we need a rework in eal to proerly handle this, like I said in this mail : http://dpdk.org/ml/archives/dev/2015-September/023630.html Do you think you can look into this ? Thanks.
David, Let me take a look. On 2015/9/16 16:09, David Marchand wrote: > Hello Chao, > > On Wed, Sep 16, 2015 at 4:02 AM, Chao Zhu <chaozhu@linux.vnet.ibm.com > <mailto:chaozhu@linux.vnet.ibm.com>> wrote: > > Actually, without this change, DPDK can't work properly on PPC64 > little endian platform. It'll report "EAL: Not enough memory > available! Requested: xxxMB, available: xxxMB" such kind of error. > But for users, they don't know that changing the value of > CONFIG_RTE_MAX_NUMA_NODES can fix this. That why I invoke this patch. > > > Sorry, I forgot to reply in this thread. > > Well, to me, this is a workaround. > Yes it will work, but what happens if tomorrow we have some hardware > that tells us that it has some numa node which 60000 index ? > > I think we need a rework in eal to proerly handle this, like I said in > this mail : > http://dpdk.org/ml/archives/dev/2015-September/023630.html > > Do you think you can look into this ? > > > Thanks. > > -- > David Marchand
diff --git a/config/common_linuxapp b/config/common_linuxapp index 0de43d5..82a027e 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -98,7 +98,7 @@ CONFIG_RTE_NEXT_ABI=y # CONFIG_RTE_LIBRTE_EAL=y CONFIG_RTE_MAX_LCORE=128 -CONFIG_RTE_MAX_NUMA_NODES=8 +CONFIG_RTE_MAX_NUMA_NODES=32 CONFIG_RTE_MAX_MEMSEG=256 CONFIG_RTE_MAX_MEMZONE=2560 CONFIG_RTE_MAX_TAILQ=32