eal: promote non-EAL lcore API as stable
Checks
Commit Message
This API has been around for more than a year (and is in LTS 20.11).
It did not receive negative feedback and will be used in a next OVS
release.
Mark it stable.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/eal/include/rte_eal.h | 1 -
lib/eal/include/rte_lcore.h | 6 ------
lib/eal/version.map | 14 +++++++-------
3 files changed, 7 insertions(+), 14 deletions(-)
Comments
On 22/10/2021 07:55, David Marchand wrote:
> This API has been around for more than a year (and is in LTS 20.11).
> It did not receive negative feedback and will be used in a next OVS
> release.
> Mark it stable.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
I have tested with rte_lcore_dump(), rte_mp_disable(),
rte_thread_register(), rte_thread_unregister() in OVS patches and they
are straightforward API and worked fine. rte_lcore_iterate() tested
implicitly through rte_lcore_dump().
I haven't used
rte_lcore_callback_register()/rte_lcore_callback_unregister() as they
are optional but it doesn't make sense to leave them experimental while
promoting rte_thread_register()/rte_thread_unregister() which call those
callbacks.
Noting that rte_lcore_iterate() is also in use for 1+ year from
mempool_bucket.
Acked-by: Kevin Traynor <ktraynor@redhat.com>
22/10/2021 12:22, Kevin Traynor:
> On 22/10/2021 07:55, David Marchand wrote:
> > This API has been around for more than a year (and is in LTS 20.11).
> > It did not receive negative feedback and will be used in a next OVS
> > release.
> > Mark it stable.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Acked-by: Kevin Traynor <ktraynor@redhat.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
On Wed, Nov 3, 2021 at 6:41 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> 22/10/2021 12:22, Kevin Traynor:
> > On 22/10/2021 07:55, David Marchand wrote:
> > > This API has been around for more than a year (and is in LTS 20.11).
> > > It did not receive negative feedback and will be used in a next OVS
> > > release.
> > > Mark it stable.
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > Acked-by: Kevin Traynor <ktraynor@redhat.com>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Applied, thanks.
@@ -155,7 +155,6 @@ int rte_eal_primary_proc_alive(const char *config_file_path);
* attached,
* - false, otherwise.
*/
-__rte_experimental
bool rte_mp_disable(void);
#define RTE_MP_MAX_FD_NUM 8 /* The max amount of fds */
@@ -285,7 +285,6 @@ typedef void (*rte_lcore_uninit_cb)(unsigned int lcore_id, void *arg);
* On failure (either memory allocation issue in the function itself or an
* error is returned by the init callback itself), returns NULL.
*/
-__rte_experimental
void *
rte_lcore_callback_register(const char *name, rte_lcore_init_cb init,
rte_lcore_uninit_cb uninit, void *arg);
@@ -300,7 +299,6 @@ rte_lcore_callback_register(const char *name, rte_lcore_init_cb init,
* The handle pointer returned by a former successful call to
* rte_lcore_callback_register.
*/
-__rte_experimental
void
rte_lcore_callback_unregister(void *handle);
@@ -333,7 +331,6 @@ typedef int (*rte_lcore_iterate_cb)(unsigned int lcore_id, void *arg);
* Same return code as the callback last invocation (see rte_lcore_iterate_cb
* description).
*/
-__rte_experimental
int
rte_lcore_iterate(rte_lcore_iterate_cb cb, void *arg);
@@ -343,7 +340,6 @@ rte_lcore_iterate(rte_lcore_iterate_cb cb, void *arg);
* @param f
* The output stream where the dump should be sent.
*/
-__rte_experimental
void
rte_lcore_dump(FILE *f);
@@ -391,14 +387,12 @@ int rte_thread_getname(pthread_t id, char *name, size_t len);
* @return
* On success, return 0; otherwise return -1 with rte_errno set.
*/
-__rte_experimental
int
rte_thread_register(void);
/**
* Unregister current thread and release lcore if one was associated.
*/
-__rte_experimental
void
rte_thread_unregister(void);
@@ -127,10 +127,14 @@ DPDK_22 {
rte_keepalive_mark_sleep; # WINDOWS_NO_EXPORT
rte_keepalive_register_core; # WINDOWS_NO_EXPORT
rte_keepalive_register_relay_callback; # WINDOWS_NO_EXPORT
+ rte_lcore_callback_register;
+ rte_lcore_callback_unregister;
rte_lcore_count;
+ rte_lcore_dump;
rte_lcore_has_role;
rte_lcore_index;
rte_lcore_is_enabled;
+ rte_lcore_iterate;
rte_lcore_to_socket_id;
rte_log;
rte_log_cur_msg_loglevel;
@@ -211,6 +215,7 @@ DPDK_22 {
rte_memzone_walk;
rte_mp_action_register;
rte_mp_action_unregister;
+ rte_mp_disable;
rte_mp_reply;
rte_mp_request_async;
rte_mp_request_sync;
@@ -263,8 +268,10 @@ DPDK_22 {
rte_strsplit;
rte_sys_gettid;
rte_thread_get_affinity;
+ rte_thread_register;
rte_thread_set_affinity;
rte_thread_setname;
+ rte_thread_unregister;
rte_uuid_compare;
rte_uuid_is_null;
rte_uuid_parse;
@@ -382,13 +389,6 @@ EXPERIMENTAL {
# added in 20.08
rte_eal_vfio_get_vf_token; # WINDOWS_NO_EXPORT
- rte_lcore_callback_register;
- rte_lcore_callback_unregister;
- rte_lcore_dump;
- rte_lcore_iterate;
- rte_mp_disable;
- rte_thread_register;
- rte_thread_unregister;
# added in 20.11
__rte_eal_trace_generic_size_t; # WINDOWS_NO_EXPORT