Message ID | 20211026162904.482987-1-maxime.coquelin@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD82CA0547; Tue, 26 Oct 2021 18:29:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 82D1640E0F; Tue, 26 Oct 2021 18:29:18 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5CEC6407FF for <dev@dpdk.org>; Tue, 26 Oct 2021 18:29:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635265756; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=A8+Ri/elAt+Ie174Zn2W/FytCCJPG5TKGob/f0sxlFI=; b=UbkEL1Onxe4yuOv+zMaTfKCKawHqXafXJ+itbD31h6d0WHhvJjzdXj+5KCrmv5nz27kJxA QaWvSAdWciOMZpPLhPgbHKn2QjP/7+atEbyZc0esAzGR1e+XbSLPU8KAHavlCesvSVghk+ RteLzvljtmxRmuHDiCJ0zARTC12fRLM= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-VBLeG_AjO0GqbExOVtLwWA-1; Tue, 26 Oct 2021 12:29:11 -0400 X-MC-Unique: VBLeG_AjO0GqbExOVtLwWA-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9193B1808302; Tue, 26 Oct 2021 16:29:10 +0000 (UTC) Received: from max-t490s.redhat.com (unknown [10.39.208.37]) by smtp.corp.redhat.com (Postfix) with ESMTP id 232FB100EB3D; Tue, 26 Oct 2021 16:29:05 +0000 (UTC) From: Maxime Coquelin <maxime.coquelin@redhat.com> To: dev@dpdk.org, chenbo.xia@intel.com, jiayu.hu@intel.com, yuanx.wang@intel.com, wenwux.ma@intel.com, bruce.richardson@intel.com, john.mcnamara@intel.com Cc: Maxime Coquelin <maxime.coquelin@redhat.com> Date: Tue, 26 Oct 2021 18:28:49 +0200 Message-Id: <20211026162904.482987-1-maxime.coquelin@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=maxime.coquelin@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Subject: [dpdk-dev] [PATCH v2 00/15] vhost: clean-up and simplify async implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
vhost: clean-up and simplify async implementation
|
|
Message
Maxime Coquelin
Oct. 26, 2021, 4:28 p.m. UTC
This series aims at cleaning and simplifying the async enqueue path. I think it makes the code easier to understand, and is necessary before integrating new changes. I may have more reworks to propose in next revisions, but I wanted to share my current status early so that you have time to review/test it. It is only compile-tested, as I don't have HW with IOAT support to test it. Changes in v2: ============== - Print once when max number of iovec is reached (Jiayu) - Increase number of IOVECs from 512 to 2048 (Jiayu) - Fix Vhost example build when raw/ioat is disabled Changes in v1: ============== - Fix missing iovec index increment (Jiayu) - Remove unneeded sanity check on IOV iter index (Jiayu) - Fix async->pkts_info allocation check (Jiayu) - Prevent NULL pointer dereference on async metadata cleanup (Jiayu) *** BLURB HERE *** Maxime Coquelin (15): vhost: move async data in a dedicated structure vhost: hide inflight async structure vhost: simplify async IO vectors vhost: simplify async IO vectors iterators vhost: remove async batch threshold vhost: introduce specific iovec structure vhost: remove useless fields in async iterator struct vhost: improve IO vector logic vhost: remove notion of async descriptor vhost: simplify async enqueue completion vhost: simplify getting the first in-flight index vhost: prepare async for mbuf to desc refactoring vhost: prepare sync for mbuf to desc refactoring vhost: merge sync and async mbuf to desc filling vhost: increase number of async IO vectors examples/vhost/ioat.c | 30 +- examples/vhost/ioat.h | 4 +- lib/vhost/rte_vhost_async.h | 42 +-- lib/vhost/vhost.c | 130 +++---- lib/vhost/vhost.h | 67 ++-- lib/vhost/vhost_user.c | 4 +- lib/vhost/virtio_net.c | 697 ++++++++++++++---------------------- 7 files changed, 382 insertions(+), 592 deletions(-)
Comments
> -----Original Message----- > From: Maxime Coquelin <maxime.coquelin@redhat.com> > Sent: Wednesday, October 27, 2021 12:29 AM > To: dev@dpdk.org; Xia, Chenbo <chenbo.xia@intel.com>; Hu, Jiayu > <jiayu.hu@intel.com>; Wang, YuanX <yuanx.wang@intel.com>; Ma, > WenwuX <wenwux.ma@intel.com>; Richardson, Bruce > <bruce.richardson@intel.com>; Mcnamara, John > <john.mcnamara@intel.com> > Cc: Maxime Coquelin <maxime.coquelin@redhat.com> > Subject: [PATCH v2 00/15] vhost: clean-up and simplify async implementation > > This series aims at cleaning and simplifying the async enqueue path. I think it > makes the code easier to understand, and is necessary before integrating > new changes. > > I may have more reworks to propose in next revisions, but I wanted to share > my current status early so that you have time to review/test it. > > It is only compile-tested, as I don't have HW with IOAT support to test it. > > Changes in v2: > ============== > - Print once when max number of iovec is reached (Jiayu) > - Increase number of IOVECs from 512 to 2048 (Jiayu) > - Fix Vhost example build when raw/ioat is disabled > > Changes in v1: > ============== > - Fix missing iovec index increment (Jiayu) > - Remove unneeded sanity check on IOV iter index (Jiayu) > - Fix async->pkts_info allocation check (Jiayu) > - Prevent NULL pointer dereference on async metadata cleanup (Jiayu) > > *** BLURB HERE *** > > Maxime Coquelin (15): > vhost: move async data in a dedicated structure > vhost: hide inflight async structure > vhost: simplify async IO vectors > vhost: simplify async IO vectors iterators > vhost: remove async batch threshold > vhost: introduce specific iovec structure > vhost: remove useless fields in async iterator struct > vhost: improve IO vector logic > vhost: remove notion of async descriptor > vhost: simplify async enqueue completion > vhost: simplify getting the first in-flight index > vhost: prepare async for mbuf to desc refactoring > vhost: prepare sync for mbuf to desc refactoring > vhost: merge sync and async mbuf to desc filling > vhost: increase number of async IO vectors > > examples/vhost/ioat.c | 30 +- > examples/vhost/ioat.h | 4 +- > lib/vhost/rte_vhost_async.h | 42 +-- > lib/vhost/vhost.c | 130 +++---- > lib/vhost/vhost.h | 67 ++-- > lib/vhost/vhost_user.c | 4 +- > lib/vhost/virtio_net.c | 697 ++++++++++++++---------------------- > 7 files changed, 382 insertions(+), 592 deletions(-) > > -- > 2.31.1 Reviewed-by: Jiayu Hu <jiayu.hu@intel.com> for this serial.
On 10/26/21 18:28, Maxime Coquelin wrote: > This series aims at cleaning and simplifying the async > enqueue path. I think it makes the code easier to > understand, and is necessary before integrating new > changes. > > I may have more reworks to propose in next revisions, > but I wanted to share my current status early so that > you have time to review/test it. > > It is only compile-tested, as I don't have HW with IOAT > support to test it. > > Changes in v2: > ============== > - Print once when max number of iovec is reached (Jiayu) > - Increase number of IOVECs from 512 to 2048 (Jiayu) > - Fix Vhost example build when raw/ioat is disabled > > Changes in v1: > ============== > - Fix missing iovec index increment (Jiayu) > - Remove unneeded sanity check on IOV iter index (Jiayu) > - Fix async->pkts_info allocation check (Jiayu) > - Prevent NULL pointer dereference on async metadata cleanup (Jiayu) > > *** BLURB HERE *** > > Maxime Coquelin (15): > vhost: move async data in a dedicated structure > vhost: hide inflight async structure > vhost: simplify async IO vectors > vhost: simplify async IO vectors iterators > vhost: remove async batch threshold > vhost: introduce specific iovec structure > vhost: remove useless fields in async iterator struct > vhost: improve IO vector logic > vhost: remove notion of async descriptor > vhost: simplify async enqueue completion > vhost: simplify getting the first in-flight index > vhost: prepare async for mbuf to desc refactoring > vhost: prepare sync for mbuf to desc refactoring > vhost: merge sync and async mbuf to desc filling > vhost: increase number of async IO vectors > > examples/vhost/ioat.c | 30 +- > examples/vhost/ioat.h | 4 +- > lib/vhost/rte_vhost_async.h | 42 +-- > lib/vhost/vhost.c | 130 +++---- > lib/vhost/vhost.h | 67 ++-- > lib/vhost/vhost_user.c | 4 +- > lib/vhost/virtio_net.c | 697 ++++++++++++++---------------------- > 7 files changed, 382 insertions(+), 592 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime