mbox series

[00/10] vdpa/sfc: introduce Xilinx vDPA driver

Message ID 20210706164418.32615-1-vsrivast@xilinx.com (mailing list archive)
Headers
Series vdpa/sfc: introduce Xilinx vDPA driver |

Message

Vijay Srivastava July 6, 2021, 4:44 p.m. UTC 
  This patch series introduces vDPA driver for Xilinx devices.
The Xilinx vDPA (vhost data path acceleration) provides
support for the Xilinx SN1022 SmartNICs.

This Patch series includes following patches:

Vijay Kumar Srivastava (10):
  vdpa/sfc: introduce Xilinx vDPA driver
  vdpa/sfc: add support for device initialization
  vdpa/sfc: add support to get device and protocol features
  vdpa/sfc: get device supported max queue count
  vdpa/sfc: add support to get VFIO device fd
  vdpa/sfc: add support for dev conf and dev close ops
  vdpa/sfc: add support to get queue notify area info
  vdpa/sfc: add support for MAC filter config
  vdpa/sfc: add support to set vring state
  vdpa/sfc: set a multicast filter during vDPA init

 MAINTAINERS                            |   6 +
 doc/guides/rel_notes/release_21_08.rst |   5 +
 doc/guides/vdpadevs/features/sfc.ini   |  19 +
 doc/guides/vdpadevs/sfc.rst            | 107 ++++
 drivers/common/sfc_efx/efsys.h         |   2 +-
 drivers/common/sfc_efx/version.map     |  10 +
 drivers/vdpa/meson.build               |   1 +
 drivers/vdpa/sfc/meson.build           |  37 ++
 drivers/vdpa/sfc/sfc_vdpa.c            | 367 +++++++++++++
 drivers/vdpa/sfc/sfc_vdpa.h            | 163 ++++++
 drivers/vdpa/sfc/sfc_vdpa_debug.h      |  21 +
 drivers/vdpa/sfc/sfc_vdpa_filter.c     | 159 ++++++
 drivers/vdpa/sfc/sfc_vdpa_hw.c         | 415 +++++++++++++++
 drivers/vdpa/sfc/sfc_vdpa_log.h        |  80 +++
 drivers/vdpa/sfc/sfc_vdpa_mcdi.c       |  74 +++
 drivers/vdpa/sfc/sfc_vdpa_ops.c        | 942 +++++++++++++++++++++++++++++++++
 drivers/vdpa/sfc/sfc_vdpa_ops.h        |  69 +++
 drivers/vdpa/sfc/version.map           |   3 +
 18 files changed, 2479 insertions(+), 1 deletion(-)
 create mode 100644 doc/guides/vdpadevs/features/sfc.ini
 create mode 100644 doc/guides/vdpadevs/sfc.rst
 create mode 100644 drivers/vdpa/sfc/meson.build
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
 create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
 create mode 100644 drivers/vdpa/sfc/version.map

Comments

Chenbo Xia July 7, 2021, 8:30 a.m. UTC | #1 
Hi Vijay,

> -----Original Message-----
> From: Vijay Srivastava <vijay.srivastava@xilinx.com>
> Sent: Wednesday, July 7, 2021 12:44 AM
> To: dev@dpdk.org
> Cc: maxime.coquelin@redhat.com; Xia, Chenbo <chenbo.xia@intel.com>;
> andrew.rybchenko@oktetlabs.ru; Vijay Srivastava <vsrivast@xilinx.com>
> Subject: [PATCH 00/10] vdpa/sfc: introduce Xilinx vDPA driver
> 
> This patch series introduces vDPA driver for Xilinx devices.
> The Xilinx vDPA (vhost data path acceleration) provides
> support for the Xilinx SN1022 SmartNICs.
> 
> This Patch series includes following patches:
> 
> Vijay Kumar Srivastava (10):
>   vdpa/sfc: introduce Xilinx vDPA driver
>   vdpa/sfc: add support for device initialization
>   vdpa/sfc: add support to get device and protocol features
>   vdpa/sfc: get device supported max queue count
>   vdpa/sfc: add support to get VFIO device fd
>   vdpa/sfc: add support for dev conf and dev close ops
>   vdpa/sfc: add support to get queue notify area info
>   vdpa/sfc: add support for MAC filter config
>   vdpa/sfc: add support to set vring state
>   vdpa/sfc: set a multicast filter during vDPA init
> 

[...]

> 1.8.3.1

Did you register to mail-list? Your patch was not in mail list as the log says
you are not a member of it. And @Yigit, Ferruh helped you release the mails this
time. Please register to mail-list first if you have not, or there will be problems
when you reply/send new versions.

Thanks,
Chenbo
Andrew Rybchenko July 7, 2021, 11:09 a.m. UTC | #2 
On 7/6/21 7:44 PM, Vijay Srivastava wrote:
> This patch series introduces vDPA driver for Xilinx devices.
> The Xilinx vDPA (vhost data path acceleration) provides
> support for the Xilinx SN1022 SmartNICs.
> 
> This Patch series includes following patches:
> 
> Vijay Kumar Srivastava (10):
>   vdpa/sfc: introduce Xilinx vDPA driver
>   vdpa/sfc: add support for device initialization
>   vdpa/sfc: add support to get device and protocol features
>   vdpa/sfc: get device supported max queue count
>   vdpa/sfc: add support to get VFIO device fd
>   vdpa/sfc: add support for dev conf and dev close ops
>   vdpa/sfc: add support to get queue notify area info
>   vdpa/sfc: add support for MAC filter config
>   vdpa/sfc: add support to set vring state
>   vdpa/sfc: set a multicast filter during vDPA init

Series-acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Maxime Coquelin Oct. 27, 2021, 1:18 p.m. UTC | #3 
Hi Vijay,

-rc2 deadline is approaching, do you think v2 will be ready on time so
that we can have your driver in v21.11?

Thanks,
Maxime

On 7/6/21 18:44, Vijay Srivastava wrote:
> This patch series introduces vDPA driver for Xilinx devices.
> The Xilinx vDPA (vhost data path acceleration) provides
> support for the Xilinx SN1022 SmartNICs.
> 
> This Patch series includes following patches:
> 
> Vijay Kumar Srivastava (10):
>    vdpa/sfc: introduce Xilinx vDPA driver
>    vdpa/sfc: add support for device initialization
>    vdpa/sfc: add support to get device and protocol features
>    vdpa/sfc: get device supported max queue count
>    vdpa/sfc: add support to get VFIO device fd
>    vdpa/sfc: add support for dev conf and dev close ops
>    vdpa/sfc: add support to get queue notify area info
>    vdpa/sfc: add support for MAC filter config
>    vdpa/sfc: add support to set vring state
>    vdpa/sfc: set a multicast filter during vDPA init
> 
>   MAINTAINERS                            |   6 +
>   doc/guides/rel_notes/release_21_08.rst |   5 +
>   doc/guides/vdpadevs/features/sfc.ini   |  19 +
>   doc/guides/vdpadevs/sfc.rst            | 107 ++++
>   drivers/common/sfc_efx/efsys.h         |   2 +-
>   drivers/common/sfc_efx/version.map     |  10 +
>   drivers/vdpa/meson.build               |   1 +
>   drivers/vdpa/sfc/meson.build           |  37 ++
>   drivers/vdpa/sfc/sfc_vdpa.c            | 367 +++++++++++++
>   drivers/vdpa/sfc/sfc_vdpa.h            | 163 ++++++
>   drivers/vdpa/sfc/sfc_vdpa_debug.h      |  21 +
>   drivers/vdpa/sfc/sfc_vdpa_filter.c     | 159 ++++++
>   drivers/vdpa/sfc/sfc_vdpa_hw.c         | 415 +++++++++++++++
>   drivers/vdpa/sfc/sfc_vdpa_log.h        |  80 +++
>   drivers/vdpa/sfc/sfc_vdpa_mcdi.c       |  74 +++
>   drivers/vdpa/sfc/sfc_vdpa_ops.c        | 942 +++++++++++++++++++++++++++++++++
>   drivers/vdpa/sfc/sfc_vdpa_ops.h        |  69 +++
>   drivers/vdpa/sfc/version.map           |   3 +
>   18 files changed, 2479 insertions(+), 1 deletion(-)
>   create mode 100644 doc/guides/vdpadevs/features/sfc.ini
>   create mode 100644 doc/guides/vdpadevs/sfc.rst
>   create mode 100644 drivers/vdpa/sfc/meson.build
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
>   create mode 100644 drivers/vdpa/sfc/version.map
>
Andrew Rybchenko Oct. 27, 2021, 3:04 p.m. UTC | #4 
Hi Maxime,

On 10/27/21 4:18 PM, Maxime Coquelin wrote:
> Hi Vijay,
> 
> -rc2 deadline is approaching, do you think v2 will be ready on time so
> that we can have your driver in v21.11?

Vijay is working on a it. We have v2, but it does not work after rebase
on rc1. Hopefully Vijay will sort it out shortly.

Thanks,
Andrew.

> 
> Thanks,
> Maxime
> 
> On 7/6/21 18:44, Vijay Srivastava wrote:
>> This patch series introduces vDPA driver for Xilinx devices.
>> The Xilinx vDPA (vhost data path acceleration) provides
>> support for the Xilinx SN1022 SmartNICs.
>>
>> This Patch series includes following patches:
>>
>> Vijay Kumar Srivastava (10):
>>    vdpa/sfc: introduce Xilinx vDPA driver
>>    vdpa/sfc: add support for device initialization
>>    vdpa/sfc: add support to get device and protocol features
>>    vdpa/sfc: get device supported max queue count
>>    vdpa/sfc: add support to get VFIO device fd
>>    vdpa/sfc: add support for dev conf and dev close ops
>>    vdpa/sfc: add support to get queue notify area info
>>    vdpa/sfc: add support for MAC filter config
>>    vdpa/sfc: add support to set vring state
>>    vdpa/sfc: set a multicast filter during vDPA init
>>
>>   MAINTAINERS                            |   6 +
>>   doc/guides/rel_notes/release_21_08.rst |   5 +
>>   doc/guides/vdpadevs/features/sfc.ini   |  19 +
>>   doc/guides/vdpadevs/sfc.rst            | 107 ++++
>>   drivers/common/sfc_efx/efsys.h         |   2 +-
>>   drivers/common/sfc_efx/version.map     |  10 +
>>   drivers/vdpa/meson.build               |   1 +
>>   drivers/vdpa/sfc/meson.build           |  37 ++
>>   drivers/vdpa/sfc/sfc_vdpa.c            | 367 +++++++++++++
>>   drivers/vdpa/sfc/sfc_vdpa.h            | 163 ++++++
>>   drivers/vdpa/sfc/sfc_vdpa_debug.h      |  21 +
>>   drivers/vdpa/sfc/sfc_vdpa_filter.c     | 159 ++++++
>>   drivers/vdpa/sfc/sfc_vdpa_hw.c         | 415 +++++++++++++++
>>   drivers/vdpa/sfc/sfc_vdpa_log.h        |  80 +++
>>   drivers/vdpa/sfc/sfc_vdpa_mcdi.c       |  74 +++
>>   drivers/vdpa/sfc/sfc_vdpa_ops.c        | 942 
>> +++++++++++++++++++++++++++++++++
>>   drivers/vdpa/sfc/sfc_vdpa_ops.h        |  69 +++
>>   drivers/vdpa/sfc/version.map           |   3 +
>>   18 files changed, 2479 insertions(+), 1 deletion(-)
>>   create mode 100644 doc/guides/vdpadevs/features/sfc.ini
>>   create mode 100644 doc/guides/vdpadevs/sfc.rst
>>   create mode 100644 drivers/vdpa/sfc/meson.build
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
>>   create mode 100644 drivers/vdpa/sfc/version.map
>>
Maxime Coquelin Oct. 27, 2021, 7:56 p.m. UTC | #5 
Hi Andrew,

On 10/27/21 17:04, Andrew Rybchenko wrote:
> Hi Maxime,
> 
> On 10/27/21 4:18 PM, Maxime Coquelin wrote:
>> Hi Vijay,
>>
>> -rc2 deadline is approaching, do you think v2 will be ready on time so
>> that we can have your driver in v21.11?
> 
> Vijay is working on a it. We have v2, but it does not work after rebase
> on rc1. Hopefully Vijay will sort it out shortly.

Thanks for the update.

In case you are still stuck with this regression tomorrow end of day,
feel free to send it anyway mentioning it is not working, so that we can
have time for a v3 if necessary.

Maxime

> Thanks,
> Andrew.
> 
>>
>> Thanks,
>> Maxime
>>
>> On 7/6/21 18:44, Vijay Srivastava wrote:
>>> This patch series introduces vDPA driver for Xilinx devices.
>>> The Xilinx vDPA (vhost data path acceleration) provides
>>> support for the Xilinx SN1022 SmartNICs.
>>>
>>> This Patch series includes following patches:
>>>
>>> Vijay Kumar Srivastava (10):
>>>    vdpa/sfc: introduce Xilinx vDPA driver
>>>    vdpa/sfc: add support for device initialization
>>>    vdpa/sfc: add support to get device and protocol features
>>>    vdpa/sfc: get device supported max queue count
>>>    vdpa/sfc: add support to get VFIO device fd
>>>    vdpa/sfc: add support for dev conf and dev close ops
>>>    vdpa/sfc: add support to get queue notify area info
>>>    vdpa/sfc: add support for MAC filter config
>>>    vdpa/sfc: add support to set vring state
>>>    vdpa/sfc: set a multicast filter during vDPA init
>>>
>>>   MAINTAINERS                            |   6 +
>>>   doc/guides/rel_notes/release_21_08.rst |   5 +
>>>   doc/guides/vdpadevs/features/sfc.ini   |  19 +
>>>   doc/guides/vdpadevs/sfc.rst            | 107 ++++
>>>   drivers/common/sfc_efx/efsys.h         |   2 +-
>>>   drivers/common/sfc_efx/version.map     |  10 +
>>>   drivers/vdpa/meson.build               |   1 +
>>>   drivers/vdpa/sfc/meson.build           |  37 ++
>>>   drivers/vdpa/sfc/sfc_vdpa.c            | 367 +++++++++++++
>>>   drivers/vdpa/sfc/sfc_vdpa.h            | 163 ++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_debug.h      |  21 +
>>>   drivers/vdpa/sfc/sfc_vdpa_filter.c     | 159 ++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_hw.c         | 415 +++++++++++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_log.h        |  80 +++
>>>   drivers/vdpa/sfc/sfc_vdpa_mcdi.c       |  74 +++
>>>   drivers/vdpa/sfc/sfc_vdpa_ops.c        | 942 
>>> +++++++++++++++++++++++++++++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_ops.h        |  69 +++
>>>   drivers/vdpa/sfc/version.map           |   3 +
>>>   18 files changed, 2479 insertions(+), 1 deletion(-)
>>>   create mode 100644 doc/guides/vdpadevs/features/sfc.ini
>>>   create mode 100644 doc/guides/vdpadevs/sfc.rst
>>>   create mode 100644 drivers/vdpa/sfc/meson.build
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
>>>   create mode 100644 drivers/vdpa/sfc/version.map
>>>
>
Vijay Kumar Srivastava Oct. 28, 2021, 6:01 p.m. UTC | #6 
HI Maxime, 

With the rc1 code base, an issue https://bugs.dpdk.org/show_bug.cgi?id=862 was observed. 
Due to this vDPA app was not working properly. After fixing this issue (Fix needs to be submitted)
vDPA app is working fine with the this patch series.

Regards,
Vijay

>-----Original Message-----
>From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>Sent: Wednesday, October 27, 2021 8:35 PM
>To: Maxime Coquelin <maxime.coquelin@redhat.com>; Vijay Kumar Srivastava
><vsrivast@xilinx.com>; dev@dpdk.org
>Cc: chenbo.xia@intel.com; Vijay Kumar Srivastava <vsrivast@xilinx.com>
>Subject: Re: [PATCH 00/10] vdpa/sfc: introduce Xilinx vDPA driver
>
>Hi Maxime,
>
>On 10/27/21 4:18 PM, Maxime Coquelin wrote:
>> Hi Vijay,
>>
>> -rc2 deadline is approaching, do you think v2 will be ready on time so
>> that we can have your driver in v21.11?
>
>Vijay is working on a it. We have v2, but it does not work after rebase on rc1.
>Hopefully Vijay will sort it out shortly.
>
>Thanks,
>Andrew.
>
>>
>> Thanks,
>> Maxime
>>
>> On 7/6/21 18:44, Vijay Srivastava wrote:
>>> This patch series introduces vDPA driver for Xilinx devices.
>>> The Xilinx vDPA (vhost data path acceleration) provides support for
>>> the Xilinx SN1022 SmartNICs.
>>>
>>> This Patch series includes following patches:
>>>
>>> Vijay Kumar Srivastava (10):
>>>    vdpa/sfc: introduce Xilinx vDPA driver
>>>    vdpa/sfc: add support for device initialization
>>>    vdpa/sfc: add support to get device and protocol features
>>>    vdpa/sfc: get device supported max queue count
>>>    vdpa/sfc: add support to get VFIO device fd
>>>    vdpa/sfc: add support for dev conf and dev close ops
>>>    vdpa/sfc: add support to get queue notify area info
>>>    vdpa/sfc: add support for MAC filter config
>>>    vdpa/sfc: add support to set vring state
>>>    vdpa/sfc: set a multicast filter during vDPA init
>>>
>>>   MAINTAINERS                            |   6 +
>>>   doc/guides/rel_notes/release_21_08.rst |   5 +
>>>   doc/guides/vdpadevs/features/sfc.ini   |  19 +
>>>   doc/guides/vdpadevs/sfc.rst            | 107 ++++
>>>   drivers/common/sfc_efx/efsys.h         |   2 +-
>>>   drivers/common/sfc_efx/version.map     |  10 +
>>>   drivers/vdpa/meson.build               |   1 +
>>>   drivers/vdpa/sfc/meson.build           |  37 ++
>>>   drivers/vdpa/sfc/sfc_vdpa.c            | 367 +++++++++++++
>>>   drivers/vdpa/sfc/sfc_vdpa.h            | 163 ++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_debug.h      |  21 +
>>>   drivers/vdpa/sfc/sfc_vdpa_filter.c     | 159 ++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_hw.c         | 415 +++++++++++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_log.h        |  80 +++
>>>   drivers/vdpa/sfc/sfc_vdpa_mcdi.c       |  74 +++
>>>   drivers/vdpa/sfc/sfc_vdpa_ops.c        | 942
>>> +++++++++++++++++++++++++++++++++
>>>   drivers/vdpa/sfc/sfc_vdpa_ops.h        |  69 +++
>>>   drivers/vdpa/sfc/version.map           |   3 +
>>>   18 files changed, 2479 insertions(+), 1 deletion(-)
>>>   create mode 100644 doc/guides/vdpadevs/features/sfc.ini
>>>   create mode 100644 doc/guides/vdpadevs/sfc.rst
>>>   create mode 100644 drivers/vdpa/sfc/meson.build
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa.h
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_debug.h
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_filter.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_hw.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_log.h
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_mcdi.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.c
>>>   create mode 100644 drivers/vdpa/sfc/sfc_vdpa_ops.h
>>>   create mode 100644 drivers/vdpa/sfc/version.map
>>>