[v6] telemetry: remove limitation on JSON output buffer length
Checks
Commit Message
Earlier, JSON message length was limited to 1024 which would not
allow data more than this size. Removed this limitation by creating
output buffer based on requested data length.
Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")
Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
---
v6:
- rephrased the commit header and message.
---
lib/telemetry/telemetry_json.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
Comments
>-----Original Message-----
>From: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
>Sent: Monday 11 October 2021 11:55
>To: dev@dpdk.org
>Cc: Richardson, Bruce <bruce.richardson@intel.com>; Power, Ciara
><ciara.power@intel.com>; jerinj@marvell.com; Gowrishankar Muthukrishnan
><gmuthukrishn@marvell.com>
>Subject: [v6] telemetry: remove limitation on JSON output buffer length
>
>Earlier, JSON message length was limited to 1024 which would not allow data
>more than this size. Removed this limitation by creating output buffer based
>on requested data length.
>
>Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")
>
>Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
>---
<snip>
Thanks,
Acked-by: Ciara Power <ciara.power@intel.com>
> >Earlier, JSON message length was limited to 1024 which would not allow data
> >more than this size. Removed this limitation by creating output buffer based
> >on requested data length.
> >
> >Fixes: 52af6ccb2b39 ("telemetry: add utility functions for creating JSON")
> >
> >Signed-off-by: Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
> >---
> <snip>
>
> Thanks,
>
> Acked-by: Ciara Power <ciara.power@intel.com>
Applied, thanks.
@@ -9,6 +9,7 @@
#include <stdarg.h>
#include <stdio.h>
#include <rte_common.h>
+#include <rte_telemetry.h>
/**
* @file
@@ -23,13 +24,13 @@
* @internal
* Copies a value into a buffer if the buffer has enough available space.
* Nothing written to buffer if an overflow ocurs.
- * This function is not for use for values larger than 1k.
+ * This function is not for use for values larger than given buffer length.
*/
__rte_format_printf(3, 4)
static inline int
__json_snprintf(char *buf, const int len, const char *format, ...)
{
- char tmp[1024];
+ char tmp[len];
va_list ap;
int ret;