net: promote ip6 external headers skip API as stable

Message ID 20210924130110.14279-1-olivier.matz@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series net: promote ip6 external headers skip API as stable |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-testing warning apply patch failure

Commit Message

Olivier Matz Sept. 24, 2021, 1:01 p.m. UTC
  This function is public since commit 8f0e4d6a78a5 ("net: export IPv6
header extensions skip function") (2018), and is used by vmxnet3 driver.
Promote it as stable.

Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
---
 lib/net/rte_net.h   | 4 ----
 lib/net/version.map | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)
  

Comments

David Marchand Oct. 2, 2021, 9:40 a.m. UTC | #1
On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> This function is public since commit 8f0e4d6a78a5 ("net: export IPv6
> header extensions skip function") (2018), and is used by vmxnet3 driver.
> Promote it as stable.
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

Acked-by: David Marchand <david.marchand@redhat.com>
  
Ray Kinsella Oct. 7, 2021, 4:25 p.m. UTC | #2
On 02/10/2021 10:40, David Marchand wrote:
> On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz <olivier.matz@6wind.com> wrote:
>>
>> This function is public since commit 8f0e4d6a78a5 ("net: export IPv6
>> header extensions skip function") (2018), and is used by vmxnet3 driver.
>> Promote it as stable.
>>
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> 
> Acked-by: David Marchand <david.marchand@redhat.com>
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>
  
Thomas Monjalon Oct. 13, 2021, 10:57 a.m. UTC | #3
07/10/2021 18:25, Kinsella, Ray:
> 
> On 02/10/2021 10:40, David Marchand wrote:
> > On Fri, Sep 24, 2021 at 3:02 PM Olivier Matz <olivier.matz@6wind.com> wrote:
> >>
> >> This function is public since commit 8f0e4d6a78a5 ("net: export IPv6
> >> header extensions skip function") (2018), and is used by vmxnet3 driver.
> >> Promote it as stable.
> >>
> >> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> > Acked-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Rebased and applied, thanks.
It was the last experimental symbol in librte_net,
so I completely removed the EXPERIMENTAL block from the .map file.
  

Patch

diff --git a/lib/net/rte_net.h b/lib/net/rte_net.h
index 42639bc154..f4460202c0 100644
--- a/lib/net/rte_net.h
+++ b/lib/net/rte_net.h
@@ -34,9 +34,6 @@  struct rte_net_hdr_lens {
  * This function skips all IPv6 extensions, returning size of
  * complete header including options and final protocol value.
  *
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * @param proto
  *   Protocol field of IPv6 header.
  * @param m
@@ -51,7 +48,6 @@  struct rte_net_hdr_lens {
  *   Protocol that follows IPv6 header.
  *   -1 if an error occurs during mbuf parsing.
  */
-__rte_experimental
 int
 rte_net_skip_ip6_ext(uint16_t proto, const struct rte_mbuf *m, uint32_t *off,
 	int *frag);
diff --git a/lib/net/version.map b/lib/net/version.map
index 355b7c25b4..a8a2ecf870 100644
--- a/lib/net/version.map
+++ b/lib/net/version.map
@@ -6,6 +6,7 @@  DPDK_22 {
 	rte_net_crc_calc;
 	rte_net_crc_set_alg;
 	rte_net_get_ptype;
+	rte_net_skip_ip6_ext;
 
 	local: *;
 };
@@ -14,6 +15,5 @@  EXPERIMENTAL {
 	global:
 
 	rte_net_make_rarp_packet;
-	rte_net_skip_ip6_ext;
 	rte_ether_unformat_addr;
 };