diff mbox series

app/test: enable crypto unit tests on Windows

Message ID 20210915171649.20200-1-talshn@nvidia.com (mailing list archive)
State Not Applicable, archived
Delegated to: Thomas Monjalon
Headers
Series app/test: enable crypto unit tests on Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-testing warning apply patch failure
ci/Intel-compilation warning apply issues

Commit Message

Tal Shnaiderman Sept. 15, 2021, 5:16 p.m. UTC 
  Enable cryptography unit tests on Windows supported crypto PMDs.

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
---
Depends-on: series-18674 ("app/test: enable subset of tests on Windows")
Depends-on: patch-98942 ("security: build on Windows")
---
 app/test/meson.build | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

Comments

Akhil Goyal Oct. 5, 2021, 1:52 p.m. UTC | #1 
> Enable cryptography unit tests on Windows supported crypto PMDs.
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> ---
> Depends-on: series-18674 ("app/test: enable subset of tests on Windows")
> Depends-on: patch-98942 ("security: build on Windows")
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>

Delegating this patch to Thomas, as dependent series are delegated to Thomas as well.
Thomas Monjalon Feb. 8, 2022, 1:33 p.m. UTC | #2 
05/10/2021 15:52, Akhil Goyal:
> > Enable cryptography unit tests on Windows supported crypto PMDs.
> > 
> > Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> > ---
> > Depends-on: series-18674 ("app/test: enable subset of tests on Windows")
> > Depends-on: patch-98942 ("security: build on Windows")
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> Delegating this patch to Thomas, as dependent series are delegated to Thomas as well.

The dependencies are merged but I am not sure something is required
to enable crypto unit tests on Windows.
Please check what was done during the latest reworks.
diff mbox series

Patch

diff --git a/app/test/meson.build b/app/test/meson.build
index 108995db21..47df72d788 100644
--- a/app/test/meson.build
+++ b/app/test/meson.build
@@ -22,6 +22,10 @@  test_sources = files(
         'test_cmdline_num.c',
         'test_cmdline_portlist.c',
         'test_cmdline_string.c',
+        'test_cryptodev.c',
+        'test_cryptodev_asym.c',
+        'test_cryptodev_blockcipher.c',
+        'test_cryptodev_security_pdcp.c',
         'test_common.c',
         'test_cpuflags.c',
         'test_crc.c',
@@ -92,6 +96,7 @@  test_deps = [
         'bitratestats',
         'cfgfile',
         'cmdline',
+        'cryptodev',
         'efd',
         'ethdev',
         'hash',
@@ -105,6 +110,7 @@  test_deps = [
         'stack',
         'telemetry',
         'timer',
+        'security',
 ]
 
 # Each test is marked with flag true/false
@@ -183,10 +189,6 @@  if not is_windows
             'test_bpf.c',
             'test_cksum.c',
             'test_cmdline_ipaddr.c',
-            'test_cryptodev.c',
-            'test_cryptodev_asym.c',
-            'test_cryptodev_blockcipher.c',
-            'test_cryptodev_security_pdcp.c',
             'test_debug.c',
             'test_distributor.c',
             'test_distributor_perf.c',
@@ -244,7 +246,6 @@  if not is_windows
     test_deps += [
             'acl',
             'bpf',
-            'cryptodev',
             'distributor',
             'eventdev',
             'fib',
@@ -256,7 +257,6 @@  if not is_windows
             'pipeline',
             'port',
             'rawdev',
-            'security',
     ]
 
     fast_tests += [