diff mbox series

[V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps

Message ID 20210805182314.18713-1-zhiminx.huang@intel.com (mailing list archive)
State Accepted
Headers
Series [V2] tests/cvl_advanced_rss_pppoe:remove destroy rule test steps |

Checks

Context Check Description
ci/Intel-dts-test success Testing OK

Commit Message

Huang, ZhiminX Aug. 5, 2021, 6:23 p.m. UTC 
  *.dpdk cannot guarantee the operation after destroy the rule,
so remove destroy rule test steps.

Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>
---
v2:fix typo issue

 .../cvl_advanced_rss_pppoe_test_plan.rst      | 16 ---------------
 tests/TestSuite_cvl_advanced_rss_pppoe.py     | 20 -------------------
 2 files changed, 36 deletions(-)

Comments

Huang, ZhiminX Aug. 5, 2021, 9:55 a.m. UTC | #1 
> -----Original Message-----
> From: Huang, ZhiminX <zhiminx.huang@intel.com>
> Sent: Friday, August 6, 2021 2:23 AM
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> rule test steps
> 

Tested-by: Zhimin Huang <zhiminx.huang@intel.com >
Tu, Lijuan Aug. 10, 2021, 5:55 a.m. UTC | #2 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Zhimin Huang
> Sent: 2021年8月6日 2:23
> To: dts@dpdk.org
> Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy rule
> test steps
> 
> *.dpdk cannot guarantee the operation after destroy the rule, so remove
> destroy rule test steps.
> 
> Signed-off-by: Zhimin Huang <zhiminx.huang@intel.com>

I think because of the reason, multiple cases/suites/plans should be changed accordingly.
It is strongly requested to include them in the same patch series.

thanks
Tu, Lijuan Sept. 29, 2021, 6:53 a.m. UTC | #3 
> -----Original Message-----
> From: dts <dts-bounces@dpdk.org> On Behalf Of Huang, ZhiminX
> Sent: 2021年8月5日 17:56
> To: dts@dpdk.org
> Subject: Re: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> rule test steps
> 
> 
> > -----Original Message-----
> > From: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Sent: Friday, August 6, 2021 2:23 AM
> > To: dts@dpdk.org
> > Cc: Huang, ZhiminX <zhiminx.huang@intel.com>
> > Subject: [dts] [PATCH V2] tests/cvl_advanced_rss_pppoe:remove destroy
> > rule test steps
> >
> 
> Tested-by: Zhimin Huang <zhiminx.huang@intel.com >

Applied
diff mbox series

Patch

diff --git a/test_plans/cvl_advanced_rss_pppoe_test_plan.rst b/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
index a8cb7171..e209e0d4 100644
--- a/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
+++ b/test_plans/cvl_advanced_rss_pppoe_test_plan.rst
@@ -4278,14 +4278,6 @@  Test case: MAC_PPPOE_IPV4_UDP_PAY_symmetric
 
      check the hash values of the two packets are different.
 
-6. destroy the rule::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   check the rule not exists in the list.
-   repeat step 4, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
-   check the hash value is changed.
 
 Test case: MAC_PPPOE_IPV4_TCP_PAY_symmetric
 ===========================================
@@ -4540,14 +4532,6 @@  Test case: MAC_PPPOE_IPV6_UDP_PAY_symmetric
 
      check the hash values of the two packets are different.
 
-6. destroy the rule::
-
-     testpmd> flow destroy 0 rule 0
-     testpmd> flow list 0
-
-   check the rule not exists in the list.
-   repeat step 3, swap the values of [Source IP] and [Dest IP], [Source Port] and [Dest Port],
-   check the hash values are changed.
 
 Test case: MAC_PPPOE_IPV6_TCP_PAY_symmetric
 ===========================================
diff --git a/tests/TestSuite_cvl_advanced_rss_pppoe.py b/tests/TestSuite_cvl_advanced_rss_pppoe.py
index 2d3e226e..3952bbf0 100644
--- a/tests/TestSuite_cvl_advanced_rss_pppoe.py
+++ b/tests/TestSuite_cvl_advanced_rss_pppoe.py
@@ -3780,16 +3780,6 @@  mac_pppoe_ipv6_udp_pay_symmetric = {
             'action': {'check_hash_different': 'mac_ipv6_udp_pay_mismatch'},
         },
     ],
-    'post-test': [
-        {
-            'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][0],
-            'action': {'save_hash': 'mac_pppoe_ipv6_udp_pay_match_post'},
-        },
-        {
-            'send_packet': mac_pppoe_ipv6_udp_pay_symmetric_packets['match']['mac_pppoe_ipv6_udp_pay'][1:],
-            'action': {'check_hash_different': 'mac_pppoe_ipv6_udp_pay_match_post'},
-        },
-    ],
 }
 
 mac_pppoe_ipv6_pay_symmetric_packets = {
@@ -4063,16 +4053,6 @@  mac_pppoe_ipv4_udp_pay_symmetric = {
             'action': {'check_hash_different': 'mac_ipv4_udp_pay_mismatch'},
         },
     ],
-    'post-test': [
-        {
-            'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][0],
-            'action': {'save_hash': 'mac_ipv4_udp_pay_match_post'},
-        },
-        {
-            'send_packet': mac_pppoe_ipv4_udp_pay_symmetric_packets['match']['mac_pppoe_ipv4_udp_pay'][1:],
-            'action': {'check_hash_different': 'mac_ipv4_udp_pay_match_post'},
-        },
-    ],
 }
 
 mac_pppoe_ipv4_tcp_pay_symmetric_packets = {