[v1] windows/netuio: add Intel 82599 10GbE VF device ID

Message ID 20210922211922.227-1-u9012063@gmail.com (mailing list archive)
State Changes Requested, archived
Delegated to: Thomas Monjalon
Headers
Series [v1] windows/netuio: add Intel 82599 10GbE VF device ID |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation warning apply issues
ci/iol-testing warning apply patch failure

Commit Message

William Tu Sept. 22, 2021, 9:19 p.m. UTC
  Add Intel 82599 10GbE Ethernet adapter VF device IDs to
netuio inf file in order to enable them on Windows.

Signed-off-by: William Tu <u9012063@gmail.com>
---
 windows/netuio/netuio.inf | 2 ++
 1 file changed, 2 insertions(+)
  

Comments

Kadam, Pallavi Sept. 24, 2021, 10:24 p.m. UTC | #1
Hi William,

On 9/22/2021 2:19 PM, William Tu wrote:
> Add Intel 82599 10GbE Ethernet adapter VF device IDs to
> netuio inf file in order to enable them on Windows.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
>   windows/netuio/netuio.inf | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index d166868..6b45ab0 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -43,6 +43,7 @@ HKR,,Icon,,-5
>   %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
>   %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
>   %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> +%Intel.F10ED.Description%=netuio_Device, PCI\VEN_8086&DEV_10ED
>   %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
>   %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
>   %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
> @@ -108,6 +109,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
>   Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
>   Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
>   Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
> +Intel.F10ED.Description = "Intel(R) Ethernet Controller 82599 10GbE Virtual Function"

As per NDIS INF, please use following string:"Intel(R) 82599 Virtual Function"This is decided by marketing team and 
cannot be changed.

>   Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
>   Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
>   Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"
  
William Tu Sept. 25, 2021, 1:42 p.m. UTC | #2
On Fri, Sep 24, 2021 at 3:24 PM Kadam, Pallavi <pallavi.kadam@intel.com> wrote:
>
> Hi William,
>
> On 9/22/2021 2:19 PM, William Tu wrote:
>
> Add Intel 82599 10GbE Ethernet adapter VF device IDs to
> netuio inf file in order to enable them on Windows.
>
> Signed-off-by: William Tu <u9012063@gmail.com>
> ---
>  windows/netuio/netuio.inf | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
> index d166868..6b45ab0 100644
> --- a/windows/netuio/netuio.inf
> +++ b/windows/netuio/netuio.inf
> @@ -43,6 +43,7 @@ HKR,,Icon,,-5
>  %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
>  %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
>  %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
> +%Intel.F10ED.Description%=netuio_Device, PCI\VEN_8086&DEV_10ED
>  %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
>  %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
>  %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
> @@ -108,6 +109,7 @@ Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
>  Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
>  Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
>  Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
> +Intel.F10ED.Description = "Intel(R) Ethernet Controller 82599 10GbE Virtual Function"
>
> As per NDIS INF, please use following string:
> "Intel(R) 82599 Virtual Function"
> This is decided by marketing team and cannot be changed.
>
Thank you, I will send v2 and use the above string.
William
  

Patch

diff --git a/windows/netuio/netuio.inf b/windows/netuio/netuio.inf
index d166868..6b45ab0 100644
--- a/windows/netuio/netuio.inf
+++ b/windows/netuio/netuio.inf
@@ -43,6 +43,7 @@  HKR,,Icon,,-5
 %Intel.F101F.Description%=netuio_Device, PCI\VEN_8086&DEV_101F
 %Intel.F104F.Description%=netuio_Device, PCI\VEN_8086&DEV_104F
 %Intel.F104E.Description%=netuio_Device, PCI\VEN_8086&DEV_104E
+%Intel.F10ED.Description%=netuio_Device, PCI\VEN_8086&DEV_10ED
 %Intel.F1591.Description%=netuio_Device, PCI\VEN_8086&DEV_1591
 %Intel.F1592.Description%=netuio_Device, PCI\VEN_8086&DEV_1592
 %Intel.F1593.Description%=netuio_Device, PCI\VEN_8086&DEV_1593
@@ -108,6 +109,7 @@  Intel.F15FF.Description = "Intel(R) Ethernet Controller X710 for 10GBASE-T"
 Intel.F101F.Description = "Intel(R) Ethernet Controller V710 for 5GBASE-T"
 Intel.F104F.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit backplane"
 Intel.F104E.Description = "Intel(R) Ethernet Controller X710 for 10 Gigabit SFP+"
+Intel.F10ED.Description = "Intel(R) Ethernet Controller 82599 10GbE Virtual Function"
 Intel.F1591.Description = "Intel(R) Ethernet Controller E810-C for backplane"
 Intel.F1592.Description = "Intel(R) Ethernet Controller E810-C for QSFP"
 Intel.F1593.Description = "Intel(R) Ethernet Controller E810-C for SFP"