diff mbox series

lib: remove sched.h from public headers

Message ID 20210828221345.276048-1-dmitry.kozliuk@gmail.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series lib: remove sched.h from public headers |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-aarch64-unit-testing fail Testing issues
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Dmitry Kozlyuk Aug. 28, 2021, 10:13 p.m. UTC 
  Public headers including POSIX-specific <sched.h> were unusable
on Windows. These includes were superfluous, remove them.

Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
---
 lib/eal/include/rte_eal.h     | 1 -
 lib/telemetry/rte_telemetry.h | 1 -
 2 files changed, 2 deletions(-)

Comments

William Tu Sept. 23, 2021, 10:34 p.m. UTC | #1 
On Sat, Aug 28, 2021 at 3:13 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
>
> Public headers including POSIX-specific <sched.h> were unusable
> on Windows. These includes were superfluous, remove them.
>
> Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> ---

Write a program, include rte_eal.h, link with DPDK library, then
hit the issue. Verify the patch works correctly and solve my problem.

Acked-by: William Tu <u9012063@gmail.com>
Thomas Monjalon Oct. 1, 2021, 6:36 a.m. UTC | #2 
24/09/2021 00:34, William Tu:
> On Sat, Aug 28, 2021 at 3:13 PM Dmitry Kozlyuk <dmitry.kozliuk@gmail.com> wrote:
> >
> > Public headers including POSIX-specific <sched.h> were unusable
> > on Windows. These includes were superfluous, remove them.
> >
> > Signed-off-by: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>
> > ---
> 
> Write a program, include rte_eal.h, link with DPDK library, then
> hit the issue. Verify the patch works correctly and solve my problem.
> 
> Acked-by: William Tu <u9012063@gmail.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/lib/eal/include/rte_eal.h b/lib/eal/include/rte_eal.h
index eaf6469e50..0c43a0a2c1 100644
--- a/lib/eal/include/rte_eal.h
+++ b/lib/eal/include/rte_eal.h
@@ -12,7 +12,6 @@ 
  */
 
 #include <stdint.h>
-#include <sched.h>
 #include <time.h>
 
 #include <rte_config.h>
diff --git a/lib/telemetry/rte_telemetry.h b/lib/telemetry/rte_telemetry.h
index 8776998b54..1cdc903f38 100644
--- a/lib/telemetry/rte_telemetry.h
+++ b/lib/telemetry/rte_telemetry.h
@@ -3,7 +3,6 @@ 
  */
 
 #include <stdint.h>
-#include <sched.h>
 
 #include <rte_compat.h>