metrics: promote metrics deinitialize API

Message ID 20210903130803.103371-1-hkalra@marvell.com (mailing list archive)
State Accepted, archived
Headers
Series metrics: promote metrics deinitialize API |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-aarch64-compile-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-x86_64-compile-testing success Testing PASS

Commit Message

Harman Kalra Sept. 3, 2021, 1:08 p.m. UTC
  Remove experimental flag from rte_metrics_deinit().
This API was introduced in 19.11 release.

Signed-off-by: Harman Kalra <hkalra@marvell.com>
---
 lib/metrics/rte_metrics.h | 4 ----
 lib/metrics/version.map   | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)
  

Comments

Ray Kinsella Sept. 3, 2021, 1:09 p.m. UTC | #1
On 03/09/2021 14:08, Harman Kalra wrote:
> Remove experimental flag from rte_metrics_deinit().
> This API was introduced in 19.11 release.
> 
> Signed-off-by: Harman Kalra <hkalra@marvell.com>
> ---
>  lib/metrics/rte_metrics.h | 4 ----
>  lib/metrics/version.map   | 2 +-
>  2 files changed, 1 insertion(+), 5 deletions(-)
> 

Acked-by: Ray Kinsella <mdr@ashroe.eu>
  
Thomas Monjalon Sept. 23, 2021, 5:24 p.m. UTC | #2
03/09/2021 15:09, Kinsella, Ray:
> 
> On 03/09/2021 14:08, Harman Kalra wrote:
> > Remove experimental flag from rte_metrics_deinit().
> > This API was introduced in 19.11 release.
> > 
> > Signed-off-by: Harman Kalra <hkalra@marvell.com>
> 
> Acked-by: Ray Kinsella <mdr@ashroe.eu>

Sorted function in .map in alphabetical order,
applied, thanks.
  

Patch

diff --git a/lib/metrics/rte_metrics.h b/lib/metrics/rte_metrics.h
index fbe64ddf2b..c2815a252c 100644
--- a/lib/metrics/rte_metrics.h
+++ b/lib/metrics/rte_metrics.h
@@ -83,9 +83,6 @@  struct rte_metric_value {
 void rte_metrics_init(int socket_id);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
- *
  * Deinitialize metric module. This function must be called from
  * a primary process after all the metrics usage is over, to
  *  release the shared memory.
@@ -96,7 +93,6 @@  void rte_metrics_init(int socket_id);
  *    (rte_metrics_init() not called)
  *  0 - success
  */
-__rte_experimental
 int rte_metrics_deinit(void);
 
 /**
diff --git a/lib/metrics/version.map b/lib/metrics/version.map
index c86e405971..03bfdff569 100644
--- a/lib/metrics/version.map
+++ b/lib/metrics/version.map
@@ -8,6 +8,7 @@  DPDK_22 {
 	rte_metrics_reg_names;
 	rte_metrics_update_value;
 	rte_metrics_update_values;
+	rte_metrics_deinit;
 
 	local: *;
 };
@@ -15,7 +16,6 @@  DPDK_22 {
 EXPERIMENTAL {
 	global:
 
-	rte_metrics_deinit;
 	rte_metrics_tel_encode_json_format;
 	rte_metrics_tel_reg_all_ethdev;
 	rte_metrics_tel_get_global_stats;