examples/performance-thread: fix build issue with clang 12.0.1
Checks
Commit Message
From: Jerin Jacob <jerinj@marvell.com>
In clang 12.0.1 version, the use of pthread_yield() deprecated,
use sched_yield() instead.
log:
Compiling C object
examples/dpdk-pthread_shim.p/performance-thread_pthread_shim_main.c.o
../examples/performance-thread/pthread_shim/main.c: In function
'helloworld_pthread':
../examples/performance-thread/pthread_shim/main.c:75:9: warning:
'pthread_yield' is deprecated: pthread_yield is deprecated, use
sched_yield instead [-Wdeprecated-declarations]
Fixes: 433ba6228f9a ("examples/performance-thread: add pthread_shim app")
Bugzilla ID: 745
Cc: alialnu@oss.nvidia.com
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
examples/performance-thread/pthread_shim/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: jerinj@marvell.com <jerinj@marvell.com>
> Sent: Monday, August 16, 2021 4:19 PM
> To: John McNamara <john.mcnamara@intel.com>; Ian Betts
> <ian.betts@intel.com>; Tomasz Kulasek <tomaszx.kulasek@intel.com>
> Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon
> <thomas@monjalon.net>; bruce.richardson@intel.com;
> david.marchand@redhat.com; Jerin Jacob <jerinj@marvell.com>; Ali
> Alnubani <alialnu@nvidia.com>
> Subject: [PATCH] examples/performance-thread: fix build issue with clang
> 12.0.1
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> In clang 12.0.1 version, the use of pthread_yield() deprecated, use
> sched_yield() instead.
>
> log:
>
> Compiling C object
> examples/dpdk-pthread_shim.p/performance-
> thread_pthread_shim_main.c.o
> ../examples/performance-thread/pthread_shim/main.c: In function
> 'helloworld_pthread':
> ../examples/performance-thread/pthread_shim/main.c:75:9: warning:
> 'pthread_yield' is deprecated: pthread_yield is deprecated, use sched_yield
> instead [-Wdeprecated-declarations]
>
> Fixes: 433ba6228f9a ("examples/performance-thread: add pthread_shim
> app")
>
> Bugzilla ID: 745
>
> Cc: alialnu@oss.nvidia.com
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
I think this issue might be specific to Fedora Rawhide's build of clang 12.0.1, see my comment in the ticket:
https://bugs.dpdk.org/show_bug.cgi?id=745#c3
Tested-by: Ali Alnubani <alialnu@nvidia.com>
Thanks Jerin.
Ali
19/08/2021 09:09, Ali Alnubani:
> From: jerinj@marvell.com <jerinj@marvell.com>
> > In clang 12.0.1 version, the use of pthread_yield() deprecated, use
> > sched_yield() instead.
> >
> > log:
> >
> > Compiling C object
> > examples/dpdk-pthread_shim.p/performance-
> > thread_pthread_shim_main.c.o
> > ../examples/performance-thread/pthread_shim/main.c: In function
> > 'helloworld_pthread':
> > ../examples/performance-thread/pthread_shim/main.c:75:9: warning:
> > 'pthread_yield' is deprecated: pthread_yield is deprecated, use sched_yield
> > instead [-Wdeprecated-declarations]
> >
> > Fixes: 433ba6228f9a ("examples/performance-thread: add pthread_shim
> > app")
adding Cc: stable for other branches.
> >
> > Bugzilla ID: 745
> >
> > Cc: alialnu@oss.nvidia.com
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> > ---
>
> I think this issue might be specific to Fedora Rawhide's build of clang 12.0.1, see my comment in the ticket:
> https://bugs.dpdk.org/show_bug.cgi?id=745#c3
I hit the same issue on Arch Linux.
> Tested-by: Ali Alnubani <alialnu@nvidia.com>
>
> Thanks Jerin.
Applied, thanks.
@@ -72,7 +72,7 @@ void *helloworld_pthread(void *arg)
print_count++;
/* yield thread to give opportunity for lock contention */
- pthread_yield();
+ sched_yield();
/* retrieve arg from TLS */
uint64_t thread_no = (uint64_t) pthread_getspecific(key);