Message ID | 20210729134711.35870-1-heinrich.kuhn@netronome.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 035B4A034F; Thu, 29 Jul 2021 15:47:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E72840DFB; Thu, 29 Jul 2021 15:47:24 +0200 (CEST) Received: from mail-wr1-f50.google.com (mail-wr1-f50.google.com [209.85.221.50]) by mails.dpdk.org (Postfix) with ESMTP id 4655440687 for <dev@dpdk.org>; Thu, 29 Jul 2021 15:47:23 +0200 (CEST) Received: by mail-wr1-f50.google.com with SMTP id j2so7013379wrx.9 for <dev@dpdk.org>; Thu, 29 Jul 2021 06:47:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=gdBS0lsHuqLaNFdke/XrIOXVXx8S2lZOT79xV594Pt0=; b=KX8+Llbk3MYlGM3UxjIDR694sFD81dMbkIXkQc8dEPu7xgQ0OHw+jzgCQzK5U7jUzB lZjCkkBwmA1TUyawvveC76fuSF57KJrSig2bYnX5Ka9uyIiYhHG3pMNKHJ0eo+bOA0bT JZyawuMFiIOp9cArFOOn0SMQG80GoESaFcm02SR6oFJfrH4BdciEazxrgPxHCYVa/kQv GLPvEYDPJfc8RItnOiWg/iDju+Cu2YL0FFfDh8F6VVpn5R/itdg/QqAkQG8obU6eHPeR /jvj6cOcZ3Ju9c+MjVQFnjxaATVaEnNLGxdT/gtF+y0lg8QXDMrbqUh/11fHgM6UcIK3 /brQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=gdBS0lsHuqLaNFdke/XrIOXVXx8S2lZOT79xV594Pt0=; b=ui8VaCimexKpKA7NkkF8e0+e8iB0o3ODOiNo7PqeH4Y4+fGkIrcdKL5zpUaDtsalpL yp6IlURdQhdv33u0FsMQP1iQQBBSIw9K8Wn/KlKbT53YTwhNVGmu3OXJaEYylRYfy7Fm lCo4CUNsHEcO7IhGMVb6qsFYSZ1QxeP9+63zCgR51q0vbX38+0+dlhpwp2dBT4eKPBWj n80K50GIUX82mcCpsaBSZFHNkUTLMQj2v18A2I1W7G+vHYCjAIVLnSic4uOQrnuSvrDR Cq7WG0oHL/raSjoS/N2OTiRkImAKRyE93j+EZYB1hHpKElianHww/r4fHJ2NLqHO3WKi VZgQ== X-Gm-Message-State: AOAM533DpS38ox0Jt309Z7C2OORqCxkSMqO1944mSswUoO28PN7AbgEf Uskfgg1BjceCpIf0VzQiQNgFQqUkpsaTZsBK1Gnef97s6moq8BdCqbRDDf/1vZyV2agQKMcpCVv eK2SsjQtdsNhkEXKwOZZaYp7Z0SMGSpNcRysaYoOjZFcj3y+UJsTQfmKlcImPLe7k X-Google-Smtp-Source: ABdhPJy/+6vi1cQHgsWnyNsXRgSHlSIHktz60XiL+TUkIm4FHKE0dVElvAPYQ7ZRuals71GMJXjLbQ== X-Received: by 2002:adf:c549:: with SMTP id s9mr5031071wrf.344.1627566442792; Thu, 29 Jul 2021 06:47:22 -0700 (PDT) Received: from localhost.localdomain (dsl-197-245-41-228.voxdsl.co.za. [197.245.41.228]) by smtp.gmail.com with ESMTPSA id v2sm3498246wro.48.2021.07.29.06.47.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 29 Jul 2021 06:47:22 -0700 (PDT) From: Heinrich Kuhn <heinrich.kuhn@netronome.com> To: dev@dpdk.org Cc: Heinrich Kuhn <heinrich.kuhn@netronome.com> Date: Thu, 29 Jul 2021 15:47:04 +0200 Message-Id: <20210729134711.35870-1-heinrich.kuhn@netronome.com> X-Mailer: git-send-email 2.30.1 (Apple Git-130) In-Reply-To: <20210716083545.34444-1-heinrich.kuhn@netronome.com> References: <20210716083545.34444-1-heinrich.kuhn@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v3 0/7] Refactor the NFP PMD X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Refactor the NFP PMD
|
|
Message
Heinrich Kuhn
July 29, 2021, 1:47 p.m. UTC
This patch set restructures the NFP PMD, aligning it more with the common layout adopted by most other PMD's. Although the changes look fairly large, functionally nothing is added or removed from the driver and the existing code is mostly just reorganized into the familiar structure seen in other PMD's. Apart form adopting the common PMD layout this change should also aid in future feature development to the NFP PMD. The previous layout where most of the logic resided in a single file (nfp_net.c) would have become tedious to support going forward. v3: * Avoid squashing the new firmware loader helper added in: https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 * Add dependency to patch-93299 v2: * Added missing sign-off's --- Depends-on: patch-93299 ("net/nfp: remove compile time log") Heinrich Kuhn (7): net/nfp: split rxtx headers into separate file net/nfp: move rxtx functions to their own file net/nfp: move CPP bridge to a separate file net/nfp: prototype common functions in header file net/nfp: move VF functions into new file net/nfp: move PF functions into new file net/nfp: batch file rename for consistency drivers/net/nfp/meson.build | 6 +- drivers/net/nfp/nfp_common.c | 1322 ++++++ drivers/net/nfp/nfp_common.h | 413 ++ drivers/net/nfp/nfp_cpp_bridge.c | 392 ++ drivers/net/nfp/nfp_cpp_bridge.h | 36 + .../net/nfp/{nfp_net_ctrl.h => nfp_ctrl.h} | 6 +- drivers/net/nfp/nfp_ethdev.c | 1067 +++++ drivers/net/nfp/nfp_ethdev_vf.c | 504 +++ .../net/nfp/{nfp_net_logs.h => nfp_logs.h} | 6 +- drivers/net/nfp/nfp_net.c | 3889 ----------------- drivers/net/nfp/nfp_rxtx.c | 1002 +++++ drivers/net/nfp/{nfp_net_pmd.h => nfp_rxtx.h} | 279 +- 12 files changed, 4783 insertions(+), 4139 deletions(-) create mode 100644 drivers/net/nfp/nfp_common.c create mode 100644 drivers/net/nfp/nfp_common.h create mode 100644 drivers/net/nfp/nfp_cpp_bridge.c create mode 100644 drivers/net/nfp/nfp_cpp_bridge.h rename drivers/net/nfp/{nfp_net_ctrl.h => nfp_ctrl.h} (99%) create mode 100644 drivers/net/nfp/nfp_ethdev.c create mode 100644 drivers/net/nfp/nfp_ethdev_vf.c rename drivers/net/nfp/{nfp_net_logs.h => nfp_logs.h} (94%) delete mode 100644 drivers/net/nfp/nfp_net.c create mode 100644 drivers/net/nfp/nfp_rxtx.c rename drivers/net/nfp/{nfp_net_pmd.h => nfp_rxtx.h} (54%)
Comments
On 2021/07/29 15:47, Heinrich Kuhn wrote: > This patch set restructures the NFP PMD, aligning it more with the > common layout adopted by most other PMD's. Although the changes look > fairly large, functionally nothing is added or removed from the driver > and the existing code is mostly just reorganized into the familiar > structure seen in other PMD's. Apart form adopting the common PMD layout > this change should also aid in future feature development to the NFP > PMD. The previous layout where most of the logic resided in a single > file (nfp_net.c) would have become tedious to support going forward. > > v3: > * Avoid squashing the new firmware loader helper added in: > https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 > * Add dependency to patch-93299 > > v2: > * Added missing sign-off's > > --- I think this refactor is a step in the right direction for the NFP PMD. I do have a question/concern regarding future bug fixes. If this is merged, back-porting any bug fixes will require a little bit more effort since the code base will differ quite substantially for some time. If there is a strong preference to avoid a situation like this we can certainly live without this refactor Regards, Heinrich
On 8/13/2021 1:46 PM, Heinrich Kuhn wrote: > > > On 2021/07/29 15:47, Heinrich Kuhn wrote: >> This patch set restructures the NFP PMD, aligning it more with the >> common layout adopted by most other PMD's. Although the changes look >> fairly large, functionally nothing is added or removed from the driver >> and the existing code is mostly just reorganized into the familiar >> structure seen in other PMD's. Apart form adopting the common PMD layout >> this change should also aid in future feature development to the NFP >> PMD. The previous layout where most of the logic resided in a single >> file (nfp_net.c) would have become tedious to support going forward. >> >> v3: >> * Avoid squashing the new firmware loader helper added in: >> https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 >> * Add dependency to patch-93299 >> >> v2: >> * Added missing sign-off's >> >> --- > > I think this refactor is a step in the right direction for the NFP PMD. > I do have a question/concern regarding future bug fixes. If this is > merged, back-porting any bug fixes will require a little bit more effort > since the code base will differ quite substantially for some time. > > If there is a strong preference to avoid a situation like this we can > certainly live without this refactor > I didn't check the set yet, but as generic rule when there is a conflict in backporting, stable tree maintainers ask support from patch authors, for this case from you. If you are OK to provide this support when needed, there should be no problem. We have rejected only a few refactoring patches in the past, they were doing batch syntax updates or batch renames etc.. The benefit was small comparing the conflict/noise it brings. But I am for having meaningful refactoring.
On 7/29/2021 2:47 PM, Heinrich Kuhn wrote: > This patch set restructures the NFP PMD, aligning it more with the > common layout adopted by most other PMD's. Although the changes look > fairly large, functionally nothing is added or removed from the driver > and the existing code is mostly just reorganized into the familiar > structure seen in other PMD's. Apart form adopting the common PMD layout > this change should also aid in future feature development to the NFP > PMD. The previous layout where most of the logic resided in a single > file (nfp_net.c) would have become tedious to support going forward. > > v3: > * Avoid squashing the new firmware loader helper added in: > https://git.dpdk.org/dpdk/commit/?id=40edb9c0d36b781 > * Add dependency to patch-93299 > > v2: > * Added missing sign-off's > > --- > Depends-on: patch-93299 ("net/nfp: remove compile time log") > > Heinrich Kuhn (7): > net/nfp: split rxtx headers into separate file > net/nfp: move rxtx functions to their own file > net/nfp: move CPP bridge to a separate file > net/nfp: prototype common functions in header file > net/nfp: move VF functions into new file > net/nfp: move PF functions into new file > net/nfp: batch file rename for consistency > Series applied to dpdk-next-net/main, thanks.