diff mbox series

[v2,1/2] ethdev: announce change to action modify data

Message ID 20210803085754.643180-1-orika@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [v2,1/2] ethdev: announce change to action modify data |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Ori Kam Aug. 3, 2021, 8:57 a.m. UTC 
  In the current implementation,
the action rte_flow_action_modify_field is not well defined
for fields larger than 64 bits (for example IPv6 source)
In addition, the byte order is also not well defined.

Both of those issue should be fixed.

Signed-off-by: Ori Kam <orika@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
---
V2:
  Fix typo.
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Ajit Khaparde Aug. 3, 2021, 6:10 p.m. UTC | #1 
On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
>
> In the current implementation,
> the action rte_flow_action_modify_field is not well defined
> for fields larger than 64 bits (for example IPv6 source)
> In addition, the byte order is also not well defined.
>
> Both of those issue should be fixed.
>
> Signed-off-by: Ori Kam <orika@nvidia.com>
> Acked-by: Matan Azrad <matan@nvidia.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

> ---
> V2:
>   Fix typo.
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index d9c0e65921..b530616281 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -158,3 +158,7 @@ Deprecation Notices
>  * security: The functions ``rte_security_set_pkt_metadata`` and
>    ``rte_security_get_userdata`` will be made inline functions and additional
>    flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
> +
> +* ethdev: The struct ``rte_flow_action_modify_data`` will be modified
> +  to support modifying larger fields than 64 bits.
> +  In addition, documentation will be updated to clarify byte order.
> --
> 2.25.1
>
Andrew Rybchenko Aug. 4, 2021, 12:10 p.m. UTC | #2 
On 8/3/21 9:10 PM, Ajit Khaparde wrote:
> On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
>>
>> In the current implementation,
>> the action rte_flow_action_modify_field is not well defined
>> for fields larger than 64 bits (for example IPv6 source)
>> In addition, the byte order is also not well defined.
>>
>> Both of those issue should be fixed.
>>
>> Signed-off-by: Ori Kam <orika@nvidia.com>
>> Acked-by: Matan Azrad <matan@nvidia.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Jerin Jacob Aug. 7, 2021, 1:33 p.m. UTC | #3 
On Wed, Aug 4, 2021 at 5:40 PM Andrew Rybchenko
<andrew.rybchenko@oktetlabs.ru> wrote:
>
> On 8/3/21 9:10 PM, Ajit Khaparde wrote:
> > On Tue, Aug 3, 2021 at 1:58 AM Ori Kam <orika@nvidia.com> wrote:
> >>
> >> In the current implementation,
> >> the action rte_flow_action_modify_field is not well defined
> >> for fields larger than 64 bits (for example IPv6 source)
> >> In addition, the byte order is also not well defined.
> >>
> >> Both of those issue should be fixed.
> >>
> >> Signed-off-by: Ori Kam <orika@nvidia.com>
> >> Acked-by: Matan Azrad <matan@nvidia.com>
> > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Acked-by: Jerin Jacob <jerinj@marvell.com>



>
Thomas Monjalon Aug. 7, 2021, 7:26 p.m. UTC | #4 
> > >> In the current implementation,
> > >> the action rte_flow_action_modify_field is not well defined
> > >> for fields larger than 64 bits (for example IPv6 source)
> > >> In addition, the byte order is also not well defined.
> > >>
> > >> Both of those issue should be fixed.
> > >>
> > >> Signed-off-by: Ori Kam <orika@nvidia.com>
> > >> Acked-by: Matan Azrad <matan@nvidia.com>
> > > Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> > Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d9c0e65921..b530616281 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -158,3 +158,7 @@  Deprecation Notices
 * security: The functions ``rte_security_set_pkt_metadata`` and
   ``rte_security_get_userdata`` will be made inline functions and additional
   flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* ethdev: The struct ``rte_flow_action_modify_data`` will be modified
+  to support modifying larger fields than 64 bits.
+  In addition, documentation will be updated to clarify byte order.