net: announce changes in IPv4 header

Message ID 20210802103834.14263-1-getelson@nvidia.com (mailing list archive)
State Accepted, archived
Headers
Series net: announce changes in IPv4 header |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-spell-check-testing warning Testing issues
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-aarch64-unit-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-x86_64-unit-testing success Testing PASS

Commit Message

Gregory Etelson Aug. 2, 2021, 10:38 a.m. UTC
  Announce changes to add 2 unions. The first union will provide
integral and bits access to version and IHL. The second union will
provide integral and bits access to fragment flags and offset.

Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
 doc/guides/rel_notes/deprecation.rst | 5 +++++
 1 file changed, 5 insertions(+)
  

Comments

Andrew Rybchenko Aug. 2, 2021, 10:42 a.m. UTC | #1
On 8/2/21 1:38 PM, Gregory Etelson wrote:
> Announce changes to add 2 unions. The first union will provide
> integral and bits access to version and IHL. The second union will
> provide integral and bits access to fragment flags and offset.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
  
Slava Ovsiienko Aug. 2, 2021, 12:10 p.m. UTC | #2
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Gregory Etelson
> Sent: Monday, August 2, 2021 13:39
> To: dev@dpdk.org
> Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Ori Kam
> <orika@nvidia.com>; Ray Kinsella <mdr@ashroe.eu>
> Subject: [dpdk-dev] [PATCH] net: announce changes in IPv4 header
> 
> Announce changes to add 2 unions. The first union will provide integral and
> bits access to version and IHL. The second union will provide integral and bits
> access to fragment flags and offset.
> 
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
  
Akhil Goyal Aug. 2, 2021, 12:38 p.m. UTC | #3
> > -----Original Message-----
> > From: dev <dev-bounces@dpdk.org> On Behalf Of Gregory Etelson
> > Sent: Monday, August 2, 2021 13:39
> > To: dev@dpdk.org
> > Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> > <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Ori Kam
> > <orika@nvidia.com>; Ray Kinsella <mdr@ashroe.eu>
> > Subject: [dpdk-dev] [PATCH] net: announce changes in IPv4 header
> >
> > Announce changes to add 2 unions. The first union will provide integral and
> > bits access to version and IHL. The second union will provide integral and
> bits
> > access to fragment flags and offset.
> >
> > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Acked-by: Akhil Goyal <gakhil@marvell.com>
  
Ajit Khaparde Aug. 3, 2021, 6:06 p.m. UTC | #4
On Mon, Aug 2, 2021 at 5:38 AM Akhil Goyal <gakhil@marvell.com> wrote:
>
> > > -----Original Message-----
> > > From: dev <dev-bounces@dpdk.org> On Behalf Of Gregory Etelson
> > > Sent: Monday, August 2, 2021 13:39
> > > To: dev@dpdk.org
> > > Cc: Gregory Etelson <getelson@nvidia.com>; Matan Azrad
> > > <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Ori Kam
> > > <orika@nvidia.com>; Ray Kinsella <mdr@ashroe.eu>
> > > Subject: [dpdk-dev] [PATCH] net: announce changes in IPv4 header
> > >
> > > Announce changes to add 2 unions. The first union will provide integral and
> > > bits access to version and IHL. The second union will provide integral and
> > bits
> > > access to fragment flags and offset.
> > >
> > > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
>
> Acked-by: Akhil Goyal <gakhil@marvell.com>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

>
  
Thomas Monjalon Aug. 4, 2021, 2:27 p.m. UTC | #5
> > > > Announce changes to add 2 unions. The first union will provide integral and
> > > > bits access to version and IHL. The second union will provide integral and
> > > bits
> > > > access to fragment flags and offset.
> > > >
> > > > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> > > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> > Acked-by: Akhil Goyal <gakhil@marvell.com>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Applied, thanks.
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index d9c0e65921..46f8a10dc5 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -158,3 +158,8 @@  Deprecation Notices
 * security: The functions ``rte_security_set_pkt_metadata`` and
   ``rte_security_get_userdata`` will be made inline functions and additional
   flags will be added in structure ``rte_security_ctx`` in DPDK 21.11.
+
+* net: The structure ``rte_ipv4_hdr`` will have two unions.
+  The first union is for existing ``version_ihl`` byte and new bitfield for
+  version and IHL. The second union is for existing ``fragment_offset`` and
+  new bitfield for fragment flags and offset.