doc: announce extension of crypto data-unit length

Message ID 20210414201544.1063413-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series doc: announce extension of crypto data-unit length |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success travis build: passed
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS

Commit Message

Thomas Monjalon April 14, 2021, 8:15 p.m. UTC
  The struct member dataunit_len is introduced in DPDK 21.05.
It is limited to 16 bits to fit a padding hole in 32-bit build.
This means the maximum data-unit length is 64 KB.
Some use cases may benefit of a bigger size as the proposed 32 bits.

Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 doc/guides/rel_notes/deprecation.rst | 4 ++++
 1 file changed, 4 insertions(+)
  

Comments

Akhil Goyal May 17, 2021, 7:41 p.m. UTC | #1
> The struct member dataunit_len is introduced in DPDK 21.05.
> It is limited to 16 bits to fit a padding hole in 32-bit build.
> This means the maximum data-unit length is 64 KB.
> Some use cases may benefit of a bigger size as the proposed 32 bits.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
Acked-by: Akhil Goyal <gakhil@marvell.com>

Thomas,
Please take this patch directly on main, if it gets the required Acks.
  
Thomas Monjalon July 31, 2021, 5:10 p.m. UTC | #2
Ping for more votes.
Please ack or reject.

17/05/2021 21:41, Akhil Goyal:
> > The struct member dataunit_len is introduced in DPDK 21.05.
> > It is limited to 16 bits to fit a padding hole in 32-bit build.
> > This means the maximum data-unit length is 64 KB.
> > Some use cases may benefit of a bigger size as the proposed 32 bits.
> > 
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> Thomas,
> Please take this patch directly on main, if it gets the required Acks.
  
Ajit Khaparde July 31, 2021, 6:58 p.m. UTC | #3
On Wed, Apr 14, 2021 at 1:15 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The struct member dataunit_len is introduced in DPDK 21.05.
> It is limited to 16 bits to fit a padding hole in 32-bit build.
> This means the maximum data-unit length is 64 KB.
> Some use cases may benefit of a bigger size as the proposed 32 bits.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
> index 2afc84c396..a17f30c2ff 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -118,6 +118,10 @@ Deprecation Notices
>    consistent with existing outer header checksum status flag naming, which
>    should help in reducing confusion about its usage.
>
> +* cryptodev: The field ``dataunit_len`` of the ``struct rte_crypto_cipher_xform``
> +  has a limited size ``uint16_t``.
> +  It will be moved and extended as ``uint32_t`` in DPDK 21.11.
> +
>  * eventdev: The structure ``rte_event_eth_rx_adapter_queue_conf`` will be
>    extended to include ``rte_event_eth_rx_adapter_event_vector_config`` elements
>    and the function ``rte_event_eth_rx_adapter_queue_event_vector_config`` will
> --
> 2.31.1
>
  
Matan Azrad Aug. 2, 2021, 11:10 a.m. UTC | #4
From: Thomas Monjalon
> The struct member dataunit_len is introduced in DPDK 21.05.
> It is limited to 16 bits to fit a padding hole in 32-bit build.
> This means the maximum data-unit length is 64 KB.
> Some use cases may benefit of a bigger size as the proposed 32 bits.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Matan Azrad <matan@nvidia.com>
  
Thomas Monjalon Aug. 2, 2021, 12:04 p.m. UTC | #5
14/04/2021 22:15, Thomas Monjalon:
> The struct member dataunit_len is introduced in DPDK 21.05.
> It is limited to 16 bits to fit a padding hole in 32-bit build.
> This means the maximum data-unit length is 64 KB.
> Some use cases may benefit of a bigger size as the proposed 32 bits.
> 
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>

    Acked-by: Akhil Goyal <gakhil@marvell.com>
    Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
    Acked-by: Matan Azrad <matan@nvidia.com>

Applied
  

Patch

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 2afc84c396..a17f30c2ff 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -118,6 +118,10 @@  Deprecation Notices
   consistent with existing outer header checksum status flag naming, which
   should help in reducing confusion about its usage.
 
+* cryptodev: The field ``dataunit_len`` of the ``struct rte_crypto_cipher_xform``
+  has a limited size ``uint16_t``.
+  It will be moved and extended as ``uint32_t`` in DPDK 21.11.
+
 * eventdev: The structure ``rte_event_eth_rx_adapter_queue_conf`` will be
   extended to include ``rte_event_eth_rx_adapter_event_vector_config`` elements
   and the function ``rte_event_eth_rx_adapter_queue_event_vector_config`` will