diff mbox series

bus/pci: Fix PowerNV platform detection logic

Message ID 20210615172027.1496115-1-drc@linux.vnet.ibm.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series bus/pci: Fix PowerNV platform detection logic |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing warning Testing issues
ci/iol-testing success Testing PASS
ci/github-robot success github build: passed
ci/intel-Testing success Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

David Christensen June 15, 2021, 5:20 p.m. UTC 
  Fix the IOMMU detection logic that looks for the "platform" field of
/proc/cpuinfo on POWER systems.

Fixes: 905215731833 ("bus/pci: support IOVA as VA on PowerNV systems")

Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
---
 drivers/bus/pci/linux/pci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand June 24, 2021, 1:51 p.m. UTC | #1 
On Tue, Jun 15, 2021 at 7:21 PM David Christensen
<drc@linux.vnet.ibm.com> wrote:
>
> Fix the IOMMU detection logic that looks for the "platform" field of
> /proc/cpuinfo on POWER systems.
>
> Fixes: 905215731833 ("bus/pci: support IOVA as VA on PowerNV systems")
Cc: stable@dpdk.org

>
> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
Reviewed-by: David Marchand <david.marchand@redhat.com>

Looking at http://patchwork.dpdk.org/project/dpdk/patch/20210623204355.74362-1-drc@linux.vnet.ibm.com/,
I understand it should be merged after this current patch.
Can you confirm?
David Christensen June 24, 2021, 4:59 p.m. UTC | #2 
On 6/24/21 6:51 AM, David Marchand wrote:
> On Tue, Jun 15, 2021 at 7:21 PM David Christensen
> <drc@linux.vnet.ibm.com> wrote:
>>
>> Fix the IOMMU detection logic that looks for the "platform" field of
>> /proc/cpuinfo on POWER systems.
>>
>> Fixes: 905215731833 ("bus/pci: support IOVA as VA on PowerNV systems")
> Cc: stable@dpdk.org
> 
>>
>> Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> Looking at http://patchwork.dpdk.org/project/dpdk/patch/20210623204355.74362-1-drc@linux.vnet.ibm.com/,
> I understand it should be merged after this current patch.
> Can you confirm?

Yes, that's correct.

Dave
David Marchand July 5, 2021, 8:58 a.m. UTC | #3 
On Thu, Jun 24, 2021 at 3:51 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Tue, Jun 15, 2021 at 7:21 PM David Christensen
> <drc@linux.vnet.ibm.com> wrote:
> >
> > Fix the IOMMU detection logic that looks for the "platform" field of
> > /proc/cpuinfo on POWER systems.
> >
> > Fixes: 905215731833 ("bus/pci: support IOVA as VA on PowerNV systems")
> Cc: stable@dpdk.org
>
> >
> > Signed-off-by: David Christensen <drc@linux.vnet.ibm.com>
> Reviewed-by: David Marchand <david.marchand@redhat.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c
index 0dc99e9cb2..edfe430268 100644
--- a/drivers/bus/pci/linux/pci.c
+++ b/drivers/bus/pci/linux/pci.c
@@ -569,7 +569,7 @@  pci_device_iommu_support_va(__rte_unused const struct rte_pci_device *dev)
 
 	/* Check for a PowerNV platform */
 	while (getline(&line, &len, fp) != -1) {
-		if (strstr(line, "platform") != NULL)
+		if (strstr(line, "platform") == NULL)
 			continue;
 
 		if (strstr(line, "PowerNV") != NULL) {