[v3] net/mlx5: add TCP and IPv6 to supported flow items list in Windows

Message ID 20210622153450.12324-1-talshn@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series [v3] net/mlx5: add TCP and IPv6 to supported flow items list in Windows |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/github-robot success github build: passed
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS

Commit Message

Tal Shnaiderman June 22, 2021, 3:34 p.m. UTC
  WINOF2 2.70 Windows kernel driver allows DevX rule creation
of types TCP and IPv6.

Added the types to the supported items in mlx5_flow_os_item_supported
to allow them to be created in the PMD.

Added description of new rules support in Windows kernel driver WINOF2 2.70
to the mlx5 driver guide.

Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>

---
v3 merge code and docu changes to a single patch.
---
---
 doc/guides/nics/mlx5.rst                | 3 +++
 drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++
 2 files changed, 5 insertions(+)
  

Comments

Matan Azrad June 23, 2021, 11:56 a.m. UTC | #1
From: Tal Shnaiderman
> WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP
> and IPv6.
> 
> Added the types to the supported items in mlx5_flow_os_item_supported
> to allow them to be created in the PMD.
> 
> Added description of new rules support in Windows kernel driver WINOF2
> 2.70 to the mlx5 driver guide.
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
  
Raslan Darawsheh June 28, 2021, 8:32 a.m. UTC | #2
Hi,

> -----Original Message-----
> From: Tal Shnaiderman <talshn@nvidia.com>
> Sent: Tuesday, June 22, 2021 6:35 PM
> To: dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>; Matan Azrad
> <matan@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>; Asaf Penso
> <asafp@nvidia.com>; Odi Assli <odia@nvidia.com>
> Subject: [PATCH v3] net/mlx5: add TCP and IPv6 to supported flow items list
> in Windows
Title too long:
Changing to : 
net/mlx5: add TCP and IPv6 to supported items in Windows
> 
> WINOF2 2.70 Windows kernel driver allows DevX rule creation of types TCP
> and IPv6.
> 
> Added the types to the supported items in mlx5_flow_os_item_supported
> to allow them to be created in the PMD.
> 
> Added description of new rules support in Windows kernel driver WINOF2
> 2.70 to the mlx5 driver guide.
> 
> Signed-off-by: Tal Shnaiderman <talshn@nvidia.com>
> 
> ---
> v3 merge code and docu changes to a single patch.
> ---
> ---
>  doc/guides/nics/mlx5.rst                | 3 +++
>  drivers/net/mlx5/windows/mlx5_flow_os.h | 2 ++
>  2 files changed, 5 insertions(+)

Patch applied to next-net-mlx,

Kindest regards,
Raslan Darawsheh
  

Patch

diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst
index 83299646dd..eb44a070b1 100644
--- a/doc/guides/nics/mlx5.rst
+++ b/doc/guides/nics/mlx5.rst
@@ -123,6 +123,9 @@  Limitations
 
     - IPv4/UDP with CVLAN filtering
     - Unicast MAC filtering
+  - Additional rules are supported from WinOF2 version 2.70:
+    - IPv4/TCP with CVLAN filtering
+    - L4 steering rules for port RSS of UDP, TCP and IP
 
 - For secondary process:
 
diff --git a/drivers/net/mlx5/windows/mlx5_flow_os.h b/drivers/net/mlx5/windows/mlx5_flow_os.h
index 26c3e59789..df92f25ce6 100644
--- a/drivers/net/mlx5/windows/mlx5_flow_os.h
+++ b/drivers/net/mlx5/windows/mlx5_flow_os.h
@@ -42,6 +42,8 @@  mlx5_flow_os_item_supported(int item)
 	case RTE_FLOW_ITEM_TYPE_ETH:
 	case RTE_FLOW_ITEM_TYPE_IPV4:
 	case RTE_FLOW_ITEM_TYPE_UDP:
+	case RTE_FLOW_ITEM_TYPE_TCP:
+	case RTE_FLOW_ITEM_TYPE_IPV6:
 		return true;
 	default:
 		return false;