diff mbox series

[V6] config/arm: add Qualcomm Centriq 2400 part number

Message ID 97239acdd64f1e3f0a36e707072d6075e3380131.1623942795.git.thierry.herbelot@6wind.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [V6] config/arm: add Qualcomm Centriq 2400 part number |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-intel-Functional success Functional Testing PASS
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Functional fail Functional Testing issues

Commit Message

Thierry Herbelot June 17, 2021, 3:13 p.m. UTC 
  0xc00 is for "SoC 2.0" Qualcomm Centriq servers.
0x800 is for "SoC 1.1".

Cc: Jerin Jacob <jerinj@marvell.com>
Cc: Ruifeng Wang <ruifeng.wang@arm.com>
Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>

Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
--
V2: add maintainers as Cc
V3: fix meson syntax for the SoC v1.1 machine description
V4: add new soc_centriq2400_v1_1 to the supported SoC list
V5: remove 'soc_' prefix in the supported SoC list
V6: remove soc declarations for Centriq 2400 (SoC v1.1)
---
 config/arm/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ruifeng Wang June 18, 2021, 2:09 a.m. UTC | #1 
> -----Original Message-----
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> Sent: Thursday, June 17, 2021 11:13 PM
> To: dev@dpdk.org
> Cc: Thierry Herbelot <thierry.herbelot@6wind.com>; thomas@monjalon.net;
> jerinj@marvell.com; Ruifeng Wang <Ruifeng.Wang@arm.com>; Honnappa
> Nagarahalli <Honnappa.Nagarahalli@arm.com>; Juraj Linkeš
> <juraj.linkes@pantheon.tech>
> Subject: [PATCH V6] config/arm: add Qualcomm Centriq 2400 part number
> 
> 0xc00 is for "SoC 2.0" Qualcomm Centriq servers.
> 0x800 is for "SoC 1.1".
> 
> Cc: Jerin Jacob <jerinj@marvell.com>
> Cc: Ruifeng Wang <ruifeng.wang@arm.com>
> Cc: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Cc: Juraj Linkeš <juraj.linkes@pantheon.tech>
> 
> Signed-off-by: Thierry Herbelot <thierry.herbelot@6wind.com>
> --
> V2: add maintainers as Cc
> V3: fix meson syntax for the SoC v1.1 machine description
> V4: add new soc_centriq2400_v1_1 to the supported SoC list
> V5: remove 'soc_' prefix in the supported SoC list
> V6: remove soc declarations for Centriq 2400 (SoC v1.1)
> ---
>  config/arm/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build index
> e83a56e0d589..9795ef08bc08 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -179,7 +179,8 @@ implementer_qualcomm = {
>          ['RTE_MAX_NUMA_NODES', 1]
>      ],
>      'part_number_config': {
> -        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
> +        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
> +        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
Nit, redundant comma at the end of the line.
With suggested change,
Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Thanks.
>      }
>  }
> 
> --
> 2.29.2
Thomas Monjalon June 18, 2021, 8:51 a.m. UTC | #2 
18/06/2021 04:09, Ruifeng Wang:
> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> >      'part_number_config': {
> > -        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
> > +        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
> > +        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
> Nit, redundant comma at the end of the line.

What is redundant?
Thierry Herbelot June 18, 2021, 8:53 a.m. UTC | #3 
On 6/18/21 10:51 AM, Thomas Monjalon wrote:
> 18/06/2021 04:09, Ruifeng Wang:
>> From: Thierry Herbelot <thierry.herbelot@6wind.com>
>>>       'part_number_config': {
>>> -        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
>>> +        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
>>> +        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
>> Nit, redundant comma at the end of the line.
> 
> What is redundant?

The comma at the end of the second line is not necessary.

	Thierry
Thomas Monjalon June 18, 2021, 8:58 a.m. UTC | #4 
18/06/2021 10:53, Thierry Herbelot:
> On 6/18/21 10:51 AM, Thomas Monjalon wrote:
> > 18/06/2021 04:09, Ruifeng Wang:
> >> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> >>>       'part_number_config': {
> >>> -        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
> >>> +        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
> >>> +        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
> >> Nit, redundant comma at the end of the line.
> > 
> > What is redundant?
> 
> The comma at the end of the second line is not necessary.

It is a good practice to have comma like other lines,
so no need to update this line when adding more.
Ruifeng Wang June 21, 2021, 1:52 a.m. UTC | #5 
> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Friday, June 18, 2021 4:58 PM
> To: Ruifeng Wang <Ruifeng.Wang@arm.com>; Thierry Herbelot
> <thierry.herbelot@6wind.com>
> Cc: dev@dpdk.org; jerinj@marvell.com; Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com>; Juraj Linkeš
> <juraj.linkes@pantheon.tech>; nd <nd@arm.com>
> Subject: Re: [PATCH V6] config/arm: add Qualcomm Centriq 2400 part
> number
> 
> 18/06/2021 10:53, Thierry Herbelot:
> > On 6/18/21 10:51 AM, Thomas Monjalon wrote:
> > > 18/06/2021 04:09, Ruifeng Wang:
> > >> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > >>>       'part_number_config': {
> > >>> -        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
> > >>> +        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
> > >>> +        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
> > >> Nit, redundant comma at the end of the line.
> > >
> > > What is redundant?
> >
> > The comma at the end of the second line is not necessary.
> 
> It is a good practice to have comma like other lines, so no need to update this
> line when adding more.
> 
Looked at style in the rest of the file. Just wanted them to be aligned.
I'm fine with a trailing comma at the last line.

Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>
Thomas Monjalon July 9, 2021, 3:27 p.m. UTC | #6 
21/06/2021 03:52, Ruifeng Wang:
> From: Thomas Monjalon <thomas@monjalon.net>
> > 18/06/2021 10:53, Thierry Herbelot:
> > > On 6/18/21 10:51 AM, Thomas Monjalon wrote:
> > > > 18/06/2021 04:09, Ruifeng Wang:
> > > >> From: Thierry Herbelot <thierry.herbelot@6wind.com>
> > > >>>       'part_number_config': {
> > > >>> -        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
> > > >>> +        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
> > > >>> +        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
> > > >> Nit, redundant comma at the end of the line.
> > > >
> > > > What is redundant?
> > >
> > > The comma at the end of the second line is not necessary.
> > 
> > It is a good practice to have comma like other lines, so no need to update this
> > line when adding more.
> > 
> Looked at style in the rest of the file. Just wanted them to be aligned.
> I'm fine with a trailing comma at the last line.
> 
> Acked-by: Ruifeng Wang <ruifeng.wang@arm.com>

Applied, thanks
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index e83a56e0d589..9795ef08bc08 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -179,7 +179,8 @@  implementer_qualcomm = {
         ['RTE_MAX_NUMA_NODES', 1]
     ],
     'part_number_config': {
-        '0xc00': {'machine_args':  ['-march=armv8-a+crc']}
+        '0x800': {'machine_args':  ['-march=armv8-a+crc']},
+        '0xc00': {'machine_args':  ['-march=armv8-a+crc']},
     }
 }