bus: clarify log for non-NUMA-aware devices
Checks
Commit Message
PCI and vmbus drivers printed a warning
when NUMA node had beed reported as (-1) or not reported by OS:
EAL: Invalid NUMA socket, default to 0
This message and its level might confuse users, because configuration
is valid and nothing happens that requires attention or intervention.
Reduce level to INFO and reword the message.
Fixes: f0e0e86aa35d ("pci: move NUMA node check from scan to probe")
Fixes: 831dba47bd36 ("bus/vmbus: add Hyper-V virtual bus support")
Cc: stable@dpdk.org
Signed-off-by: Dmitry Kozlyuk <dkozlyuk@nvidia.com>
Reviewed-by: Slava Ovsiienko <viacheslavo@nvidia.com>
---
Hi Xueming,
Please align logging in the pending bus/auxiliary patch.
doc/guides/nics/ena.rst | 2 +-
drivers/bus/pci/pci_common.c | 2 +-
drivers/bus/vmbus/vmbus_common.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Tue, 15 Jun 2021 13:51:55 +0300
Dmitry Kozlyuk <dkozlyuk@nvidia.com> wrote:
> diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c
> index 35d7d092d1..bf06f81229 100644
> --- a/drivers/bus/pci/pci_common.c
> +++ b/drivers/bus/pci/pci_common.c
> @@ -190,7 +190,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
> }
>
> if (dev->device.numa_node < 0) {
> - RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n");
> + RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to 0\n");
Also if RTE_MAX_NUMA_NODES is 1 then this message should be silenced.
It would be normal in that case.
@@ -234,7 +234,7 @@ Example output:
[...]
EAL: PCI device 0000:00:06.0 on NUMA socket -1
- EAL: Invalid NUMA socket, default to 0
+ EAL: Device is not NUMA-aware, defaulting socket to 0
EAL: probe driver: 1d0f:ec20 net_ena
Interactive-mode selected
@@ -190,7 +190,7 @@ rte_pci_probe_one_driver(struct rte_pci_driver *dr,
}
if (dev->device.numa_node < 0) {
- RTE_LOG(WARNING, EAL, " Invalid NUMA socket, default to 0\n");
+ RTE_LOG(INFO, EAL, " Device is not NUMA-aware, defaulting socket to 0\n");
dev->device.numa_node = 0;
}
@@ -112,7 +112,7 @@ vmbus_probe_one_driver(struct rte_vmbus_driver *dr,
dev->driver = dr;
if (dev->device.numa_node < 0) {
- VMBUS_LOG(WARNING, " Invalid NUMA socket, default to 0");
+ VMBUS_LOG(INFO, " Device is not NUMA-aware, defaulting socket to 0\n");
dev->device.numa_node = 0;
}