[v3] app/crypto-perf: fix dereference of null return
Checks
Commit Message
Return value of a function 'rte_zmalloc' is dereferenced without
checking, and it may call segmentation fault.
This patch fixed it.
Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test application")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v3:
* fix compiling warning.
---
app/test-crypto-perf/cperf_options_parsing.c | 6 ++++++
1 file changed, 6 insertions(+)
Comments
> Return value of a function 'rte_zmalloc' is dereferenced without
> checking, and it may call segmentation fault.
>
> This patch fixed it.
>
> Fixes: f8be1786b1b8 ("app/crypto-perf: introduce performance test
> application")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> v3:
> * fix compiling warning.
Applied to dpdk-next-crypto
Thanks.
@@ -506,6 +506,12 @@ parse_test_name(struct cperf_options *opts,
{
char *test_name = (char *) rte_zmalloc(NULL,
sizeof(char) * (strlen(arg) + 3), 0);
+ if (test_name == NULL) {
+ RTE_LOG(ERR, USER1, "Failed to rte zmalloc with size: %zu\n",
+ strlen(arg) + 3);
+ return -1;
+ }
+
snprintf(test_name, strlen(arg) + 3, "[%s]", arg);
opts->test_name = test_name;