lib: restore developer mode checks
Checks
Commit Message
Most of the checks on developer_mode have been accidentally dropped.
Restore them.
Fixes: 7d611e35b077 ("lib: simplify main build file")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/meson.build | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> Most of the checks on developer_mode have been accidentally dropped.
> Restore them.
>
> Fixes: 7d611e35b077 ("lib: simplify main build file")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
Thanks.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
05/05/2021 17:34, Bruce Richardson:
> On Wed, May 05, 2021 at 04:21:05PM +0200, David Marchand wrote:
> > Most of the checks on developer_mode have been accidentally dropped.
> > Restore them.
> >
> > Fixes: 7d611e35b077 ("lib: simplify main build file")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
>
> Thanks.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied, thanks
@@ -170,7 +170,7 @@ foreach l:libraries
libname = 'rte_' + name
includes += include_directories(l)
- if is_windows and use_function_versioning
+ if developer_mode and is_windows and use_function_versioning
message('@0@: Function versioning is not supported by Windows.'.format(name))
endif
@@ -227,7 +227,7 @@ foreach l:libraries
endif
lk_deps = [version_map, def_file, mingw_map]
- if not is_windows
+ if developer_mode and not is_windows
# on unix systems check the output of the
# check-symbols.sh script, using it as a
# dependency of the .so build