[v2,2/2] app/testpmd: fix link speed for a specified port
Checks
Commit Message
From: Huisong Li <lihuisong@huawei.com>
When we use the following cmd to modify the link speed of specified
port: "port config <port_id> speed xxx duplex xxx", we have to stop
all ports. It's not necessary.
Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
Cc: stable@dpdk.org
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
app/test-pmd/cmdline.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
Comments
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Wednesday, April 28, 2021 16:37
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH v2 2/2] app/testpmd: fix link speed for a specified port
>
> From: Huisong Li <lihuisong@huawei.com>
>
> When we use the following cmd to modify the link speed of specified
> port: "port config <port_id> speed xxx duplex xxx", we have to stop all ports. It's
> not necessary.
>
> Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
> Cc: stable@dpdk.org
>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> app/test-pmd/cmdline.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
On 4/29/21 11:42 AM, Li, Xiaoyun wrote:
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Wednesday, April 28, 2021 16:37
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Subject: [PATCH v2 2/2] app/testpmd: fix link speed for a specified port
>>
>> From: Huisong Li <lihuisong@huawei.com>
>>
>> When we use the following cmd to modify the link speed of specified
>> port: "port config <port_id> speed xxx duplex xxx", we have to stop all ports. It's
>> not necessary.
>>
>> Fixes: 82113036e4e5 ("ethdev: redesign link speed config")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> app/test-pmd/cmdline.c | 8 ++++----
>> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
>
From v1:
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied the patch only, thanks.
@@ -1649,13 +1649,13 @@ cmd_config_speed_specific_parsed(void *parsed_result,
uint32_t link_speed;
int ret;
- if (!all_ports_stopped()) {
- printf("Please stop all ports first\n");
+ if (port_id_is_invalid(res->id, ENABLED_WARN))
return;
- }
- if (port_id_is_invalid(res->id, ENABLED_WARN))
+ if (!port_is_stopped(res->id)) {
+ printf("Please stop port %d first\n", res->id);
return;
+ }
if (parse_and_check_speed_duplex(res->value1, res->value2,
&link_speed) < 0)