net/mlx5: fix the size of tcp flags for modify actions
Checks
Commit Message
From RFC the size of the TCP flags is 9, while the defined
current size is 6.
Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
Cc: akozyrev@nvidia.com
Cc: stable@dpdk.org
Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
Reviewed-by: Alexander Kozyrev <akozyrev@nvidia.com>
---
drivers/net/mlx5/mlx5_flow_dv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
> -----Original Message-----
> From: Wisam Monther <wisamm@nvidia.com>
> Sent: Wednesday, April 28, 2021 13:29
> To: Matan Azrad <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the size of tcp flags for modify actions
>
> From RFC the size of the TCP flags is 9, while the defined current size is 6.
>
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: akozyrev@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
> Reviewed-by: Alexander Kozyrev <akozyrev@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Hi,
> -----Original Message-----
> From: Wisam Monther <wisamm@nvidia.com>
> Sent: Wednesday, April 28, 2021 1:29 PM
> To: Matan Azrad <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>; Alexander Kozyrev
> <akozyrev@nvidia.com>; Raslan Darawsheh <rasland@nvidia.com>;
> dev@dpdk.org
> Cc: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>;
> stable@dpdk.org
> Subject: [PATCH] net/mlx5: fix the size of tcp flags for modify actions
>
> From RFC the size of the TCP flags is 9, while the defined current size is 6.
>
> Fixes: 641dbe4fb053 ("net/mlx5: support modify field flow action")
> Cc: akozyrev@nvidia.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Wisam Jaddo <wisamm@nvidia.com>
> Reviewed-by: Alexander Kozyrev <akozyrev@nvidia.com>
> ---
Patch applied to next-net-mlx,
Kindest regards,
Raslan Darawsheh
@@ -1366,7 +1366,7 @@ mlx5_flow_item_field_width(enum rte_flow_field_id field)
case RTE_FLOW_FIELD_TCP_ACK_NUM:
return 32;
case RTE_FLOW_FIELD_TCP_FLAGS:
- return 6;
+ return 9;
case RTE_FLOW_FIELD_UDP_PORT_SRC:
case RTE_FLOW_FIELD_UDP_PORT_DST:
return 16;
@@ -1688,10 +1688,10 @@ mlx5_flow_field_id_to_modify_info
(32 - width));
break;
case RTE_FLOW_FIELD_TCP_FLAGS:
- info[idx] = (struct field_modify_info){1, 0,
+ info[idx] = (struct field_modify_info){2, 0,
MLX5_MODI_OUT_TCP_FLAGS};
if (mask)
- mask[idx] = 0x3f >> (6 - width);
+ mask[idx] = rte_cpu_to_be_16(0x1ff >> (9 - width));
break;
case RTE_FLOW_FIELD_UDP_PORT_SRC:
info[idx] = (struct field_modify_info){2, 0,