[2/2] app/testpmd: fix max queue number when configure Tx offloads
Checks
Commit Message
From: Chengchang Tang <tangchengchang@huawei.com>
When txq offload is configured, max rxq is used as the max queue. This
patch fixes it.
Fixes: 74453ac9ef67 ("app/testpmd: fix queue offload configuration")
Cc: stable@dpdk.org
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
app/test-pmd/cmdline.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Sent: Thursday, April 22, 2021 15:04
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
> Subject: [PATCH 2/2] app/testpmd: fix max queue number when configure Tx
> offloads
>
> From: Chengchang Tang <tangchengchang@huawei.com>
>
> When txq offload is configured, max rxq is used as the max queue. This patch
> fixes it.
>
> Fixes: 74453ac9ef67 ("app/testpmd: fix queue offload configuration")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
> ---
> app/test-pmd/cmdline.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
> f0fa6e8..1cb1027 100644
> --- a/app/test-pmd/cmdline.c
> +++ b/app/test-pmd/cmdline.c
> @@ -4666,7 +4666,7 @@ cmd_config_queue_tx_offloads(struct rte_port *port)
> int k;
>
> /* Apply queue tx offloads configuration */
> - for (k = 0; k < port->dev_info.max_rx_queues; k++)
> + for (k = 0; k < port->dev_info.max_tx_queues; k++)
> port->tx_conf[k].offloads =
> port->dev_conf.txmode.offloads;
> }
> --
> 2.7.4
Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
On 4/25/2021 3:08 AM, Li, Xiaoyun wrote:
>
>> -----Original Message-----
>> From: Min Hu (Connor) <humin29@huawei.com>
>> Sent: Thursday, April 22, 2021 15:04
>> To: dev@dpdk.org
>> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Li, Xiaoyun <xiaoyun.li@intel.com>
>> Subject: [PATCH 2/2] app/testpmd: fix max queue number when configure Tx
>> offloads
>>
>> From: Chengchang Tang <tangchengchang@huawei.com>
>>
>> When txq offload is configured, max rxq is used as the max queue. This patch
>> fixes it.
>>
>> Fixes: 74453ac9ef67 ("app/testpmd: fix queue offload configuration")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
>> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>> ---
>> app/test-pmd/cmdline.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index
>> f0fa6e8..1cb1027 100644
>> --- a/app/test-pmd/cmdline.c
>> +++ b/app/test-pmd/cmdline.c
>> @@ -4666,7 +4666,7 @@ cmd_config_queue_tx_offloads(struct rte_port *port)
>> int k;
>>
>> /* Apply queue tx offloads configuration */
>> -for (k = 0; k < port->dev_info.max_rx_queues; k++)
>> +for (k = 0; k < port->dev_info.max_tx_queues; k++)
>> port->tx_conf[k].offloads =
>> port->dev_conf.txmode.offloads;
>> }
>> --
>> 2.7.4
>
> Acked-by: Xiaoyun Li <xiaoyun.li@intel.com>
>
Applied to dpdk-next-net/main, thanks.
@@ -4666,7 +4666,7 @@ cmd_config_queue_tx_offloads(struct rte_port *port)
int k;
/* Apply queue tx offloads configuration */
- for (k = 0; k < port->dev_info.max_rx_queues; k++)
+ for (k = 0; k < port->dev_info.max_tx_queues; k++)
port->tx_conf[k].offloads =
port->dev_conf.txmode.offloads;
}