drivers: fix indentation in build files
Checks
Commit Message
A couple of mistakes slipped in the mass change.
More mistakes could happen, especially when rebasing pending patches,
so we need an automatic check.
Fixes: 4ad4b20a7905 ("drivers: change indentation in build files")
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
drivers/crypto/qat/meson.build | 4 ++--
drivers/raw/skeleton/meson.build | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
Comments
On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote:
> A couple of mistakes slipped in the mass change.
>
> More mistakes could happen, especially when rebasing pending patches, so
> we need an automatic check.
>
I have a partially-done script from when I was doing the original
reindenting work, which I'll clean up a little and send on shortly.
It only checks indent of lists and I'm extending it to check for trailing
commas, but it may serve as a basis for further checks. On the plus side,
it does automatic fixing of those issues though. Running it will probably
show up more minor misses, so I'd suggest holding off on this patch until
then.
Regards,
/Bruce
22/04/2021 10:39, Bruce Richardson:
> On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote:
> > A couple of mistakes slipped in the mass change.
> >
> > More mistakes could happen, especially when rebasing pending patches, so
> > we need an automatic check.
> >
> I have a partially-done script from when I was doing the original
> reindenting work, which I'll clean up a little and send on shortly.
>
> It only checks indent of lists and I'm extending it to check for trailing
> commas, but it may serve as a basis for further checks. On the plus side,
> it does automatic fixing of those issues though. Running it will probably
> show up more minor misses, so I'd suggest holding off on this patch until
> then.
OK, I've sent this patch just for remembering.
I am happy to leave it to you for a v2 :)
Feel free to change the author of course.
Note: I've found tabs with this simple grep:
git grep ' ' '**/meson.build'
The tab is inserted with ^V-tab.
On Thu, Apr 22, 2021 at 11:20:19AM +0200, Thomas Monjalon wrote:
> 22/04/2021 10:39, Bruce Richardson:
> > On Thu, Apr 22, 2021 at 12:03:57AM +0200, Thomas Monjalon wrote:
> > > A couple of mistakes slipped in the mass change.
> > >
> > > More mistakes could happen, especially when rebasing pending patches, so
> > > we need an automatic check.
> > >
> > I have a partially-done script from when I was doing the original
> > reindenting work, which I'll clean up a little and send on shortly.
> >
> > It only checks indent of lists and I'm extending it to check for trailing
> > commas, but it may serve as a basis for further checks. On the plus side,
> > it does automatic fixing of those issues though. Running it will probably
> > show up more minor misses, so I'd suggest holding off on this patch until
> > then.
>
> OK, I've sent this patch just for remembering.
> I am happy to leave it to you for a v2 :)
> Feel free to change the author of course.
>
> Note: I've found tabs with this simple grep:
> git grep ' ' '**/meson.build'
> The tab is inserted with ^V-tab.
>
I've included fixes for these issues in V2 set of the python script to
check for them.
http://patches.dpdk.org/project/dpdk/patch/20210426105403.226004-2-bruce.richardson@intel.com/
@@ -17,9 +17,9 @@ if dep.found()
'qat_asym_pmd.c',
'qat_sym.c',
'qat_sym_hw_dp.c',
- 'qat_sym_pmd.c',
+ 'qat_sym_pmd.c',
'qat_sym_session.c',
- )
+ )
qat_ext_deps += dep
qat_cflags += '-DBUILD_QAT_SYM'
qat_cflags += '-DBUILD_QAT_ASYM'
@@ -3,6 +3,6 @@
deps += ['rawdev', 'kvargs', 'mbuf', 'bus_vdev']
sources = files(
- 'skeleton_rawdev.c',
+ 'skeleton_rawdev.c',
'skeleton_rawdev_test.c',
)