Message ID | 20210408064823.12130-1-getelson@nvidia.com (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Ferruh Yigit |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0795A0579; Thu, 8 Apr 2021 08:48:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 781BE40698; Thu, 8 Apr 2021 08:48:46 +0200 (CEST) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2088.outbound.protection.outlook.com [40.107.236.88]) by mails.dpdk.org (Postfix) with ESMTP id 1F08740138; Thu, 8 Apr 2021 08:48:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XdLD6NIR3QSBXetNjb3DngYsWgexQz3M13OzliiRr4/Lqlsfwz/n+5K7lzNPaeaLjD2fvGkwGgEK3pNhQNdoOQ183B5+NhytsaWqX+FYSTiR2Js7bvtvrxNsVikp6vB0AeglAyJhmDchGqaRySxUVhMSjWrNi8oWNeb8+9gFT5kYxERAUctRu9+r4ZNg8cDqhRhkX5l3a9LIAdCCrIY6iMhmfdj/CIEWycFtvjWch5Qdv5ts3Y7i/attLjoSMlHmYX6r4O8+X1zUM0EqwiMvQTqAUsiz61oUjHuRFFtO1GPFKWVnvcdYk6hf3Gzg0hR/3ZvjILfRQoPCVDOuOoz8LA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oQ6L0FoLdq1G0CY/xboXOoU6QWACh0QuIHPrtHndXhw=; b=k3eDzVXoWiKAKdw9983XSbhPqGCArbVwiyPB6/Y5tZu6PQP4QCEYR+2gcVlpZdTMHNzr2I4uLC8PLGEHgEMYogNjNIRyn3KmgbM4v2nIGu28va1kAjNA/SgZHGgBD4CB9lBvVYxDWvjtTx7Yl2WpVgLdKC/km1BH2YAJYzecLs59D1lbaBFDRLlTrL7tIkt2q8iLMPnC6Cj99OMwFBvd4XEydkLnVLgIwEsbVTK7oaDkQyDD+EwjWUQssfSkY4lG4mxE9dC3LpsH0BuwICniJ1m5SngjzhqcvrQGtIeBtYQCQyF2zV6KhTKyFd+NMYgqSFK2ZBkMhAR/E3qww06lTg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=oktetlabs.ru smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oQ6L0FoLdq1G0CY/xboXOoU6QWACh0QuIHPrtHndXhw=; b=dH8cevsz837L8oovKUlAXqKFzYmixzg9CiNQ0Ms90lFfgSieImWYFRLCD1MylnM6RORr1NbZkw6WuGTDh7ERpeDJ9NbsEfjWb8jfNzwL84+G05pzWayiXtMEtTPM49FwNvGSSOXR0tczArasioXwhpsOCOv8u5WlHXfJ8I2w9iX1Mqcv7YOiwYI5Cms9bpdSln2r4CG3kYJPHDvOrtHaIxlb1U6PHAPYfvgs/mF+upIWpShvPznkAAiwh4EH6SaAYv0gUhLxlLqCqgDpcthimxTCIU3JDqlY6H/gteaa39nYATrFfklmsp//MN6sxiATV+tuhGZ+HB9A4A2yd5kRiQ== Received: from BN6PR13CA0029.namprd13.prod.outlook.com (2603:10b6:404:13e::15) by BN6PR12MB1331.namprd12.prod.outlook.com (2603:10b6:404:17::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.32; Thu, 8 Apr 2021 06:48:43 +0000 Received: from BN8NAM11FT030.eop-nam11.prod.protection.outlook.com (2603:10b6:404:13e:cafe::99) by BN6PR13CA0029.outlook.office365.com (2603:10b6:404:13e::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4020.9 via Frontend Transport; Thu, 8 Apr 2021 06:48:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT030.mail.protection.outlook.com (10.13.177.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4020.17 via Frontend Transport; Thu, 8 Apr 2021 06:48:41 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 8 Apr 2021 06:48:38 +0000 From: Gregory Etelson <getelson@nvidia.com> To: <dev@dpdk.org> CC: <getelson@nvidia.com>, <matan@nvidia.com>, <rasland@nvidia.com>, <stable@dpdk.org>, Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Ivan Malov <ivan.malov@oktetlabs.ru>, Andy Moreton <amoreton@xilinx.com> Date: Thu, 8 Apr 2021 09:48:22 +0300 Message-ID: <20210408064823.12130-1-getelson@nvidia.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 8d142486-8963-4b4f-ebd0-08d8fa5a5914 X-MS-TrafficTypeDiagnostic: BN6PR12MB1331: X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-Microsoft-Antispam-PRVS: <BN6PR12MB13316100437593C9AEBF20E4A5749@BN6PR12MB1331.namprd12.prod.outlook.com> X-MS-Exchange-Transport-Forked: True X-MS-Oob-TLC-OOBClassifiers: OLM:7219; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 9WFh5Kam2j8STCeBTG9OgeFpBMUkVSWDNwVn0NJMZ/nmyoYticdrClV55fvPluuWfRbaTYBZcU6luhBPZBYVfYGUTXI1AwVWwjbPT/FJ9noaDs36GrHMJuO1Z5lnEDkByr/mgpuUkyuhwsr37XKw7RrfXiD3LqVAg4/BYQQQiT2DgyY5XCRXAZPCk6glSjJd715XmJMe9tfR7BC6eX64IcmZ5olb2H8+GgqguYrNGNn39dJVk4NNRBIqYuR2jDLUz20mAENbs0tthXdQj2KsCl65loqNGYxV6guL4XidUuV71ZO4YppMrLRn+AmaTr6xEbVVBVrBP8yG2DlXO/nkZc3sH4TVJQe0vuToSJZUNDs+RYAjk9L7mxAyHBMj4DXkdl8oMO20TJlfiIo67AkHyMh3WmIp7OzmH9z64sZAFcKZG99Rtutr6avAeaoTy0poS0buu8zSOh9MfCZDbquD5mPWZTSzdYhEWfHyVkDOizvyd+5j7pYpS69TATL2IU/FUMz6hVcyLFkGIpHda54Xuy0Zip5M/D7qn6xkCb1usIR4eO+csqjxWVJH8rLn4kSLVsOVoazMiCdAwBiv0gEBYOGy80kUgruFT86hCWLdh/N/7ORKSdbiyDTYYeeOEjocI0sZGwMq9sTQ6UTdfQ7WGA== X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(136003)(39860400002)(46966006)(36840700001)(7636003)(6666004)(16526019)(8676002)(54906003)(2906002)(478600001)(6916009)(4326008)(8936002)(316002)(36906005)(82740400003)(55016002)(2616005)(1076003)(336012)(70206006)(36860700001)(7696005)(70586007)(83380400001)(26005)(86362001)(47076005)(6286002)(356005)(5660300002)(36756003)(426003)(186003)(82310400003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Apr 2021 06:48:41.9680 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 8d142486-8963-4b4f-ebd0-08d8fa5a5914 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT030.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR12MB1331 Subject: [dpdk-dev] [PATCH] ethdev: fix VXLAN mask initialization value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
ethdev: fix VXLAN mask initialization value
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/iol-intel-Performance | success | Performance Testing PASS |
ci/travis-robot | success | travis build: passed |
ci/github-robot | success | github build: passed |
ci/Intel-compilation | success | Compilation OK |
ci/iol-mellanox-Performance | success | Performance Testing PASS |
ci/intel-Testing | success | Testing PASS |
ci/iol-abi-testing | success | Testing PASS |
ci/iol-testing | success | Testing PASS |
Commit Message
Gregory Etelson
April 8, 2021, 6:48 a.m. UTC
In GCC compiler, __builtin_constant_p(exp) is a function. The function returns the integer 1 if the argument is known to be a compile-time constant. Therefore, __builtin_constant_p(0xffffff << 8) returned 1. As the result, rte_flow_item_vxlan_mask was initiated to {{ {flags = 0x0, rsvd0 = {0x0, 0x0, 0x0}, vni = {0x0, 0x0, 0x0}, rsvd1 = 0x1}, hdr = {vx_flags = 0x0, vx_vni = 0x1000000}}} }} GCC fails initialization rte_flow_item_vxlan_mask.hdr.vni = (0xffffff << 8) with "initializer element is not a constant expression" error. Use immediate 0xffffff00 value instead. Cc: stable@dpdk.org Fixes: 43af98e687cf ("ethdev: reuse VXLAN header definition in flow item") Signed-off-by: Gregory Etelson <getelson@nvidia.com> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> --- lib/librte_ethdev/rte_flow.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 4/8/2021 7:48 AM, Gregory Etelson wrote: > In GCC compiler, __builtin_constant_p(exp) is a function. > The function returns the integer 1 if the argument is known to be > a compile-time constant. > Therefore, __builtin_constant_p(0xffffff << 8) returned 1. > As the result, rte_flow_item_vxlan_mask was initiated to > {{ > {flags = 0x0, rsvd0 = {0x0, 0x0, 0x0}, > vni = {0x0, 0x0, 0x0}, rsvd1 = 0x1}, > hdr = {vx_flags = 0x0, vx_vni = 0x1000000}}} > }} > GCC fails initialization > rte_flow_item_vxlan_mask.hdr.vni = (0xffffff << 8) > with "initializer element is not a constant expression" error. > Use immediate 0xffffff00 value instead. > > Cc: stable@dpdk.org > Fixes: 43af98e687cf ("ethdev: reuse VXLAN header definition in flow item") > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 4/8/2021 7:48 AM, Gregory Etelson wrote: > In GCC compiler, __builtin_constant_p(exp) is a function. > The function returns the integer 1 if the argument is known to be > a compile-time constant. > Therefore, __builtin_constant_p(0xffffff << 8) returned 1. > As the result, rte_flow_item_vxlan_mask was initiated to > {{ > {flags = 0x0, rsvd0 = {0x0, 0x0, 0x0}, > vni = {0x0, 0x0, 0x0}, rsvd1 = 0x1}, > hdr = {vx_flags = 0x0, vx_vni = 0x1000000}}} > }} > GCC fails initialization > rte_flow_item_vxlan_mask.hdr.vni = (0xffffff << 8) > with "initializer element is not a constant expression" error. > Use immediate 0xffffff00 value instead. > > Cc: stable@dpdk.org > Fixes: 43af98e687cf ("ethdev: reuse VXLAN header definition in flow item") > > Signed-off-by: Gregory Etelson <getelson@nvidia.com> > Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru>
On 4/8/2021 5:31 PM, Ivan Malov wrote: > On 4/8/2021 7:48 AM, Gregory Etelson wrote: >> In GCC compiler, __builtin_constant_p(exp) is a function. >> The function returns the integer 1 if the argument is known to be >> a compile-time constant. >> Therefore, __builtin_constant_p(0xffffff << 8) returned 1. >> As the result, rte_flow_item_vxlan_mask was initiated to >> {{ >> {flags = 0x0, rsvd0 = {0x0, 0x0, 0x0}, >> vni = {0x0, 0x0, 0x0}, rsvd1 = 0x1}, >> hdr = {vx_flags = 0x0, vx_vni = 0x1000000}}} >> }} >> GCC fails initialization >> rte_flow_item_vxlan_mask.hdr.vni = (0xffffff << 8) >> with "initializer element is not a constant expression" error. >> Use immediate 0xffffff00 value instead. >> >> Cc: stable@dpdk.org >> Fixes: 43af98e687cf ("ethdev: reuse VXLAN header definition in flow > item") >> >> Signed-off-by: Gregory Etelson <getelson@nvidia.com> >> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com> > > Reviewed-by: Ivan Malov <ivan.malov@oktetlabs.ru> > Applied to dpdk-next-net/main, thanks.
diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index 6cc57136ac..c476a0f59d 100644 --- a/lib/librte_ethdev/rte_flow.h +++ b/lib/librte_ethdev/rte_flow.h @@ -976,7 +976,7 @@ struct rte_flow_item_vxlan { /** Default mask for RTE_FLOW_ITEM_TYPE_VXLAN. */ #ifndef __cplusplus static const struct rte_flow_item_vxlan rte_flow_item_vxlan_mask = { - .hdr.vx_vni = RTE_BE32(__builtin_constant_p(0xffffff << 8)), + .hdr.vx_vni = RTE_BE32(0xffffff00), /* (0xffffff << 8) */ }; #endif