diff mbox series

net/mlx4: fix RSS action hash key null pointer

Message ID 20210407153015.32035-1-viacheslavo@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx4: fix RSS action hash key null pointer |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success travis build: passed
ci/github-robot success github build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS
ci/intel-Testing success Testing PASS

Commit Message

Slava Ovsiienko April 7, 2021, 3:30 p.m. UTC 
  If RSS action contains non zero hash key length and NULL
key buffer pointer the default hash key should be used.
The check for the NULL pointer this was missing in the mlx4
PMD causing crash, for example, in testpmd with command:

flow validate 0 ingress group 0
  pattern eth / ipv4 / end
  actions rss queues 0 end key_len 40 / end

Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 drivers/net/mlx4/mlx4_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Matan Azrad April 8, 2021, 9:36 a.m. UTC | #1 
From: Viacheslav Ovsiienko 
> If RSS action contains non zero hash key length and NULL key buffer pointer the
> default hash key should be used.
> The check for the NULL pointer this was missing in the mlx4 PMD causing
> crash, for example, in testpmd with command:
> 
> flow validate 0 ingress group 0
>   pattern eth / ipv4 / end
>   actions rss queues 0 end key_len 40 / end
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Acked-by: Matan Azrad <matan@nvidia.com>
Raslan Darawsheh April 11, 2021, 12:35 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, April 7, 2021 6:30 PM
> To: dev@dpdk.org
> Cc: Raslan Darawsheh <rasland@nvidia.com>; Matan Azrad
> <matan@nvidia.com>; Ori Kam <orika@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx4: fix RSS action hash key null pointer
> 
> If RSS action contains non zero hash key length and NULL
> key buffer pointer the default hash key should be used.
> The check for the NULL pointer this was missing in the mlx4
> PMD causing crash, for example, in testpmd with command:
> 
> flow validate 0 ingress group 0
>   pattern eth / ipv4 / end
>   actions rss queues 0 end key_len 40 / end
> 
> Fixes: ac8d22de2394 ("ethdev: flatten RSS configuration in flow API")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---

Patch applied to next-net-mlx,
Kindest regards
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c
index 43a65abcc0..71ea91b3fb 100644
--- a/drivers/net/mlx4/mlx4_flow.c
+++ b/drivers/net/mlx4/mlx4_flow.c
@@ -791,7 +791,8 @@  mlx4_flow_prepare(struct mlx4_priv *priv,
 			rss = action->conf;
 			/* Default RSS configuration if none is provided. */
 			if (rss->key_len) {
-				rss_key = rss->key;
+				rss_key = rss->key ?
+					  rss->key : mlx4_rss_hash_key_default;
 				rss_key_len = rss->key_len;
 			} else {
 				rss_key = mlx4_rss_hash_key_default;