diff mbox series

[1/5] mbuf: mark old offload flag as deprecated

Message ID 20210401095243.18211-2-david.marchand@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Offload flags fixes |

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

David Marchand April 1, 2021, 9:52 a.m. UTC 
  PKT_RX_EIP_CKSUM_BAD has been declared deprecated quite some time ago,
but there was no warning to applications still using it.
Fix this by marking as deprecated with the newly introduced
RTE_DEPRECATED.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/librte_mbuf/rte_mbuf_core.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Flavio Leitner April 7, 2021, 8:14 p.m. UTC | #1 
On Thu, Apr 01, 2021 at 11:52:39AM +0200, David Marchand wrote:
> PKT_RX_EIP_CKSUM_BAD has been declared deprecated quite some time ago,
> but there was no warning to applications still using it.
> Fix this by marking as deprecated with the newly introduced
> RTE_DEPRECATED.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Reviewed-by: Flavio Leitner <fbl@sysclose.org>
Olivier Matz April 8, 2021, 7:23 a.m. UTC | #2 
On Thu, Apr 01, 2021 at 11:52:39AM +0200, David Marchand wrote:
> PKT_RX_EIP_CKSUM_BAD has been declared deprecated quite some time ago,

It's not that old, it was done by Lance in commit e8a419d6de4b ("mbuf:
rename outer IP checksum macro") 1 month ago.

> but there was no warning to applications still using it.
> Fix this by marking as deprecated with the newly introduced
> RTE_DEPRECATED.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>

Acked-by: Olivier Matz <olivier.matz@6wind.com>
David Marchand April 8, 2021, 8:41 a.m. UTC | #3 
On Thu, Apr 8, 2021 at 9:24 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> On Thu, Apr 01, 2021 at 11:52:39AM +0200, David Marchand wrote:
> > PKT_RX_EIP_CKSUM_BAD has been declared deprecated quite some time ago,
>
> It's not that old, it was done by Lance in commit e8a419d6de4b ("mbuf:
> rename outer IP checksum macro") 1 month ago.

Err, I was pretty sure it was older... I probably misread some date.
Ok, I'll reword this and add a Fixes: tag just for info.
diff mbox series

Patch

diff --git a/lib/librte_mbuf/rte_mbuf_core.h b/lib/librte_mbuf/rte_mbuf_core.h
index c17dc95c51..bb38d7f581 100644
--- a/lib/librte_mbuf/rte_mbuf_core.h
+++ b/lib/librte_mbuf/rte_mbuf_core.h
@@ -83,7 +83,8 @@  extern "C" {
  * Deprecated.
  * This flag has been renamed, use PKT_RX_OUTER_IP_CKSUM_BAD instead.
  */
-#define PKT_RX_EIP_CKSUM_BAD PKT_RX_OUTER_IP_CKSUM_BAD
+#define PKT_RX_EIP_CKSUM_BAD \
+	RTE_DEPRECATED(PKT_RX_EIP_CKSUM_BAD) PKT_RX_OUTER_IP_CKSUM_BAD
 
 /**
  * A vlan has been stripped by the hardware and its tci is saved in